3b2b3aeea9
Update Cargo.toml for next release v0.3.0
2021-06-03 12:24:27 +02:00
fd598f060c
Merge #210
...
210: Check the benchmarks in the CI r=Kerollmops a=Kerollmops
Fixes #209 .
Co-authored-by: Kerollmops <clement@meilisearch.com >
2021-06-03 09:16:06 +00:00
99b45d2aa0
Make sure that all the workspaces crates compile
2021-06-03 10:56:01 +02:00
82fb5f0bef
Fix the benchmarks compilation
2021-06-03 10:33:42 +02:00
6b7841fefc
Make sure that the benchmarks always compile
2021-06-03 10:29:21 +02:00
834504aec0
Merge #204
...
204: Decorrelate Distinct, Asc/Desc, Filterable fields from the faceted fields r=Kerollmops a=Kerollmops
This PR decorrelates the fields that need to be stored in facet databases (big inverted indexes for fast access) from the filterable fields, the previously named faceted fields are now named filterable fields and are the union of the distinct attribute, all the Asc/Desc criteria and, the filterable fields.
I added two tests to make sure that the engine was correctly generating the faceted databases when a distinct attribute or an Asc/Desc criteria were added, and one to make sure that it was impossible to filter on a non-filterable field even if it was a faceted one.
Note that the `AttributesForFacetting` has also been renamed into `FilterableAttributes`. But it will be the Transplant's job to do that on the API, this change is only visible to the milli's library users.
- Related to https://github.com/meilisearch/transplant/issues/187 .
- Fixes #161 by returning the documents that don't have the Asc/Desc field at the end of the bucket.
- Fixes #168 .
- Fixes #152 .
Co-authored-by: Kerollmops <clement@meilisearch.com >
Co-authored-by: Marin Postma <postma.marin@protonmail.com >
Co-authored-by: many <maxime@meilisearch.com >
2021-06-02 15:43:39 +00:00
26a9974667
Make asc/desc criterion return resting documents
...
Fix #161.2
2021-06-02 17:41:48 +02:00
28962bce99
Merge #207
...
207: Benchmarks r=Kerollmops a=irevoire
Co-authored-by: tamo <tamo@meilisearch.com >
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com >
Co-authored-by: Tamo <irevoire@hotmail.fr >
Co-authored-by: Irevoire <tamo@meilisearch.com >
2021-06-02 15:29:09 +00:00
6dc08bf45e
remove the nop function
2021-06-02 17:09:21 +02:00
087ae64899
add a gitignore to avoid pushing the autogenerated file
2021-06-02 17:03:30 +02:00
3db25153e5
fix the faceted_fields one last time
2021-06-02 17:00:58 +02:00
3c304c89d4
Make sure that we generate the faceted database when required
2021-06-02 16:24:58 +02:00
b0c0490e85
Make sure that we can add a Asc/Desc field without it being filterable
2021-06-02 16:24:58 +02:00
3b1cd4c4b4
Rename the FacetCondition into FilterCondition
2021-06-02 16:24:58 +02:00
c2afdbb1fb
Move and comment some internal facet_condition helper functions
2021-06-02 16:24:58 +02:00
6476827d3a
Fix the indexer to be sure that distinct and Asc/Desc are also faceted
2021-06-02 16:24:58 +02:00
c10469ddb6
Patch the http-ui crate to support filterable fields
2021-06-02 16:24:58 +02:00
1e366dae3e
remove useless lifetime on Distinct Trait
2021-06-02 16:24:58 +02:00
187c713de5
Remove the MapDistinct struct as now distinct attributes are faceted
2021-06-02 16:24:57 +02:00
ff440c1d9d
Introduce the faceted fields method to retrieve those that needs faceting
2021-06-02 16:24:57 +02:00
2a3f9b32ff
Rename the faceted fields into filterable fields
2021-06-02 16:24:57 +02:00
f346805c0c
Update benchmarks/Cargo.toml
...
Co-authored-by: Clément Renault <clement@meilisearch.com >
2021-06-02 15:47:03 +02:00
ef1ac8a0cb
Update README
2021-06-02 11:13:22 +02:00
edfcdb171c
Update benchmarks/scripts/list.sh
...
Co-authored-by: Irevoire <tamo@meilisearch.com >
2021-06-02 11:13:22 +02:00
3c91a9a551
Update following reviews
2021-06-02 11:13:22 +02:00
bc4f4ee829
remove s3cmd as a dependency and provide a script to list all the available benchmarks
2021-06-02 11:13:22 +02:00
61fe422a88
Update benchmarks/scripts/compare.sh
...
Co-authored-by: Irevoire <tamo@meilisearch.com >
2021-06-02 11:13:22 +02:00
57ed96622b
Update benchmarks/scripts/compare.sh
...
Co-authored-by: Irevoire <tamo@meilisearch.com >
2021-06-02 11:13:22 +02:00
b3c0d43890
Update benchmarks/scripts/compare.sh
...
Co-authored-by: Irevoire <tamo@meilisearch.com >
2021-06-02 11:13:22 +02:00
0d0e900158
Add CI for benchmarks
2021-06-02 11:13:22 +02:00
4536dfccd0
add a way to provide primary_key or autogenerate documents ids
2021-06-02 11:13:20 +02:00
06c414a753
move the benchmarks to another crate so we can download the datasets automatically without adding overhead to the build of milli
2021-06-02 11:11:50 +02:00
3c84075d2d
uses an env variable to find the datasets
2021-06-02 11:05:07 +02:00
4969abeaab
update the facets for the benchmarks
2021-06-02 11:05:07 +02:00
e5dfde88fd
fix the facets conditions
2021-06-02 11:05:07 +02:00
7c7fba4e57
remove the time limitation to let criterion do what it wants
2021-06-02 11:05:07 +02:00
5d5d115608
reformat all the files
2021-06-02 11:05:07 +02:00
7086009f93
improve the base search
2021-06-02 11:05:07 +02:00
d0b44c380f
add benchmarks on a wiki dataset
2021-06-02 11:05:07 +02:00
beae843766
add a missing space
2021-06-02 11:05:07 +02:00
5132a106a1
refactorize everything related to the songs dataset in a songs benchmark file
2021-06-02 11:05:07 +02:00
136efd6b53
fix the benches
2021-06-02 11:05:07 +02:00
4b78ef31b6
add the configuration of the searchable fields and displayed fields and a default configuration for the songs
2021-06-02 11:05:07 +02:00
ea0c6d8c40
add a bunch of queries and start the introduction of the filters and the new dataset
2021-06-02 11:05:07 +02:00
3def42abd8
merge all the criterion only benchmarks in one file
2021-06-02 11:05:07 +02:00
a2bff68c1a
remove the optional words for the typo criterion
2021-06-02 11:05:07 +02:00
aee49bb3cd
add the proximity criterion
2021-06-02 11:05:07 +02:00
49e4cc3daf
add the words criterion to the bench
2021-06-02 11:05:07 +02:00
15cce89a45
update the README with instructions to get the download the dataset
2021-06-02 11:05:07 +02:00
e425f70ef9
let criterion decide how much iteration it wants to do in 10s
2021-06-02 11:05:07 +02:00