snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-11-22 04:36:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move the S3 snapshots to disk into a dedicated method

Browse Source
This commit is contained in:
Kerollmops
2025-10-13 11:49:14 +02:00
committed by Clément Renault
parent c8c1d95efd
commit 9ed7a81495
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
crates/index-scheduler/src/scheduler/process_snapshot_creation.rs
View File

@@ -85,7 +85,7 @@ impl IndexScheduler {
pub(super) fn process_snapshot(
&self,
progress: Progress,
mut tasks: Vec<Task>,
tasks: Vec<Task>,
) -> Result<Vec<Task>> {
progress.update_progress(SnapshotCreationProgress::StartTheSnapshotCreation);
@@ -109,7 +109,7 @@ impl IndexScheduler {
Ok(secret_key),
) => {
let runtime = self.runtime.as_ref().expect("Runtime not initialized");
return runtime.block_on(self.process_snapshot_to_s3(
runtime.block_on(self.process_snapshot_to_s3(
progress,
bucket_url,
bucket_region,
@@ -117,7 +117,7 @@ impl IndexScheduler {
access_key,
secret_key,
tasks,
));
))
}
(
Err(VarError::NotPresent),
@@ -125,7 +125,7 @@ impl IndexScheduler {
Err(VarError::NotPresent),
Err(VarError::NotPresent),
Err(VarError::NotPresent),
) => (),
) => self.process_snapshots_to_disk(progress, tasks),
(Err(e), _, _, _, _)
| (_, Err(e), _, _, _)
| (_, _, Err(e), _, _)
@@ -135,8 +135,13 @@ impl IndexScheduler {
panic!("Error while reading environment variables: {}", e);
}
}
}
// TODO move this code into a separate function
fn process_snapshots_to_disk(
&self,
progress: Progress,
mut tasks: Vec<Task>,
) -> Result<Vec<Task>, Error> {
fs::create_dir_all(&self.scheduler.snapshots_path)?;
let temp_snapshot_dir = tempfile::tempdir()?;