mirror of
				https://github.com/meilisearch/meilisearch.git
				synced 2025-10-31 07:56:28 +00:00 
			
		
		
		
	Apply review suggestions and stop using rtxn.commit
This commit is contained in:
		
				
					committed by
					
						 Clément Renault
						Clément Renault
					
				
			
			
				
	
			
			
			
						parent
						
							17cd2a4aa0
						
					
				
				
					commit
					11fee30f47
				
			| @@ -686,8 +686,7 @@ impl IndexScheduler { | ||||
|                     | IndexOperation::DocumentClear { ref index_uid, .. } => { | ||||
|                         // only get the index, don't create it | ||||
|                         let rtxn = self.env.read_txn()?; | ||||
|                         let r = self.index_mapper.index(&rtxn, index_uid)?; | ||||
|                         r | ||||
|                         self.index_mapper.index(&rtxn, index_uid)? | ||||
|                     } | ||||
|                     IndexOperation::DocumentImport { ref index_uid, allow_index_creation, .. } | ||||
|                     | IndexOperation::Settings { ref index_uid, allow_index_creation, .. } | ||||
| @@ -701,8 +700,7 @@ impl IndexScheduler { | ||||
|                             index | ||||
|                         } else { | ||||
|                             let rtxn = self.env.read_txn()?; | ||||
|                             let r = self.index_mapper.index(&rtxn, index_uid)?; | ||||
|                             r | ||||
|                             self.index_mapper.index(&rtxn, index_uid)? | ||||
|                         } | ||||
|                     } | ||||
|                 }; | ||||
|   | ||||
| @@ -718,7 +718,7 @@ impl IndexScheduler { | ||||
|             Some(batch) => batch, | ||||
|             None => return Ok(0), | ||||
|         }; | ||||
|         drop(rtxn); //rtxn.commit()?; | ||||
|         drop(rtxn); | ||||
|  | ||||
|         // 1. store the starting date with the bitmap of processing tasks. | ||||
|         let mut ids = batch.ids(); | ||||
|   | ||||
| @@ -80,8 +80,6 @@ pub fn snapshot_index_scheduler(scheduler: &IndexScheduler) -> String { | ||||
|     snap.push_str(&snapshot_file_store(file_store)); | ||||
|     snap.push_str("\n----------------------------------------------------------------------\n"); | ||||
|  | ||||
|     rtxn.commit().unwrap(); | ||||
|  | ||||
|     snap | ||||
| } | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user