Jakub Jirutka
13f1277637
Allow to disable specialized tokenizations (again)
...
In PR #2773 , I added the `chinese`, `hebrew`, `japanese` and `thai`
feature flags to allow melisearch to be built without huge specialed
tokenizations that took up 90% of the melisearch binary size.
Unfortunately, due to some recent changes, this doesn't work anymore.
The problem lies in excessive use of the `default` feature flag, which
infects the dependency graph.
Instead of adding `default-features = false` here and there, it's easier
and more future-proof to not declare `default` in `milli` and
`meilisearch-types`. I've renamed it to `all-tokenizers`, which also
makes it a bit clearer what it's about.
2023-05-04 15:45:40 +02:00
ManyTheFish
249053e514
Update feature flags
2023-04-26 14:59:25 +02:00
Kerollmops
47b66e49b8
Upgrade the compatible versions of the dependencies
2023-04-24 17:50:52 +02:00
bors[bot]
1e9ac00800
Merge #3505
...
3505: Csv delimiter r=irevoire a=irevoire
Fixes https://github.com/meilisearch/meilisearch/issues/3442
Closes https://github.com/meilisearch/meilisearch/pull/2803
Specified in https://github.com/meilisearch/specifications/pull/221
This PR is a reimplementation of https://github.com/meilisearch/meilisearch/pull/2803 , on the new engine. Thanks for your idea and initial PR `@MixusMinimax;` sorry I couldn’t update/merge your PR. Way too many changes happened on the engine in the meantime.
**Attention to reviewer**; I had to update deserr to implement the support of deserializing `char`s
-------
It introduces four new error messages;
- Invalid value in parameter csvDelimiter: expected a string of one character, but found an empty string
- Invalid value in parameter csvDelimiter: expected a string of one character, but found the following string of 5 characters: doggo
- csv delimiter must be an ascii character. Found: 🍰
- The Content-Type application/json does not support the use of a csv delimiter. The csv delimiter can only be used with the Content-Type text/csv.
And one error code;
- `invalid_index_csv_delimiter`
The `invalid_content_type` error code is now also used when we encounter the `csvDelimiter` query parameter with a non-csv content type.
Co-authored-by: Tamo <tamo@meilisearch.com >
2023-02-20 17:01:36 +00:00
Tamo
8c074f5028
implements the csv delimiter without tests
...
Co-authored-by: Maxi Barmetler <maxi.barmetler@gmail.com >
2023-02-16 17:35:36 +01:00
Tamo
74d1a67a99
Use the workspace inheritance feature of rust 1.64
2023-02-15 13:51:07 +01:00
Tamo
a43765d454
use the pre-defined deserr extractors
2023-02-14 20:05:30 +01:00
Tamo
8fb7b1d10f
bump deserr
2023-02-14 20:04:30 +01:00
dependabot[bot]
5f56e6dd58
Bump tokio from 1.24.1 to 1.24.2
...
Bumps [tokio](https://github.com/tokio-rs/tokio ) from 1.24.1 to 1.24.2.
- [Release notes](https://github.com/tokio-rs/tokio/releases )
- [Commits](https://github.com/tokio-rs/tokio/commits )
---
updated-dependencies:
- dependency-name: tokio
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-07 12:14:05 +00:00
Kerollmops
a377a49218
Make meiliserach depend on the local milli
2023-02-06 16:44:43 +01:00
Louis Dureuil
231067a1c4
Bump milli to v0.41.1
2023-02-01 11:53:39 +01:00
Tamo
8356f109c1
bump milli to fix the last test
2023-01-25 16:45:11 +01:00
Tamo
c79b6a1ee4
bump milli
2023-01-23 14:13:19 +01:00
ManyTheFish
f0e6b9c0c5
Update deserr to 0.3.0
2023-01-23 14:13:04 +01:00
LoĂŻc Lecrenier
c71a8ea183
Update to latest milli and deserr
2023-01-17 13:10:38 +01:00
LoĂŻc Lecrenier
07b90dec08
Remove unused proptest dependency
2023-01-17 11:07:07 +01:00
LoĂŻc Lecrenier
9194508a0f
Refactor query parameter deserialisation logic
2023-01-17 11:07:07 +01:00
LoĂŻc Lecrenier
766dd830ae
Update deserr to latest version + add new error codes for missing fields
...
- missing_api_key_indexes
- missing_api_key_actions
- missing_api_key_expires_at
- missing_swap_indexes_indexes
2023-01-17 09:43:07 +01:00
LoĂŻc Lecrenier
436ae4e466
Improve error messages generated by deserr
...
Split Json and Query Parameter error types
2023-01-17 09:43:07 +01:00
LoĂŻc Lecrenier
a09b6a341d
Move tasks route to deserr
2023-01-12 13:57:29 +01:00
Tamo
bf573885ea
integrate the latest version of milli
2023-01-11 19:08:39 +01:00
LoĂŻc Lecrenier
b0b7ad7caf
Apply review suggestions
2023-01-11 19:08:39 +01:00
LoĂŻc Lecrenier
c91ffec72e
Update Cargo.toml
2023-01-11 19:08:39 +01:00
LoĂŻc Lecrenier
1fc11264e8
Refactor deserr integration
2023-01-11 19:08:39 +01:00
Tamo
d17efb9ed6
use the published version of deserr
2023-01-09 12:51:10 +01:00
Tamo
50ce0409bc
Integrate deserr on the most important routes
2023-01-05 20:48:29 +01:00
LoĂŻc Lecrenier
2d74678b51
Replace underscores with hyphens in doc link to error code
2023-01-05 10:09:02 +01:00
Louis Dureuil
0e98a71a24
Update milli to v0.38
2023-01-04 14:24:20 +01:00
Tamo
d8fb506c92
handle most io error instead of tagging everything as an internal
2022-12-19 20:50:40 +01:00
Kerollmops
60c3bac108
Bump milli to v0.37.3
2022-12-14 17:25:40 +01:00
jiangbo212
7c24fea9f2
Merge branch 'main' into fix-3037
2022-12-13 05:16:03 +08:00
curquiza
4631f4d97f
Bump milli to v0.37.2
2022-12-08 18:16:48 +01:00
curquiza
026cf223b3
Update version for the next release (v1.0.0) in Cargo.toml files
2022-12-08 12:20:17 +00:00
jiangbo212
717dd36547
Merge branch 'fix-3037' of github.com:jiangbo212/meilisearch into fix-3037
2022-12-07 22:54:16 +08:00
Kerollmops
24c79b79f9
Bump milli to v0.37.1
2022-12-06 20:05:52 +01:00
curquiza
5db7c4057c
Update version for the next release (v0.30.1) in Cargo.toml files
2022-12-06 20:05:46 +01:00
jiangbo212
7b08d700f7
requested changes fix
2022-12-03 18:52:20 +08:00
jiangbo212
9c28632498
Merge branch 'main' into fix-3037
2022-11-30 09:38:01 +08:00
jiangbo212
38982d13fe
fix issue 3037
2022-11-30 00:03:22 +08:00
Clémentine Urquizar - curqui
457a473b72
Bring back release-v0.30.0
into release-v0.30.0-temp
(final: into main
) ( #3145 )
...
* Fix error code of the "duplicate index found" error
* Use the content of the ProcessingTasks in the tasks cancelation system
* Change the missing_filters error code into missing_task_filters
* WIP Introduce the invalid_task_uid error code
* Use more precise error codes/message for the task routes
+ Allow star operator in delete/cancel tasks
+ rename originalQuery to originalFilters
+ Display error/canceled_by in task view even when they are = null
+ Rename task filter fields by using their plural forms
+ Prepare an error code for canceledBy filter
+ Only return global tasks if the API key action `index.*` is there
* Add canceledBy task filter
* Update tests following task API changes
* Rename original_query to original_filters everywhere
* Update more insta-snap tests
* Make clippy happy
They're a happy clip now.
* Make rustfmt happy
>:-(
* Fix Index name parsing error message to fit the specification
* Bump milli version to 0.35.1
* Fix the new error messages
* fix the error messages and add tests
* rename the error codes for the sake of consistency
* refactor the way we send the cli informations + add the analytics for the config file and ssl usage
* Apply suggestions from code review
Co-authored-by: Clément Renault <clement@meilisearch.com >
* add a comment over the new infos structure
* reformat, sorry @kero
* Store analytics for the documents deletions
* Add analytics on all the settings
* Spawn threads with names
* Spawn rayon threads with names
* update the distinct attributes to the spec update
* update the analytics on the search route
* implements the analytics on the health and version routes
* Fix task details serialization
* Add the question mark to the task deletion query filter
* Add the question mark to the task cancelation query filter
* Fix tests
* add analytics on the task route
* Add all the missing fields of the new task query type
* Create a new analytics for the task deletion
* Create a new analytics for the task creation
* batch the tasks seen events
* Update the finite pagination analytics
* add the analytics of the swap-indexes route
* Stop removing the DB when failing to read it
* Rename originalFilters into originalFilters
* Rename matchedDocuments into providedIds
* Add `workflow_dispatch` to flaky.yml
* Bump grenad to 0.4.4
* Bump milli to version v0.37.0
* Don't multiply total memory returned by sysinfo anymore
sysinfo now returns bytes rather than KB
* Add a dispatch to the publish binaries workflow
* Fix publish release CI
* Don't use gold but the default linker
* Always display details for the indexDeletion task
* Fix the insta tests
* refactorize the whole test suite
1. Make a call to assert_internally_consistent automatically when snapshoting the scheduler. There is no point in snapshoting something broken and expect the dumb humans to notice.
2. Replace every possible call to assert_internally_consistent by a snapshot of the scheduler. It takes as many lines and ensure we never change something without noticing in any tests ever.
3. Name every snapshots: it's easier to debug when something goes wrong and easier to review in general.
4. Stop skipping breakpoints, it's too easy to miss something. Now you must explicitely show which path is the scheduler supposed to use.
5. Add a timeout on the channel.recv, it eases the process of writing tests, now when something file you get a failure instead of a deadlock.
* rebase on release-v0.30
* makes clippy happy
* update the snapshots after a rebase
* try to remove the flakyness of the failing test
* Add more analytics on the ranking rules positions
* Update the dump test to check for the dumpUid dumpCreation task details
* send the ranking rules as a string because amplitude is too dumb to process an array as a single value
* Display a null dumpUid until we computed the dump itself on disk
* Update tests
* Check if the master key is missing before returning an error
Co-authored-by: LoĂŻc Lecrenier <loic.lecrenier@me.com >
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Kerollmops <clement@meilisearch.com >
Co-authored-by: ManyTheFish <many@meilisearch.com >
Co-authored-by: Tamo <tamo@meilisearch.com >
Co-authored-by: Louis Dureuil <louis@meilisearch.com >
2022-11-28 16:27:41 +01:00
curquiza
68f80dbacf
Update version for the next release (v0.30.0) in Cargo.toml files
2022-10-27 11:35:44 +00:00
Irevoire
953055e3d7
bump milli
2022-10-27 11:35:21 +02:00
Irevoire
8ebb49d1b1
bump milli
2022-10-27 11:35:19 +02:00
Kerollmops
942b7c338b
Compress the snapshot in a tarball
2022-10-27 11:35:15 +02:00
Kerollmops
4cafc63561
Reintroduce the versioning functions
2022-10-27 11:35:14 +02:00
Clément Renault
32cfac0cfd
Sort the TOML dependencies
2022-10-27 11:35:05 +02:00
Clément Renault
ce4dcf47f0
Reapply #2773
2022-10-27 11:34:18 +02:00
Kerollmops
b2c5bc67b7
Add more enum-iterator related stuff
2022-10-27 11:34:11 +02:00
Kerollmops
c9523c6f39
Use the indexation-abortion milli's branch
2022-10-27 11:34:10 +02:00
Tamo
d1a6fb2971
bump enum-iter and fix a bunch of error messages
2022-10-27 11:34:09 +02:00