290e773d23
remove more warnings and fix some tests
2023-10-30 11:41:22 +01:00
113527f466
Remove soft-deleted related methods from Index
2023-10-30 11:41:22 +01:00
2263dff02b
Stop using removed delete pipelines almost everywhere
2023-10-30 11:41:22 +01:00
d651b3ef01
Remove delete documents files
2023-10-30 11:41:20 +01:00
073f89db79
Fix facet tests
2023-10-30 11:40:20 +01:00
b26dc9aabe
Explanatory code comment
2023-10-30 11:39:31 +01:00
66abac9364
Use specialized KvReaderDelAdd type
...
Co-authored-by: Clément Renault <clement@meilisearch.com >
2023-10-30 11:39:31 +01:00
59f88c14b3
Simplify facet update after removing Index::faceted_documents_ids
2023-10-30 11:39:29 +01:00
14832cb324
Remove Index::faceted_documents_ids
2023-10-30 11:37:32 +01:00
04ec293024
Facet Incremental update
2023-10-30 11:37:30 +01:00
f67ff3a738
Facets Bulk update
2023-10-30 11:36:40 +01:00
0c47defeee
Work on fid docid facet values rewrite
2023-10-30 11:29:06 +01:00
d772073dfa
use a bufreader everytime there is a grenad<file>
2023-10-10 15:00:30 +02:00
35758db9ec
Truncate the the normalized long facets used in search for facet value
2023-08-08 16:38:30 +02:00
df528b41d8
Normalize for the search the facets values
2023-07-20 17:57:07 +02:00
e9a3029c30
Use the right field id to write the string facet values FST
2023-06-28 15:01:51 +02:00
f36de2115f
Make clippy happy
2023-06-28 15:01:50 +02:00
15a4c05379
Store the facet string values in multiple FSTs
2023-06-28 14:58:41 +02:00
c4a40e7110
Use the writemap flag to reduce the memory usage
2023-05-15 10:15:33 +02:00
cfd1b2cc97
Fix the clippy warnings
2023-04-25 16:40:32 +02:00
fbec48f56e
Merge remote-tracking branch 'milli/main' into bring-v1-changes
2023-02-06 16:48:10 +01:00
20f05efb3c
clippy: needless_lifetimes
2023-01-31 11:12:59 +01:00
3296cf7ae6
clippy: remove needless lifetimes
2023-01-31 09:32:40 +01:00
1b78231e18
Make clippy happy
2023-01-17 18:25:54 +01:00
ad9937c755
Fix tests after adding DeletionStrategy
2022-12-19 10:07:17 +01:00
cda4ba2bb6
Add document import tests
2022-12-05 12:02:49 +01:00
f2cf981641
Add more tests and allow disabling of soft-deletion outside of tests
...
Also allow disabling soft-deletion in the IndexDocumentsConfig
2022-12-05 10:51:01 +01:00
9dd4b33a9a
Fix bulk facet indexing bug
2022-11-30 14:27:36 +01:00
0caadedd3b
Make clippy happy
2022-11-17 12:17:53 +01:00
d95d02cb8a
Fix Facet Indexing bugs
...
1. Handle keys with variable length correctly
This fixes https://github.com/meilisearch/meilisearch/issues/3042 and
is easily reproducible with the updated fuzz tests, which now generate
keys with variable lengths.
2. Prevent adding facets to the database if their encoded value does
not satisfy `valid_lmdb_key`.
This fixes an indexing failure when a document had a filterable
attribute containing a value whose length is higher than ~500 bytes.
2022-11-17 11:29:42 +01:00
abf1cf9cd5
Fix clippy errors
2022-11-04 09:27:46 +09:00
d55f0e2e53
Execute cargo fmt
2022-10-28 23:42:23 +09:00
d53a80b408
Fix clippy error
2022-10-28 23:41:35 +09:00
a1d7ed1258
fix clippy error and remove clippy job from ci
...
Remove clippy job
Fix clippy error type_complexity
Restore ambiguous change
2022-10-28 22:33:50 +09:00
f4ec1abb9b
Fix all clippy error after conflicts
2022-10-27 23:58:13 +09:00
14ca8048a8
Add some documentation on how to run the facet db fuzzer
2022-10-26 13:48:01 +02:00
f198b20c42
Add facet deletion tests that use both the incremental and bulk methods
...
+ update deletion snapshots to the new database format
2022-10-26 13:47:46 +02:00
2295e0e3ce
Use real delete function in facet indexing fuzz tests
...
By deleting multiple docids at once instead of one-by-one
2022-10-26 13:47:46 +02:00
acc8caebe6
Add link to GitHub PR to document of update/facet module
2022-10-26 13:47:46 +02:00
a034a1e628
Move StrRefCodec and ByteSliceRefCodec to their own files
2022-10-26 13:47:46 +02:00
1165ba2171
Make facet deletion incremental
2022-10-26 13:47:04 +02:00
3baa34d842
Fix compiler errors/warnings
2022-10-26 13:47:04 +02:00
86d9f50b9c
Fix bugs in incremental facet indexing with variable parameters
...
e.g. add one facet value incrementally with a group_size = X and then
add another one with group_size = Y
It is not actually possible to do so with the public API of milli,
but I wanted to make sure the algorithm worked well in those cases
anyway.
The bugs were found by fuzzing the code with fuzzcheck, which I've added
to milli as a conditional dev-dependency. But it can be removed later.
2022-10-26 13:47:04 +02:00
985a94adfc
cargo fmt
2022-10-26 13:47:04 +02:00
b1ab09196c
Remove outdated TODOs
2022-10-26 13:47:04 +02:00
27454e9828
Document and refine facet indexing algorithms
2022-10-26 13:47:04 +02:00
bee3c23b45
Add comparison benchmark between bulk and incremental facet indexing
2022-10-26 13:47:04 +02:00
b2f01ad204
Refactor facet database tests
2022-10-26 13:47:04 +02:00
9026867d17
Give same interface to bulk and incremental facet indexing types
...
+ cargo fmt, oops, sorry for the bad history :(
2022-10-26 13:47:04 +02:00
330c9eb1b2
Rename facet codecs and refine FacetsUpdate API
2022-10-26 13:47:04 +02:00
