f2cf981641
Add more tests and allow disabling of soft-deletion outside of tests
...
Also allow disabling soft-deletion in the IndexDocumentsConfig
2022-12-05 10:51:01 +01:00
a836b8e703
tests: Tests filter with non-finite floats
2022-11-08 13:56:55 +01:00
3328560788
fix: allow filters on = inf, = NaN, return InvalidFilter for < inf, < NaN
...
Fixes meilisearch/meilisearch#3000
2022-11-08 13:27:15 +01:00
13175f2339
refactor: match for filterCondition
2022-11-03 17:34:33 +09:00
f3c0b05ae8
Fix rust fmt
2022-10-28 09:32:31 +09:00
f4ec1abb9b
Fix all clippy error after conflicts
2022-10-27 23:58:13 +09:00
c7322f704c
Fix cargo clippy errors
...
Dont apply clippy for tests for now
Fix clippy warnings of filter-parser package
parent 8352febd646ec4bcf56a44161e5c4dce0e55111f
author unvalley <38400669+unvalley@users.noreply.github.com > 1666325847 +0900
committer unvalley <kirohi.code@gmail.com > 1666791316 +0900
Update .github/workflows/rust.yml
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com >
Allow clippy lint too_many_argments
Allow clippy lint needless_collect
Allow clippy lint too_many_arguments and type_complexity
Fix for clippy warnings comparison_chains
Fix for clippy warnings vec_init_then_push
Allow clippy lint should_implement_trait
Allow clippy lint drop_non_drop
Fix lifetime clipy warnings in filter-paprser
Execute cargo fmt
Fix clippy remaining warnings
Fix clippy remaining warnings again and allow lint on each place
2022-10-27 01:04:23 +09:00
54c0cf93fe
Merge remote-tracking branch 'origin/main' into facet-levels-refactor
2022-10-26 15:13:34 +02:00
3b1f908e5e
Revert behaviour of facet distribution to what it was before
...
Where the docid that is used to get the original facet string value
definitely belongs to the candidates
2022-10-26 13:48:01 +02:00
a034a1e628
Move StrRefCodec and ByteSliceRefCodec to their own files
2022-10-26 13:47:46 +02:00
d0109627b9
Fix a bug in facet_range_search and add documentation
2022-10-26 13:47:04 +02:00
86d9f50b9c
Fix bugs in incremental facet indexing with variable parameters
...
e.g. add one facet value incrementally with a group_size = X and then
add another one with group_size = Y
It is not actually possible to do so with the public API of milli,
but I wanted to make sure the algorithm worked well in those cases
anyway.
The bugs were found by fuzzing the code with fuzzcheck, which I've added
to milli as a conditional dev-dependency. But it can be removed later.
2022-10-26 13:47:04 +02:00
de52a9bf75
Improve documentation of some facet-related algorithms
2022-10-26 13:47:04 +02:00
985a94adfc
cargo fmt
2022-10-26 13:47:04 +02:00
3d7ed3263f
Fix bug in string facet distribution with few candidates
2022-10-26 13:47:04 +02:00
fca4577e23
Return original string in facet distributions, work on facet tests
2022-10-26 13:47:04 +02:00
b2f01ad204
Refactor facet database tests
2022-10-26 13:47:04 +02:00
9026867d17
Give same interface to bulk and incremental facet indexing types
...
+ cargo fmt, oops, sorry for the bad history :(
2022-10-26 13:47:04 +02:00
330c9eb1b2
Rename facet codecs and refine FacetsUpdate API
2022-10-26 13:47:04 +02:00
485a72306d
Refactor facet-related codecs
2022-10-26 13:47:04 +02:00
079ed4a992
Add more snapshots
2022-10-26 13:47:04 +02:00
a7201ece04
cargo fmt
2022-10-26 13:47:04 +02:00
36296bbb20
Add facet incremental indexing snapshot tests + fix bug
2022-10-26 13:47:04 +02:00
07ff92c663
Add more snapshots from facet tests
2022-10-26 13:47:04 +02:00
61252248fb
Fix some facet indexing bugs
2022-10-26 13:47:04 +02:00
68cbcdf08b
Fix compile errors/warnings in http-ui and infos
2022-10-26 13:47:04 +02:00
85824ee203
Try to make facet indexing incremental
2022-10-26 13:47:04 +02:00
d30c89e345
Fix compile error+warnings in new tests
2022-10-26 13:46:46 +02:00
e8a156d682
Reorganise facets database indexing code
2022-10-26 13:46:46 +02:00
e570c23153
Reintroduce asc/desc functionality
2022-10-26 13:46:14 +02:00
bd2c0e1ab6
Remove unused code
2022-10-26 13:46:14 +02:00
39a4a0a362
Reintroduce filter range search and facet extractors
2022-10-26 13:46:14 +02:00
5a904cf29d
Reintroduce facet distribution functionality
2022-10-26 13:46:14 +02:00
b8a1caad5e
Add range search and incremental indexing algorithm
2022-10-26 13:46:14 +02:00
63ef0aba18
Start porting facet distribution and sort to new database structure
2022-10-26 13:46:14 +02:00
c3f49f766d
Prepare refactor of facets database
...
Prepare refactor of facets database
2022-10-26 13:46:14 +02:00
6b2fe94192
Fixes for clippy bringing us down to 18 remaining issues.
...
This brings us a step closer to enforcing clippy on each build.
2022-10-25 20:49:02 +02:00
f6024b3269
Remove the artifacts of the past
2022-08-23 16:10:38 +02:00
9b6602cba2
Avoid cloning FilterCondition in filter array parsing
2022-08-18 13:06:57 +02:00
c51dcad51b
Don't recompute filterable fields in evaluation of IN[] filter
2022-08-18 10:59:21 +02:00
196f79115a
Run cargo fmt
2022-08-17 12:28:33 +02:00
ca97cb0eda
Implement the IN filter operator
2022-08-17 12:28:33 +02:00
cc7415bb31
Simplify FilterCondition code, made possible by the new NOT operator
2022-08-17 12:28:33 +02:00
44744d9e67
Implement the simplified NOT operator
2022-08-17 12:28:33 +02:00
01675771d5
Reimplement != filter to select all docids not selected by =
2022-08-17 12:28:33 +02:00
258c3dd563
Make AND+OR filters n-ary (store a vector of subfilters instead of 2)
...
NOTE: The token_at_depth is method is a bit useless now, as the only
cases where there would be a toke at depth 1000 are the cases where
the parser already stack-overflowed earlier.
Example: (((((... (x=1) ...)))))
2022-08-17 12:28:33 +02:00
dea00311b6
Add type annotations to remove compiler error
2022-08-16 09:19:30 +02:00
748bb86b5b
cargo fmt
2022-08-10 15:53:46 +02:00
8ac24d3114
Cargo fmt + fix compiler warnings/error
2022-08-10 15:53:46 +02:00
58cb1c1bda
Simplify unit tests in facet/filter.rs
2022-08-04 12:03:44 +02:00
