Tamo 
							
						 
					 
					
						
						
							
						
						fc098022c7 
					 
					
						
						
							
							start integrating the index-scheduler in the meilisearch codebase  
						
						
						
						
					 
					
						2022-10-27 11:33:40 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						b816535e33 
					 
					
						
						
							
							greatly reduce the number of warnings  
						
						
						
						
					 
					
						2022-10-27 11:33:40 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						38e4ffe73c 
					 
					
						
						
							
							fix smol typo  
						
						
						
						
					 
					
						2022-10-27 11:33:40 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						366a344474 
					 
					
						
						
							
							get rids of the horrendous spinlock in favor of synchronoise  
						
						
						
						
					 
					
						2022-10-27 11:33:39 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						7b6673dc1d 
					 
					
						
						
							
							implement the index swap in the index mapper  
						
						
						
						
					 
					
						2022-10-27 11:33:39 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						03aca2e452 
					 
					
						
						
							
							move the index mapping logic in another structure  
						
						
						
						
					 
					
						2022-10-27 11:33:39 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						4129783019 
					 
					
						
						
							
							migrate the index handling code in a different file + implements the create index  
						
						
						
						
					 
					
						2022-10-27 11:33:39 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						1804416afa 
					 
					
						
						
							
							reintroduce the uuid mapping for the indexes  
						
						
						
						
					 
					
						2022-10-27 11:33:39 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						c97d51a624 
					 
					
						
						
							
							add a bunch of tests  
						
						
						
						
					 
					
						2022-10-27 11:33:39 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						803f2157af 
					 
					
						
						
							
							split the DocumentAdditionOrUpdate in two tasks; DocumentAddition and DocumentUpdate  
						
						
						
						
					 
					
						2022-10-27 11:33:38 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						b7c5b71a53 
					 
					
						
						
							
							starts importing the real tasks  
						
						
						
						
					 
					
						2022-10-27 11:33:38 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						5cc8f96237 
					 
					
						
						
							
							get rids of the auto-generated mains  
						
						
						
						
					 
					
						2022-10-27 11:33:38 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						94e29a9f5f 
					 
					
						
						
							
							extract the index abstraction out of the index-scheduler in its own module  
						
						
						
						
					 
					
						2022-10-27 11:33:38 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						48138c21a9 
					 
					
						
						
							
							rename the update-file-store to file-store since it can store any kind of file  
						
						
						
						
					 
					
						2022-10-27 11:33:38 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						76597fc382 
					 
					
						
						
							
							import the update_file_store in the index-scheduler  
						
						
						
						
					 
					
						2022-10-27 11:33:37 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						2afb381f95 
					 
					
						
						
							
							get rids of nelson  
						
						
						
						
					 
					
						2022-10-27 11:33:37 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						a9844bd4f6 
					 
					
						
						
							
							move the update file store to another crate with as little dependencies as possible  
						
						
						
						
					 
					
						2022-10-27 11:33:37 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						a0588d6b94 
					 
					
						
						
							
							finishes the global skelton of the auto-batcher  
						
						
						
						
					 
					
						2022-10-27 11:33:37 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						b3c9b128d9 
					 
					
						
						
							
							polish the global structure of the batch creation  
						
						
						
						
					 
					
						2022-10-27 11:33:37 +02:00 
						 
				 
			
				
					
						
							
							
								Irevoire 
							
						 
					 
					
						
						
							
						
						448f44f631 
					 
					
						
						
							
							move the autobatcher logic to another file  
						
						
						
						
					 
					
						2022-10-27 11:33:36 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						f638774764 
					 
					
						
						
							
							add the document format file  
						
						
						
						
					 
					
						2022-10-27 11:33:36 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						516860f342 
					 
					
						
						
							
							fix the create_new_batch method  
						
						
						
						
					 
					
						2022-10-27 11:33:36 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						6b9689a1c0 
					 
					
						
						
							
							fix the whole batchKind thingy  
						
						
						
						
					 
					
						2022-10-27 11:33:36 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						af0f5d6c0c 
					 
					
						
						
							
							implements most operations  
						
						
						
						
					 
					
						2022-10-27 11:33:36 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						5a7fcf2688 
					 
					
						
						
							
							fix a few typos  
						
						
						
						
					 
					
						2022-10-27 11:33:35 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						30d2b24689 
					 
					
						
						
							
							implements the index deletion, creation and swap  
						
						
						
						
					 
					
						2022-10-27 11:33:35 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						72b2e68de4 
					 
					
						
						
							
							makes the updates getters smoother to uses  
						
						
						
						
					 
					
						2022-10-27 11:33:35 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						7879189c6b 
					 
					
						
						
							
							make the project compile again  
						
						
						
						
					 
					
						2022-10-27 11:33:35 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						46b8ebcab4 
					 
					
						
						
							
							fix the file store  
						
						
						
						
					 
					
						2022-10-27 11:33:35 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						fa742f60e8 
					 
					
						
						
							
							make the file store entirely synchronous, including the file deletion  
						
						
						
						
					 
					
						2022-10-27 11:33:35 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						a7aa92df5f 
					 
					
						
						
							
							fix most of the index module  
						
						
						
						
					 
					
						2022-10-27 11:33:34 +02:00 
						 
				 
			
				
					
						
							
							
								Irevoire 
							
						 
					 
					
						
						
							
						
						d8b8e04ad1 
					 
					
						
						
							
							wip porting the index back in the scheduler  
						
						
						
						
					 
					
						2022-10-27 11:33:34 +02:00 
						 
				 
			
				
					
						
							
							
								Irevoire 
							
						 
					 
					
						
						
							
						
						fe330e1be9 
					 
					
						
						
							
							add a little bit of documentation  
						
						
						
						
					 
					
						2022-10-27 11:33:34 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						2c4e5ce8be 
					 
					
						
						
							
							implements the filter query  
						
						
						
						
					 
					
						2022-10-27 11:33:34 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						705af94fd7 
					 
					
						
						
							
							add the task to the index db in the register task  
						
						
						
						
					 
					
						2022-10-27 11:33:34 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						ed745591e1 
					 
					
						
						
							
							split the scheduler into multiples files  
						
						
						
						
					 
					
						2022-10-27 11:33:34 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						22d24dba56 
					 
					
						
						
							
							implement the get_batch method  
						
						
						
						
					 
					
						2022-10-27 11:33:33 +02:00 
						 
				 
			
				
					
						
							
							
								Tamo 
							
						 
					 
					
						
						
							
						
						1a47949063 
					 
					
						
						
							
							START THE REWRITE OF THE INDEX SCHEDULER: index & register has been implemented  
						
						
						
						
					 
					
						2022-10-27 11:33:33 +02:00 
						 
				 
			
				
					
						
							
							
								bors[bot] 
							
						 
					 
					
						
						
							
						
						ab1800551f 
					 
					
						
						
							
							Merge  #2922  
						
						... 
						
						
						
						2922: Add new error when using /keys without masterkey set r=ManyTheFish a=vishalsodani
# Pull Request
## Related issue
Fixes  #2918  
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Co-authored-by: vishalsodani <vishalsodani@rediffmail.com > 
						
						
					 
					
						2022-10-27 09:13:11 +00:00 
						 
				 
			
				
					
						
							
							
								vishalsodani 
							
						 
					 
					
						
						
							
						
						689bef7ad2 
					 
					
						
						
							
							fmt the code  
						
						
						
						
					 
					
						2022-10-27 14:09:38 +05:30 
						 
				 
			
				
					
						
							
							
								vishalsodani 
							
						 
					 
					
						
						
							
						
						89c40c83c3 
					 
					
						
						
							
							refactor code to avoid cloning  
						
						
						
						
					 
					
						2022-10-27 14:08:29 +05:30 
						 
				 
			
				
					
						
							
							
								vishalsodani 
							
						 
					 
					
						
						
							
						
						03ba830ab2 
					 
					
						
						
							
							uncomment tests  
						
						
						
						
					 
					
						2022-10-27 12:59:28 +05:30 
						 
				 
			
				
					
						
							
							
								vishalsodani 
							
						 
					 
					
						
						
							
						
						9cf3ff72a3 
					 
					
						
						
							
							fix checking of master key as per review comment  
						
						
						
						
					 
					
						2022-10-27 12:56:18 +05:30 
						 
				 
			
				
					
						
							
							
								Samyak S Sarnayak 
							
						 
					 
					
						
						
							
						
						d35afa0cf5 
					 
					
						
						
							
							Change consecutive phrase search grouping logic  
						
						... 
						
						
						
						Co-authored-by: ManyTheFish <many@meilisearch.com > 
						
						
					 
					
						2022-10-26 23:10:48 +05:30 
						 
				 
			
				
					
						
							
							
								Samyak S Sarnayak 
							
						 
					 
					
						
						
							
						
						752d031010 
					 
					
						
						
							
							Update phrase search to use new execute method  
						
						
						
						
					 
					
						2022-10-26 23:07:20 +05:30 
						 
				 
			
				
					
						
							
							
								bors[bot] 
							
						 
					 
					
						
						
							
						
						25ec51e783 
					 
					
						
						
							
							Merge  #2601  
						
						... 
						
						
						
						2601: Ease search result pagination r=Kerollmops a=ManyTheFish
# Summary
This PR is a prototype enhancing search results pagination (#2577 )
# Todo
- [x] Update the API to return the number of pages and allow users to directly choose a page instead of computing an offset
- [x] Change computation of `total_pages` in order to have an exact count
  - [x] compute query tree exhaustively
  - [x] compute distinct exhaustively
# Small Documentation
## Default search query
**request**:
```sh
curl \
  -X POST 'http://localhost:7700/indexes/movies/search ' \
  -H 'Content-Type: application/json' \
  --data-binary '{ "q": "botman" }'
```
**result**:
```json
{
  "hits":[...],
  "query":"botman",
  "processingTimeMs":5,
  "hitsPerPage":20,
  "page":1,
  "totalPages":4,
  "totalHits":66
}
```
## Search query with offset parameter
**request**:
```sh
curl \
  -X POST 'http://localhost:7700/indexes/movies/search ' \
  -H 'Content-Type: application/json' \
  --data-binary '{ "q": "botman", "offset": 0 }'
```
**result**:
```json
{
  "hits":[...],
  "query":"botman",
  "processingTimeMs":3,
  "limit":20,
  "offset":0,
  "estimatedTotalHits":66
}
```
## Search query selecting page with page parameter
**request**:
```sh
curl \
  -X POST 'http://localhost:7700/indexes/movies/search ' \
  -H 'Content-Type: application/json' \
  --data-binary '{ "q": "botman", "page": 2 }'
```
**result**:
```json
{
  "hits":[...],
  "query":"botman",
  "processingTimeMs":5,
  "hitsPerPage":20,
  "page":2,
  "totalPages":4,
  "totalHits":66
}
```
# Related
fixes  #2577 
## In charge of the feature
Core: `@ManyTheFish` 
Docs: `@guimachiavelli` 
Integration: `@bidoubiwa` 
Co-authored-by: ManyTheFish <many@meilisearch.com > 
						
						
					 
					
						2022-10-26 16:10:58 +00:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						f4021273b8 
					 
					
						
						
							
							Add is_finite_pagination method to SearchQuery  
						
						
						
						
					 
					
						2022-10-26 18:08:29 +02:00 
						 
				 
			
				
					
						
							
							
								unvalley 
							
						 
					 
					
						
						
							
						
						c7322f704c 
					 
					
						
						
							
							Fix cargo clippy errors  
						
						... 
						
						
						
						Dont apply clippy for tests for now
Fix clippy warnings of filter-parser package
parent 8352febd646ec4bcf56a44161e5c4dce0e55111f
author unvalley <38400669+unvalley@users.noreply.github.com > 1666325847 +0900
committer unvalley <kirohi.code@gmail.com > 1666791316 +0900
Update .github/workflows/rust.yml
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com >
Allow clippy lint too_many_argments
Allow clippy lint needless_collect
Allow clippy lint too_many_arguments and type_complexity
Fix for clippy warnings comparison_chains
Fix for clippy warnings vec_init_then_push
Allow clippy lint should_implement_trait
Allow clippy lint drop_non_drop
Fix lifetime clipy warnings in filter-paprser
Execute cargo fmt
Fix clippy remaining warnings
Fix clippy remaining warnings again and allow lint on each place 
						
						
					 
					
						2022-10-27 01:04:23 +09:00 
						 
				 
			
				
					
						
							
							
								unvalley 
							
						 
					 
					
						
						
							
						
						811f156031 
					 
					
						
						
							
							Execute cargo clippy --fix  
						
						
						
						
					 
					
						2022-10-27 01:00:00 +09:00 
						 
				 
			
				
					
						
							
							
								unvalley 
							
						 
					 
					
						
						
							
						
						d8fed1f7a9 
					 
					
						
						
							
							Add clippy job  
						
						... 
						
						
						
						Add Run Clippy to bors.toml 
						
						
					 
					
						2022-10-27 01:00:00 +09:00