bors[bot]
c1ad56281d
Merge #2545 #2556 #2568 #2573 #2574 #2575
...
2545: meilisearch-lib was missing a feature in its cargo.toml r=Kerollmops a=irevoire
Meilisearch-lib was missing a feature to compile on its own
2556: chore: `meilisearch-http` readability improvements r=curquiza a=ryanrussell
## What does this PR do?
Readability improvements in `meilisearch-http`.
Believe these are pretty straightforward; let me know if anything needs adjusted or reverted :)
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
2568: Improve manifest for dependabot r=curquiza a=curquiza
Improve dependabot manifest
- `rebase-strategy: disabled` -> avoid issues with bors we had in the past with the integration team. The automatic rebase of dependabot does not fit with the rebase bors will try to do
- `labels` -> better triage for when I create the release changelogs
2573: Bump docker/login-action from 1 to 2 r=curquiza a=dependabot[bot]
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1 to 2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/login-action/releases ">docker/login-action's releases</a>.</em></p>
<blockquote>
<h2>v2.0.0</h2>
<ul>
<li>Node 16 as default runtime by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/161 ">#161</a>)
<ul>
<li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0 ">Actions Runner</a> version of v2.285.0, which is by default available in GHES 3.4 or later.</li>
</ul>
</li>
<li>chore: update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/170 ">#170</a>)</li>
<li>Bump <code>`@actions/exec</code>` from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/167 ">#167</a>)</li>
<li>Bump <code>`@actions/io</code>` from 1.1.1 to 1.1.2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/168 ">#168</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/176 ">#176</a>)</li>
<li>Bump https-proxy-agent from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/182 ">#182</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/login-action/compare/v1.14.1...v2.0.0 ">https://github.com/docker/login-action/compare/v1.14.1...v2.0.0 </a></p>
<h2>v1.14.1</h2>
<ul>
<li>Revert to Node 12 as default runtime to fix issue for GHE users (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/160 ">#160</a>)</li>
</ul>
<h2>v1.14.0</h2>
<ul>
<li>Update to node 16 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/158 ">#158</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr</code>` from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/157 ">#157</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr-public</code>` from 3.45.0 to 3.53.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/156 ">#156</a>)</li>
</ul>
<h2>v1.13.0</h2>
<ul>
<li>Handle proxy settings for aws-sdk (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/152 ">#152</a>)</li>
<li>Workload identity based authentication docs for GCR and GAR (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/112 ">#112</a>)</li>
<li>Test login against ACR (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/49 ">#49</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr</code>` from 3.44.0 to 3.45.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/132 ">#132</a>)</li>
<li>Bump <code>`@aws-sdk/client-ecr-public</code>` from 3.43.0 to 3.45.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/131 ">#131</a>)</li>
</ul>
<h2>v1.12.0</h2>
<ul>
<li>ECR: only set credentials if username and password are specified (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/128 ">#128</a>)</li>
<li>Refactor to use aws-sdk v3 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/128 ">#128</a>)</li>
</ul>
<h2>v1.11.0</h2>
<ul>
<li>ECR: switch implementation to use the AWS SDK (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/126 ">#126</a>)</li>
<li><code>ecr</code> input to specify whether the given registry is ECR (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/123 ">#123</a>)</li>
<li>Test against Windows runner (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/126 ">#126</a>)</li>
<li>Update instructions for Google registry (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/127 ">#127</a>)</li>
<li>Update dev workflow (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/111 ">#111</a>)</li>
<li>Small changes for GHCR doc (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/86 ">#86</a>)</li>
<li>Update dev dependencies (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/85 ">#85</a>)</li>
<li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/101 ">#101</a>)</li>
<li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/100 ">#100</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.4.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/94 ">#94</a> <a href="https://github-redirect.dependabot.com/docker/login-action/issues/103 ">#103</a>)</li>
<li>Bump codecov/codecov-action from 1 to 2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/88 ">#88</a>)</li>
<li>Bump hosted-git-info from 2.8.8 to 2.8.9 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/83 ">#83</a>)</li>
<li>Bump node-notifier from 8.0.0 to 8.0.2 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/82 ">#82</a>)</li>
<li>Bump ws from 7.3.1 to 7.5.0 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/81 ">#81</a>)</li>
<li>Bump lodash from 4.17.20 to 4.17.21 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/80 ">#80</a>)</li>
<li>Bump y18n from 4.0.0 to 4.0.3 (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/79 ">#79</a>)</li>
</ul>
<h2>v1.10.0</h2>
<ul>
<li>GitHub Packages Docker Registry deprecated (<a href="https://github-redirect.dependabot.com/docker/login-action/issues/78 ">#78</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="49ed152c8ehttps://github-redirect.dependabot.com/docker/login-action/issues/161 ">#161</a> from crazy-max/node16-runtime</li>
<li><a href="b61a9ce7bd3a136a8631https://github-redirect.dependabot.com/docker/login-action/issues/182 ">#182</a> from docker/dependabot/npm_and_yarn/https-proxy-agent...</li>
<li><a href="b312880b69795794e0811edf6180e0https://github-redirect.dependabot.com/docker/login-action/issues/179 ">#179</a> from docker/dependabot/github_actions/codecov/codecov...</li>
<li><a href="8e66ad40897c79b598eahttps://github-redirect.dependabot.com/docker/login-action/issues/176 ">#176</a> from docker/dependabot/npm_and_yarn/minimist-1.2.6</li>
<li><a href="24a38e0d6d70e1ff84cbhttps://github-redirect.dependabot.com/docker/login-action/issues/170 ">#170</a> from crazy-max/eslint</li>
<li>Additional commits viewable in <a href="https://github.com/docker/login-action/compare/v1...v2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2574: Bump Swatinem/rust-cache from 1.3.0 to 1.4.0 r=curquiza a=dependabot[bot]
Bumps [Swatinem/rust-cache](https://github.com/Swatinem/rust-cache ) from 1.3.0 to 1.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/releases ">Swatinem/rust-cache's releases</a>.</em></p>
<blockquote>
<h2>v1.4.0</h2>
<ul>
<li>Clean both debug and release target directories.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/blob/v1/CHANGELOG.md ">Swatinem/rust-cache's changelog</a>.</em></p>
<blockquote>
<h2>1.4.0</h2>
<ul>
<li>Clean both <code>debug</code> and <code>release</code> target directories.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="cb2cf0cc7c74e8e24b6df8f67b75155b2b053862https://github-redirect.dependabot.com/Swatinem/rust-cache/issues/49 ">#49</a>)</li>
<li><a href="3bb3a9a087d127014599801365cd81https://github-redirect.dependabot.com/Swatinem/rust-cache/issues/34 ">#34</a>)</li>
<li><a href="c5ed9ba6b7536c94f32chttps://github-redirect.dependabot.com/Swatinem/rust-cache/issues/22 ">#22</a>)</li>
<li>See full diff in <a href="https://github.com/Swatinem/rust-cache/compare/v1.3.0...v1.4.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2575: Bump docker/build-push-action from 2 to 3 r=curquiza a=dependabot[bot]
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases ">docker/build-push-action's releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<ul>
<li>Node 16 as default runtime by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/564 ">#564</a>)
<ul>
<li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0 ">Actions Runner</a> version of v2.285.0, which is by default available in GHES 3.4 or later.</li>
</ul>
</li>
<li>Standalone mode support by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/601 ">#601</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/609 ">#609</a>)</li>
<li>chore: update dev dependencies and workflow by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/571 ">#571</a>)</li>
<li>Bump <code>`@actions/exec</code>` from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/573 ">#573</a>)</li>
<li>Bump <code>`@actions/github</code>` from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/582 ">#582</a>)</li>
<li>Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/584 ">#584</a>)</li>
<li>Bump semver from 7.3.5 to 7.3.7 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/595 ">#595</a>)</li>
<li>Bump csv-parse from 4.16.3 to 5.0.4 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/533 ">#533</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v2.10.0...v3.0.0 ">https://github.com/docker/build-push-action/compare/v2.10.0...v3.0.0 </a></p>
<h2>v2.10.0</h2>
<ul>
<li>Add <code>imageid</code> output and use metadata to set <code>digest</code> output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/569 ">#569</a>)</li>
<li>Add <code>build-contexts</code> input (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/563 ">#563</a>)</li>
<li>Enhance outputs display (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/559 ">#559</a>)</li>
</ul>
<h2>v2.9.0</h2>
<ul>
<li><code>add-hosts</code> input (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/553 ">#553</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/555 ">#555</a>)</li>
<li>Fix git context subdir example and improve README (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/552 ">#552</a>)</li>
<li>Add e2e tests for ACR (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/548 ">#548</a>)</li>
<li>Add description on <code>github-token</code> option to README (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/544 ">#544</a>)</li>
<li>Bump node-fetch from 2.6.1 to 2.6.7 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/549 ">#549</a>)</li>
</ul>
<h2>v2.8.0</h2>
<ul>
<li>Allow specifying subdirectory with default git context (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/531 ">#531</a>)</li>
<li>Add <code>cgroup-parent</code>, <code>shm-size</code>, <code>ulimit</code> inputs (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/501 ">#501</a>)</li>
<li>Don't set outputs if empty or nil (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/470 ">#470</a>)</li>
<li>docs: example to sanitize tags with metadata-action (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/476 ">#476</a>)</li>
<li>docs: wrong syntax to sanitize repo slug (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/475 ">#475</a>)</li>
<li>docs: test before pushing your image (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/455 ">#455</a>)</li>
<li>readme: remove v1 section (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/500 ">#500</a>)</li>
<li>ci: virtual env file system info (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/510 ">#510</a>)</li>
<li>dev: update workflow (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/499 ">#499</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.5.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/160 ">#160</a>)</li>
<li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/469 ">#469</a>)</li>
<li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/465 ">#465</a>)</li>
<li>Bump csv-parse from 4.16.0 to 4.16.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/451 ">#451</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/459 ">#459</a>)</li>
</ul>
<h2>v2.7.0</h2>
<ul>
<li>Add <code>metadata</code> output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/412 ">#412</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.4.0 to 1.5.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/439 ">#439</a>)</li>
<li>Add note to sanitize tags (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/426 ">#426</a>)</li>
<li>Cache backend API docs (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/406 ">#406</a>)</li>
<li>Git context now supports subdir (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/407 ">#407</a>)</li>
<li>Bump codecov/codecov-action from 1 to 2 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/415 ">#415</a>)</li>
</ul>
<h2>v2.6.1</h2>
<ul>
<li>Small typo and ensure trimmed output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/400 ">#400</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e551b19e49https://github-redirect.dependabot.com/docker/build-push-action/issues/564 ">#564</a> from crazy-max/node-16</li>
<li><a href="3554377aa3https://github-redirect.dependabot.com/docker/build-push-action/issues/609 ">#609</a> from crazy-max/ci-fix-test</li>
<li><a href="a62bc1b22bc2085839e1https://github-redirect.dependabot.com/docker/build-push-action/issues/601 ">#601</a> from crazy-max/standalone-mode</li>
<li><a href="fcd91249e5https://github-redirect.dependabot.com/docker/build-push-action/issues/607 ">#607</a> from docker/dependabot/github_actions/docker/metadata...</li>
<li><a href="0ebe720aed38b45804b5ba317382dchttps://github-redirect.dependabot.com/docker/build-push-action/issues/533 ">#533</a> from docker/dependabot/npm_and_yarn/csv-parse-5.0.4</li>
<li><a href="43721d23465ea21bf2bahttps://github.com/docker/build-push-action/compare/v2...v3 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: Tamo <tamo@meilisearch.com >
Co-authored-by: Ryan Russell <git@ryanrussell.org >
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-04 12:13:46 +00:00
Kerollmops
aff8cd1774
Make clippy happy
2022-07-04 13:36:56 +02:00
Ryan Russell
28609c4176
chore(auth test): Correct compute_authorized_search macro
...
Signed-off-by: Ryan Russell <git@ryanrussell.org >
2022-06-28 18:09:26 -05:00
Ryan Russell
a626cf4c99
chore: test comment readability improvements
...
Signed-off-by: Ryan Russell <git@ryanrussell.org >
2022-06-28 18:09:25 -05:00
Ryan Russell
9b660e1058
chore(routes): correct typo
...
Signed-off-by: Ryan Russell <git@ryanrussell.org >
2022-06-28 18:09:22 -05:00
bors[bot]
4862993482
Merge #2525
...
2525: Auth: Provide all document related permissions for action document.* r=Kerollmops a=janithpet
Added a `Action::DocumentsAll` identifier as [suggested](https://github.com/meilisearch/meilisearch/issues/2080#issuecomment-1022952486 ), along with the other necessary changes in `action.rs`.
Inside `store.rs`, added an extra condition in `HeedAuthStore::put_api_key` to append all document related permissions if `key.actions.contains(&DocumentsAll)`.
Updated the tests as [suggested](https://github.com/meilisearch/meilisearch/issues/2080#issuecomment-1022952486 ).
I am quite new to Rust, so please let me know if I had made any mistakes; have I written the code in the most idiomatic/efficient way? I am aware that the way I append the document permissions could create duplicates in the `actions` vector, but I am not sure how fix that in a simple way (other than using other dependencies like [itertools](https://github.com/rust-itertools/itertools ), for example).
## What does this PR do?
Fixes #2080
## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue?
- [ x] Have you read the contributing guidelines?
- [ x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: janithPet <jpetangoda@gmail.com >
2022-06-28 14:02:06 +00:00
Loïc Lecrenier
f8aa21bc16
Fix content of dump/assets for testing
...
Some contained settings with the criterion desc(fame), which is invalid
for a v3 or higher dump.
The change took place in the updates.json file inside the decompressed
.dump files. Instances of desc(field) or asc(field) were changed to
field:desc and field:asc
2022-06-22 14:51:52 +02:00
janithPet
4016161035
Provide all document related permissions for action document.*
2022-06-15 16:11:39 +01:00
bors[bot]
053071d866
Merge #2502
...
2502: test dump v5 r=ManyTheFish a=MarinPostma
this PR adds a test for dump v5
Co-authored-by: ad hoc <postma.marin@protonmail.com >
2022-06-13 10:11:22 +00:00
ad hoc
97daea5a66
ignore dump test on windows
2022-06-13 09:16:36 +01:00
Ryan Russell
8990b12609
docs: Readability fixes in src/analytics/.rs files
...
Signed-off-by: Ryan Russell <git@ryanrussell.org >
2022-06-11 10:21:05 -05:00
ad hoc
1425d62a31
test dump v5
2022-06-09 18:35:17 +02:00
pierre-l
b8745420da
Use the IndexUid and StarOr in meilisearch_auth::Key
...
Move `meilisearch_http::routes::StarOr` to `meilisearch_types::star_or`
Fixes #2158
2022-06-09 16:14:15 +02:00
pierre-l
36cb09eb25
Add a new meilisearch_types crate
...
Move `meilisearch_error` to `meilisearch_types::error`
Move `meilisearch_lib::index_resolver::IndexUid` to `meilisearch_types::index_uid`
Add a new `InvalidIndexUid` error in `meilisearch_types::index_uid`
2022-06-09 16:14:13 +02:00
bors[bot]
b9b32d65a8
Merge #2494
...
2494: Introduce the new faceting and pagination settings r=ManyTheFish a=Kerollmops
This PR introduces two new settings following the newly created spec https://github.com/meilisearch/specifications/pull/157 :
- The `faceting.max_values_per_facet` one describes the maximum number of values (each with a count) associated with a value in a facet distribution query.
- The `pagination.limited_to` one describes the maximum number of documents that a search query can ever return.
Co-authored-by: Kerollmops <clement@meilisearch.com >
2022-06-09 12:09:21 +00:00
bors[bot]
2b2e571c76
Merge #2460
...
2460: Create custom error types for `TaskType`, `TaskStatus`, and `IndexUid` r=Kerollmops a=walterbm
# Pull Request
## What does this PR do?
Fixes #2443 by making the following changes:
- Add custom `TaskTypeError` for `TaskType::from_str`
- Add custom `TaskStatusError` for `TaskStatus::from_str`
- Add custom `IndexUidFormatError` for `IndexUid::from_str`
- Implement `From<IndexUidFormatError> for IndexResolverError` to convert between errors
- Replace all usages of `IndexUid::new` with `IndexUid::from_str`
- **NOTE** I am relatively new to Rust and I struggled a lot with this final part. This PR ended up with a messy error conversion which does not seem ideal. Please let me know if you have any suggestions for how to make this better and I'll be happy to make any updates!
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: walter <walter.beller.morales@gmail.com >
2022-06-09 09:10:28 +00:00
Kerollmops
6f0d3472b1
Change the test for the new pagination.limited_to setting
2022-06-09 10:56:43 +02:00
Kerollmops
5cd13cc303
Add a test to validate the faceting.max_values_per_facet setting
2022-06-09 10:56:42 +02:00
Kerollmops
1e3dcbea3f
Plug the pagination.limited_to setting
2022-06-09 10:56:42 +02:00
Kerollmops
b96399d24b
Plug the faceting.max_values_per_facet setting
2022-06-09 10:56:42 +02:00
Kerollmops
5450b5ced3
Add the faceting.max_values_per_facet setting
2022-06-09 10:54:32 +02:00
walter
3e5d6be86b
Rename TaskType::from_str parameter to 'type_'
2022-06-08 19:57:45 -04:00
Clémentine Urquizar
fc4990b968
Update version for next release (v0.28.0)
2022-06-08 17:59:18 +02:00
bors[bot]
6171f17f1d
Merge #2468
...
2468: Update milli 0.29 r=Kerollmops a=ManyTheFish
- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test
fixes #2375
fixes #2144
fixes #2417
fixes #2407
Co-authored-by: ManyTheFish <many@meilisearch.com >
2022-06-08 14:29:20 +00:00
ManyTheFish
55169ff914
Fix test get_document_s_nested_attributes_to_retrieve
2022-06-08 15:56:06 +02:00
ManyTheFish
0a16f71563
Increase wait_task wainting time
2022-06-08 15:56:03 +02:00
ManyTheFish
17f30c2b2d
Fix(auth): Authorization test were not testing keys unrestricted on index
2022-06-08 14:52:32 +02:00
ManyTheFish
09938c9b6f
Patch ranking rules error test
2022-06-08 14:38:09 +02:00
bors[bot]
09ec8e9fca
Merge #2471
...
2471: Remove the connection keep-alive timeout r=MarinPostma a=Thearas
# Pull Request
## What does this PR do?
Fixes <https://github.com/meilisearch/meilisearch-go/issues/221 >.
Meilisearch has a default connection keep-alive timeout for 5s, which means it will close the connections with idle time >= 5s.
This PR set actix-web keep-alive config to `KeepAlive::Os`, let the client and system to decide when to close the connection.
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Co-authored-by: Thearas <thearas850@gmail.com >
2022-06-08 06:59:25 +00:00
ManyTheFish
6ffa222218
feat(auth): Paginate API keys listing
...
- [x] Update tests
- [x] Use Pagination helpers to paginate API keys
fixes #2442
2022-06-07 17:37:48 +02:00
bors[bot]
79e67df73d
Merge #2474
...
2474: feat(auth): remove `dumps.get` action from keys r=ManyTheFish a=ManyTheFish
- [x] Update tests
- [x] Remove `dumps.get` action
related to: #2430
Co-authored-by: ManyTheFish <many@meilisearch.com >
2022-06-07 15:03:41 +00:00
ManyTheFish
a7bff35e49
fix(test): Reduce default index size in tests
2022-06-07 15:16:34 +02:00
ManyTheFish
3b01ed4fe8
feat(auth): remove dumps.get action from keys
2022-06-07 10:49:28 +02:00
Thearas
9b9cbc815b
fmt
2022-06-07 03:50:39 +08:00
Thearas
fd11903920
remove the connection timeout
2022-06-07 03:38:23 +08:00
Kerollmops
e5b760c59a
Fix the segment analytics tests
2022-06-06 10:44:46 +02:00
Kerollmops
277a0a7967
Bump serde-cs to simplify our usage of the star_or function
2022-06-06 10:17:33 +02:00
Kerollmops
64b5b2e1f8
Use serde-cs::CS with StarOr to reduce the logic duplication
2022-06-06 10:06:00 +02:00
Kerollmops
10d3b367dc
Simplify the const default values
2022-06-06 10:06:00 +02:00
walter
0e7e16ae72
Add custom TaskStatusError for TaskStatus
2022-06-05 00:51:08 -04:00
walter
80c156df3f
Add custom TaskTypeError for TaskType
2022-06-05 00:51:08 -04:00
bors[bot]
b83455f345
Merge #2454
...
2454: Unify the pagination of the index and documents route behind a common type r=curquiza a=irevoire
`@MarinPostma` wdyt of keeping the `auto_paginate_sized` until we implement the pagination on every route that needs it just to see if it could be useful to something else
Co-authored-by: Tamo <tamo@meilisearch.com >
2022-06-02 15:01:43 +00:00
bors[bot]
953a209f02
Merge #2447
...
2447: move index uid in task content r=Kerollmops a=MarinPostma
this pr moves the index_uid from the `Task` to the `TaskContent`. This is because the task can now have content that do not target a particular index.
Co-authored-by: ad hoc <postma.marin@protonmail.com >
2022-06-02 13:54:09 +00:00
ad hoc
0c5352fc22
move index_uid from task to task_content
2022-06-02 15:30:35 +02:00
bors[bot]
8ac8fcb0c9
Merge #2433
...
2433: Fix the documents route r=Kerollmops a=irevoire
fix #2428
Co-authored-by: Irevoire <tamo@meilisearch.com >
2022-06-02 13:25:34 +00:00
Irevoire
4667c9fe1a
fix(http): Fix the query parameter in the Documents route
2022-06-02 14:10:44 +02:00
Tamo
12b5eabd5d
chore(http): unify the pagination of the index and documents route behind a common type
2022-06-02 14:06:56 +02:00
bors[bot]
cf2d8de48a
Merge #2452
...
2452: Change http verbs r=ManyTheFish a=Kerollmops
This PR fixes #2419 by updating the HTTP verbs used to update the settings and every single setting parameter.
- [x] `PATCH /indexes/{indexUid}` instead of `PUT`
- [x] `PATCH /indexes/{indexUid}/settings` instead of `POST`
- [x] `PATCH /indexes/{indexUid}/settings/typo-tolerance` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/displayed-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/distinct-attribute` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/filterable-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/ranking-rules` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/searchable-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/sortable-attributes` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/stop-words` instead of `POST`
- [x] `PUT /indexes/{indexUid}/settings/synonyms` instead of `POST`
Co-authored-by: Kerollmops <clement@meilisearch.com >
2022-06-02 11:46:17 +00:00
Kerollmops
419922e475
Make clippy happy
2022-06-02 13:38:23 +02:00
bors[bot]
c9cd1738a5
Merge #2445
...
2445: Seek-based tasks list r=Kerollmops a=Kerollmops
This PR implements the seek-based pagination for the tasks list following [the spec](https://github.com/meilisearch/specifications/pull/115 ).
Co-authored-by: Kerollmops <clement@meilisearch.com >
2022-06-02 10:25:54 +00:00
