Irevoire 
							
						 
					 
					
						
						
							
						
						a84f3a8b31 
					 
					
						
						
							
							Apply suggestions from code review  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-09-09 15:09:35 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tamo 
							
						 
					 
					
						
						
							
						
						b15c77ebc4 
					 
					
						
						
							
							return an error in case a user try to sort with :desc  
						
						 
						
						
						
						
					 
					
						2021-09-08 18:24:09 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tamo 
							
						 
					 
					
						
						
							
						
						4f69b190bc 
					 
					
						
						
							
							remove the distance from the search, the computation of the distance will be made on meilisearch side  
						
						 
						
						
						
						
					 
					
						2021-09-08 18:24:09 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tamo 
							
						 
					 
					
						
						
							
						
						b1bf7d4f40 
					 
					
						
						
							
							reformat  
						
						 
						
						
						
						
					 
					
						2021-09-08 18:24:09 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tamo 
							
						 
					 
					
						
						
							
						
						aca707413c 
					 
					
						
						
							
							remove the memory leak  
						
						 
						
						
						
						
					 
					
						2021-09-08 18:24:09 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tamo 
							
						 
					 
					
						
						
							
						
						a8a1f5bd55 
					 
					
						
						
							
							move the geosearch criteria out of asc_desc.rs  
						
						 
						
						
						
						
					 
					
						2021-09-08 18:24:09 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tamo 
							
						 
					 
					
						
						
							
						
						13c78e5aa2 
					 
					
						
						
							
							Implement the _geoPoint in the sortable  
						
						 
						
						
						
						
					 
					
						2021-09-08 18:24:09 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						5c962c03dd 
					 
					
						
						
							
							Fix and optimize word_prefix_pair_proximity_docids database  
						
						 
						
						
						
						
					 
					
						2021-09-01 16:48:40 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						1d314328f0 
					 
					
						
						
							
							Plug new indexer  
						
						 
						
						
						
						
					 
					
						2021-09-01 16:48:36 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Clément Renault 
							
						 
					 
					
						
						
							
						
						89d0758713 
					 
					
						
						
							
							Revert "Revert "Sort at query time""  
						
						 
						
						
						
						
					 
					
						2021-08-24 11:55:16 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Clémentine Urquizar 
							
						 
					 
					
						
						
							
						
						922f9fd4d5 
					 
					
						
						
							
							Revert "Sort at query time"  
						
						 
						
						
						
						
					 
					
						2021-08-20 18:09:17 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Kerollmops 
							
						 
					 
					
						
						
							
						
						407f53872a 
					 
					
						
						
							
							Add a sort_criteria method to the Search builder struct  
						
						 
						
						
						
						
					 
					
						2021-08-18 15:04:07 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Kerollmops 
							
						 
					 
					
						
						
							
						
						687cd2e205 
					 
					
						
						
							
							Introduce the new Sort criterion and AscDesc enum  
						
						 
						
						
						
						
					 
					
						2021-08-18 15:04:07 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Kerollmops 
							
						 
					 
					
						
						
							
						
						e9ada44509 
					 
					
						
						
							
							AscDesc criterion returns documents ordered by numbers then by strings  
						
						 
						
						
						
						
					 
					
						2021-08-17 13:21:31 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Kerollmops 
							
						 
					 
					
						
						
							
						
						7aa6cc9b04 
					 
					
						
						
							
							Do not insert fields in the map when changing the settings  
						
						 
						
						
						
						
					 
					
						2021-07-22 18:40:12 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Kerollmops 
							
						 
					 
					
						
						
							
						
						f858f64b1f 
					 
					
						
						
							
							Move the facet number iterators into their own module  
						
						 
						
						
						
						
					 
					
						2021-07-21 16:59:37 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Kerollmops 
							
						 
					 
					
						
						
							
						
						32b7bd366f 
					 
					
						
						
							
							Remove the roaring operation functions warnings  
						
						 
						
						
						
						
					 
					
						2021-06-30 14:12:56 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tamo 
							
						 
					 
					
						
						
							
						
						9716fb3b36 
					 
					
						
						
							
							format the whole project  
						
						 
						
						
						
						
					 
					
						2021-06-16 18:33:33 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Kerollmops 
							
						 
					 
					
						
						
							
						
						a7d6930905 
					 
					
						
						
							
							Replace the panicking expect by tracked Errors  
						
						 
						
						
						
						
					 
					
						2021-06-15 11:51:32 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Kerollmops 
							
						 
					 
					
						
						
							
						
						f0e804afd5 
					 
					
						
						
							
							Rename the FieldIdMapMissingEntry from_db_name field into process  
						
						 
						
						
						
						
					 
					
						2021-06-15 11:13:04 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Kerollmops 
							
						 
					 
					
						
						
							
						
						312c2d1d8e 
					 
					
						
						
							
							Use the Error enum everywhere in the project  
						
						 
						
						
						
						
					 
					
						2021-06-14 16:58:38 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						36715f571c 
					 
					
						
						
							
							Update milli/src/search/criteria/proximity.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-06-10 11:30:33 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						e923a3ed6a 
					 
					
						
						
							
							Replace Consecutive by Phrase in query tree  
						
						 
						
						... 
						
						
						
						Replace Consecutive by Phrase in query tree in order to remove theorical bugs,
due of the Consecutive enum type. 
						
						
					 
					
						2021-06-10 11:16:16 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						26a9974667 
					 
					
						
						
							
							Make asc/desc criterion return resting documents  
						
						 
						
						... 
						
						
						
						Fix #161.2 
						
						
					 
					
						2021-06-02 17:41:48 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						e857ca4d7d 
					 
					
						
						
							
							Fix PR comments  
						
						 
						
						
						
						
					 
					
						2021-06-01 18:06:46 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						c701f8bf36 
					 
					
						
						
							
							Use field id word count database in exactness criterion  
						
						 
						
						
						
						
					 
					
						2021-05-31 16:27:28 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bors[bot] 
							
						 
					 
					
						
						
							
						
						2f5e61bacb 
					 
					
						
						
							
							Merge  #184  
						
						 
						
						... 
						
						
						
						184: Transfer numbers and strings facets into the appropriate facet databases r=Kerollmops a=Kerollmops
This pull request is related to https://github.com/meilisearch/milli/issues/152  and changes the layout of the facets values, numbers and strings are now in dedicated databases and the user no more needs to define the type of the fields. No more conversion between the two types is done, numbers (floats and integers converted to f64) go to the facet float database and strings go to the strings facet database.
There is one related issue that I found regarding CSVs, the values in a CSV are always considered to be strings, [meilisearch/specifications#28 ](d916b57d74/text/0028-indexing-csv.md ) fixes this issue by allowing the user to define the fields types using `:` in the "CSV Formatting Rules" section.
All previous tests on facets have been modified to pass again and I have also done hand-driven tests with the 115m songs dataset. Everything seems to be good!
Fixes  #192 .
Co-authored-by: Clément Renault <clement@meilisearch.com >
Co-authored-by: Kerollmops <clement@meilisearch.com > 
						
						
					 
					
						2021-05-31 13:32:58 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						a5e98cf46d 
					 
					
						
						
							
							Fix plane sweep algorithm  
						
						 
						
						
						
						
					 
					
						2021-05-25 18:21:55 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Clément Renault 
							
						 
					 
					
						
						
							
						
						3a4a150ef0 
					 
					
						
						
							
							Fix the tests and remaining warnings  
						
						 
						
						
						
						
					 
					
						2021-05-25 11:31:06 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Clément Renault 
							
						 
					 
					
						
						
							
						
						02c655ff1a 
					 
					
						
						
							
							Refine the facet distribution to use both databases  
						
						 
						
						
						
						
					 
					
						2021-05-25 11:30:00 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Clément Renault 
							
						 
					 
					
						
						
							
						
						bd7b285bae 
					 
					
						
						
							
							Split the update side to use the number and the strings facet databases  
						
						 
						
						
						
						
					 
					
						2021-05-25 11:30:00 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Clément Renault 
							
						 
					 
					
						
						
							
						
						597144b0b9 
					 
					
						
						
							
							Use both number and string facet databases in the distinct system  
						
						 
						
						
						
						
					 
					
						2021-05-25 11:29:59 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						a3944a7083 
					 
					
						
						
							
							Introduce a filtered_candidates field  
						
						 
						
						
						
						
					 
					
						2021-05-11 11:37:40 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						efba662ca6 
					 
					
						
						
							
							Fix clippy warnings in cirteria  
						
						 
						
						
						
						
					 
					
						2021-05-10 10:27:18 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						e923d51b8f 
					 
					
						
						
							
							Make bucket candidates optionals  
						
						 
						
						
						
						
					 
					
						2021-05-10 10:27:04 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						44b6843de7 
					 
					
						
						
							
							Fix pull request reviews  
						
						 
						
						... 
						
						
						
						Update milli/src/fields_ids_map.rs
Update milli/src/search/criteria/exactness.rs
Update milli/src/search/criteria/mod.rs 
						
						
					 
					
						2021-05-06 14:31:03 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						c1ce4e4ca9 
					 
					
						
						
							
							Introduce mocked ExactAttribute step in exactness criterion  
						
						 
						
						
						
						
					 
					
						2021-05-06 14:28:31 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						a3f8686fbf 
					 
					
						
						
							
							Introduce exactness criterion  
						
						 
						
						
						
						
					 
					
						2021-05-06 14:28:30 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						ee09e50e7f 
					 
					
						
						
							
							Remove excluded document in criteria iterations  
						
						 
						
						... 
						
						
						
						- pass excluded document to criteria to remove them in higher levels of the bucket-sort
- merge already returned document with excluded documents to avoid duplicas
Related to #125  and #112 
Fix  #170  
						
						
					 
					
						2021-04-29 12:09:38 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						31607bf9cd 
					 
					
						
						
							
							Add a threshold on proximity when choosing between linear/set algorithm  
						
						 
						
						
						
						
					 
					
						2021-04-28 14:57:22 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								many 
							
						 
					 
					
						
						
							
						
						3b7e6afb55 
					 
					
						
						
							
							Make some refacto and add documentation  
						
						 
						
						
						
						
					 
					
						2021-04-28 13:53:27 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						0add4d735c 
					 
					
						
						
							
							Update milli/src/search/criteria/attribute.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-04-27 17:40:34 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						3794ffc952 
					 
					
						
						
							
							Update milli/src/search/criteria/attribute.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-04-27 17:39:23 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						329bd4a1bb 
					 
					
						
						
							
							Update milli/src/search/criteria/attribute.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-04-27 17:39:03 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						3b1358b62f 
					 
					
						
						
							
							Update milli/src/search/criteria/attribute.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-04-27 17:32:19 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						c862b1bc6b 
					 
					
						
						
							
							Update milli/src/search/criteria/attribute.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-04-27 17:32:10 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						e92d137676 
					 
					
						
						
							
							Update milli/src/search/criteria/attribute.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-04-27 17:31:42 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						b3d6c6a9a0 
					 
					
						
						
							
							Update milli/src/search/criteria/attribute.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-04-27 17:31:13 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						498c2b298c 
					 
					
						
						
							
							Update milli/src/search/criteria/attribute.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-04-27 17:30:02 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Many 
							
						 
					 
					
						
						
							
						
						0e4e6dfada 
					 
					
						
						
							
							Update milli/src/search/criteria/proximity.rs  
						
						 
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2021-04-27 17:29:52 +02:00