snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-09-14 16:56:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
7,549 Commits 243 Branches 505 Tags
a70ab8b0724d129d0c389fb854118dc316d7c07d
Commit Graph

7549 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
bors[bot]
96f72f009a Merge #1615 
1615: Integrate the query time sort feature r=Kerollmops a=Kerollmops

This pull request integrates the sort at query time feature that was implemented on the milli side https://github.com/meilisearch/milli/pull/320. It follows the specification file https://github.com/meilisearch/specifications/blob/develop/text/0055-sort.md.

A bunch of tests has been added to ensure that the search works correctly and that the settings are fine too!

Co-authored-by: Kerollmops <clement@meilisearch.com>
 2021-08-26 14:09:38 +00:00
Kerollmops
cf4a466b6b Make sure that the order of the filterableAttributes is constant 2021-08-26 11:06:05 +02:00
Kerollmops
087e4626ce Make sure that the order of the sortableAttributes is constant 2021-08-26 11:06:04 +02:00
Kerollmops
f230ae6fd5 Introduce the reset_sortable_fields Settings method 2021-08-25 17:44:16 +02:00
Kerollmops
64462c842b Test the search with sort time queries with POST and GET methods 2021-08-25 17:39:25 +02:00
Kerollmops
e0f73fe742 Introduce the sort search parameter 2021-08-25 17:39:25 +02:00
Kerollmops
ea4c831de0 Integrate the sortable-attributes into the settings 2021-08-25 17:39:25 +02:00
Kerollmops
51387b2c80 Introduce the new invalid sortable error codes 2021-08-25 17:29:30 +02:00
bors[bot]
2d8dd87cad Merge #1623 
1623: Use Setting enum r=Kerollmops a=shekhirin

Resolves https://github.com/meilisearch/MeiliSearch/issues/1620

Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
 2021-08-25 14:58:40 +00:00
Alexey Shekhirin
d9dd2a038b refactor(http): use Setting enum 2021-08-25 17:43:46 +03:00
bors[bot]
1227ce8091 Merge #1622 
1622: Update README to welcome the contribution again r=Kerollmops a=curquiza



Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
 2021-08-25 13:08:08 +00:00
bors[bot]
cd63c80be8 Merge #1616 
1616: Remove sentry r=Kerollmops a=irevoire

closes #1606 

Co-authored-by: Irevoire <tamo@meilisearch.com>
 2021-08-25 11:40:30 +00:00
bors[bot]
c8930781eb Merge #328 
328: Remove `beta` compilation in CI r=Kerollmops a=shekhirin

Resolves https://github.com/meilisearch/milli/issues/326

Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
 2021-08-25 08:45:18 +00:00
Alexey Shekhirin
01461af333 chore(ci): remove Rust beta from tests job 2021-08-24 22:18:13 +03:00
Clémentine Urquizar
e0a5eebe79 Update README to welcome the contribution again 2021-08-24 20:31:05 +02:00
bors[bot]
c51bb6789c Merge #325 
325: Update milli version to v0.11.0 r=curquiza a=Kerollmops

This PR also clean-up some dependencies in the Cargo.toml.

Co-authored-by: Kerollmops <clement@meilisearch.com>
 2021-08-24 16:18:49 +00:00
Kerollmops
af65485ba7 Reexport the grenad CompressionType from milli 2021-08-24 18:15:31 +02:00
Kerollmops
f2e1591826 Remove the unused tinytemplate dependency 2021-08-24 18:10:58 +02:00
Kerollmops
2f20257070 Update milli to the v0.11.0 2021-08-24 18:10:11 +02:00
bors[bot]
794c0f64a9 Merge #315 
315: Rewrite the indexing benchmarks r=Kerollmops a=irevoire

There was a panic on the benchmark and while I was trying to understand what was happening I decided to rewrite the way the benchmarks were working.

Before we were creating a database with the good setting, and then for each benchmarks we were:
1. Deleting all documents in the database
2. Indexing a batch of documents

Now for each iteration we recreate entirely a new database from scratch.
Since deleting all the documents in a database may not be the same as starting with a fresh new database I prefer this solution.

Co-authored-by: Irevoire <tamo@meilisearch.com>
 2021-08-24 15:34:50 +00:00
bors[bot]
731e0e5321 Merge #320 
320: Sort at query time r=Kerollmops a=Kerollmops

Re-introduce the Sort at the query time (https://github.com/meilisearch/milli/issues/305)

Co-authored-by: Clément Renault <renault.cle@gmail.com>
 2021-08-24 14:19:43 +00:00
bors[bot]
850069af75 Merge #1610 
1610: Fix Docker CI for `latest` tag r=irevoire a=curquiza

Fixes https://github.com/meilisearch/MeiliSearch/issues/1608

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
 2021-08-24 11:46:04 +00:00
Irevoire
672fcee8aa remove sentry 2021-08-24 12:38:31 +02:00
Clément Renault
89d0758713 Revert "Revert "Sort at query time"" 2021-08-24 11:55:16 +02:00
Clémentine Urquizar
d9b023c11f Update publish-docker-latest.yml 2021-08-23 19:27:48 +02:00
bors[bot]
6b228f56cb Merge #1607 
1607: Merge changes in `stable` into `main` r=Kerollmops a=curquiza

Containing all the fixes since v0.21.0rc0

Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: Irevoire <tamo@meilisearch.com>
Co-authored-by: many <maxime@meilisearch.com>
Co-authored-by: Kerollmops <clement@meilisearch.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: mpostma <postma.marin@protonmail.com>
Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
 2021-08-23 16:27:46 +00:00
bors[bot]
dd645e6da4 Merge #1605 
1605: Fix pacic when decoding r=curquiza a=curquiza

Update milli to fix the panic during document deletion

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
v0.21.0rc7 v0.21.0 		2021-08-23 11:06:45 +00:00
Clémentine Urquizar
149f46c184 Fix pacic when decoding 2021-08-23 12:37:51 +02:00
bors[bot]
879d5e8799 Merge #319 
319: Update version for the next release (v0.10.2) r=Kerollmops a=curquiza



Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
 2021-08-23 10:03:23 +00:00
Clémentine Urquizar
88f6c18665 Update version for the next release (v0.10.2) 2021-08-23 11:33:30 +02:00
bors[bot]
aa1ce97748 Merge #317 
317: Fix the facet string docids filterable deletion bug r=Kerollmops a=Kerollmops

Fixes a bug where the deletion of documents was returning a decoding error. But only when the settings are set with filterable attributes.

This bug was introduced in #254 in which we made the engine faster in returning the facet distribution. We changed the way we were storing the inverted index, we were no more storing only documents ids with the original values but also groups identified with integers, depending on the facet level we were using. This is similar to how facet numbers are already stored.

⚠️ As `@curquiza` already said, we must first revert #309 before merging this!

Related to https://github.com/meilisearch/MeiliSearch/issues/1601.

Co-authored-by: Clément Renault <clement@meilisearch.com>
 2021-08-23 08:57:16 +00:00
Clément Renault
c084f7f731 Fix the facet string docids filterable deletion bug 2021-08-23 10:50:39 +02:00
bors[bot]
0d1f83ba4b Merge #318 
318: Revert "Sort at query time" r=Kerollmops a=curquiza

Reverts meilisearch/milli#309

We revert this from `main` not because this leads to a bug, but because we don't want to release it now and we have to merge and release an hotfix on `main`.
Cf:
- https://github.com/meilisearch/milli/issues/316
- https://github.com/meilisearch/milli/pull/317

Once the v0.21.0 is released, we should merge again this awesome addition đź‘Ś 

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
 2021-08-21 08:25:17 +00:00
Clémentine Urquizar
922f9fd4d5 Revert "Sort at query time" 2021-08-20 18:09:17 +02:00
okyanusoz
96839c48c9 Direct users to milli for the core library in the README (#1520) 
* Update README.md

* Update README.md

* Update README.md

* Update README.md

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>

* Update README.md

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
 2021-08-19 16:24:12 +02:00
Irevoire
4b99d8cb91 rewrite the indexing benchmarks 2021-08-19 15:02:43 +02:00
bors[bot]
41fc0dcb62 Merge #309 
309: Sort at query time r=Kerollmops a=Kerollmops

This PR:
 - Makes the `Asc/Desc` criteria work with strings too, it first returns documents ordered by numbers then by strings, and finally the documents that can't be ordered. Note that it is lexicographically ordered and not ordered by character, which means that it doesn't know about wide and short characters i.e. `a`, `丹`, `▲`.
 - Changes the syntax for the `Asc/Desc` criterion by now using a colon to separate the name and the order i.e. `title:asc`, `price:desc`.
 - Add the `Sort` criterion at the third position in the ranking rules by default.
 - Add the `sort_criteria` method to the `Search` builder struct to let the users define the `Asc/Desc` sortable attributes they want to use at query time. Note that we need to check that the fields are registered in the sortable attributes before performing the search.
 - Introduce a new `InvalidSortableAttribute` user error that is raised when the sort criteria declared at query time are not part of the sortable attributes.
 - `@ManyTheFish` introduced integration tests for the dynamic Sort criterion.

Fixes #305.

Co-authored-by: Kerollmops <clement@meilisearch.com>
Co-authored-by: many <maxime@meilisearch.com>
 2021-08-18 16:55:32 +00:00
many
d1df0d20f9 Add integration test of SortBy criterion 2021-08-18 16:21:51 +02:00
bors[bot]
3e27d5e885 Merge #1596 
1596: Update milli and tokenizer version: fix panic during indexation r=curquiza a=curquiza

Fixes #1590 

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
v0.21.0rc6 		2021-08-18 13:44:30 +00:00
Kerollmops
1b7f6ea1e7 Return a new error when the sort criteria is not sortable 2021-08-18 15:04:07 +02:00
Kerollmops
71602e0f1b Add the sortable fields into the settings and in the index 2021-08-18 15:04:07 +02:00
Kerollmops
407f53872a Add a sort_criteria method to the Search builder struct 2021-08-18 15:04:07 +02:00
Kerollmops
687cd2e205 Introduce the new Sort criterion and AscDesc enum 2021-08-18 15:04:07 +02:00
Clémentine Urquizar
38fc876704 Update tokenizer and new milli version with new tags 2021-08-18 14:55:10 +02:00
bors[bot]
198c416bd8 Merge #312 
312: Update milli version to v0.10.1 r=Kerollmops a=curquiza



Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
 2021-08-18 12:08:04 +00:00
Clémentine Urquizar
6cb9c3b81f Update milli version to v0.10.1 2021-08-18 13:46:27 +02:00
bors[bot]
2a67308e29 Merge #311 
311: Update tokenizer version to v0.2.5 r=Kerollmops a=curquiza

Fixes panic when indexing data containing [control characters](https://en.wikipedia.org/wiki/Control_character) but continue accepting whitespace, obviously.

Related to https://github.com/meilisearch/MeiliSearch/issues/1590

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
 2021-08-18 11:41:52 +00:00
Clémentine Urquizar
42cf847a63 Update tokenizer version to v0.2.5 2021-08-18 13:37:41 +02:00
Clémentine Urquizar
39d5a99095 Update milli and tokenizer version 2021-08-18 12:09:34 +02:00
bors[bot]
c4275f0d27 Merge #310 
310: Modify the README file r=Kerollmops a=Kerollmops



Co-authored-by: Kerollmops <clement@meilisearch.com>
 2021-08-17 15:20:43 +00:00