42114325cd
Apply suggestions from code review
...
Co-authored-by: Louis Dureuil <louis@meilisearch.com >
2023-02-06 18:07:00 +01:00
7a38fe624f
throw an error if the top left corner is found below the bottom right corner
2023-02-06 17:50:47 +01:00
1b005f697d
update the syntax of the geoboundingbox filter to uses brackets instead of parens around lat and lng
2023-02-06 16:50:27 +01:00
fbec48f56e
Merge remote-tracking branch 'milli/main' into bring-v1-changes
2023-02-06 16:48:10 +01:00
a377a49218
Make meiliserach depend on the local milli
2023-02-06 16:44:43 +01:00
41cbaad1cb
Revert "Add git config about ownershio in Docker CI"
...
This reverts commit e269027cdd
2023-02-06 16:42:16 +01:00
a015e232ab
Merge remote-tracking branch 'origin/release-v1.0.0' into bring-v1-changes
2023-02-06 16:41:10 +01:00
3ebc99473f
Apply suggestions from code review
...
Co-authored-by: Louis Dureuil <louis@meilisearch.com >
2023-02-06 13:29:37 +01:00
fadea504ed
Merge #3451
...
3451: Pin Rust version in Clippy job r=dureuill a=curquiza
Avoid "surprising" CI failure because of clippy when rust is releasing a new version
Co-authored-by: curquiza <clementine@meilisearch.com >
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com >
2023-02-06 12:19:35 +00:00
d27007005e
comments the geoboundingbox + forbid the usage of the lexeme method which could introduce bugs
2023-02-06 11:36:49 +01:00
fcb09ccc3d
add tests on the geoBoundingBox
2023-02-02 18:19:56 +01:00
734a9ecea8
Merge #3040
...
3040: feat: create a preview environment for every PR using Uffizzi r=curquiza a=waveywaves
# Pull Request
## Related discussion (was created as an issue initially)
https://github.com/meilisearch/meilisearch/discussions/2883
## What does this PR do?
This PR adds gha workflows to create preview environments on every PR. This workflow also posts the preview url as a comment on the PR.
[This PR created against my fork of meilisearch](https://github.com/waveywaves/meilisearch/pull/2 ) demonstrates how this change behaves.
In [the demo preview](https://pr-2-deployment-7396-meilisearch.app.uffizzi.com/ ) you can run the `meilisearch` binary built from the PR and can access meilisearch running from the PR by adding `/meilisearch` to the url of the PR.
eg: I go to the demo preview at the URL https://app.uffizzi.com/github.com/waveywaves/meilisearch/pull/2 , run `meilisearch` in the terminal. I can access this running instance of `meilisearch` in the preview env fromhttps://pr-2-deployment-7396-meilisearch.app.uffizzi.com/meilisearch
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ ] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: Vibhav Bobade <vibhav.bobde@gmail.com >
2023-02-02 16:06:38 +00:00
69fcd3d05e
Add comment information about the cron job
2023-02-02 15:58:03 +01:00
1ca7778e6a
Update .github/workflows/create-issue-dependencies.yml
...
Co-authored-by: Louis Dureuil <louis@meilisearch.com >
2023-02-02 15:54:33 +01:00
a11d992923
Update issue description for the dependency updates
2023-02-02 15:33:38 +01:00
781691191a
Pin Rust version in Clippy job
2023-02-02 15:22:58 +01:00
ae8660e585
Add Token::original_span rather than making Token::span pub
2023-02-02 15:03:34 +01:00
d80ce00623
Update insta test
2023-02-02 12:34:51 +01:00
2d66fdc8e9
Apply review comments
2023-02-02 12:34:51 +01:00
b297b5deb0
cargo fmt
2023-02-02 12:34:49 +01:00
0d71c80ba6
add tests
2023-02-02 12:31:27 +01:00
b2054d3f6c
Add insta test on geo filters whitespacing
2023-02-02 12:27:58 +01:00
65a3086cf1
fix test
2023-02-02 12:27:58 +01:00
426d63b01b
Update insta test suite
2023-02-02 12:27:56 +01:00
b078477d80
Add error handling and earth lap collision with bounding box
2023-02-02 12:17:38 +01:00
5c525168a0
Add _geoBoundingBox parser
2023-02-02 11:57:21 +01:00
39b62b7158
Merge #3436
...
3436: Add more detailed contribution instructions for tests r=irevoire a=dureuill
Co-authored-by: Louis Dureuil <louis@meilisearch.com >
2023-02-02 10:19:41 +00:00
3f97f630ed
Merge #3448
...
3448: Bump docker/build-push-action from 3 to 4 r=curquiza a=dependabot[bot]
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases ">docker/build-push-action's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<blockquote>
<p><strong>Note</strong></p>
<p>Buildx v0.10 enables support for a minimal <a href="https://slsa.dev/provenance/ ">SLSA Provenance</a> attestation, which requires support for <a href="https://github.com/opencontainers/image-spec ">OCI-compliant</a> multi-platform images. This may introduce issues with registry and runtime support (e.g. <a href="https://github-redirect.dependabot.com/docker/buildx/issues/1533 ">Google Cloud Run and AWS Lambda</a>). You can optionally disable the default provenance attestation functionality using <code>provenance: false</code>.</p>
</blockquote>
<ul>
<li>Revert disable provenance by default if not set by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` in <a href="https://github-redirect.dependabot.com/docker/build-push-action/pull/784 ">docker/build-push-action#784</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v3.3.1...v4.0.0 ">https://github.com/docker/build-push-action/compare/v3.3.1...v4.0.0 </a></p>
<h2>v3.3.1</h2>
<ul>
<li>Disable provenance by default if not set by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/781 ">#781</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v3.3.0...v3.3.1 ">https://github.com/docker/build-push-action/compare/v3.3.0...v3.3.1 </a></p>
<h2>v3.3.0</h2>
<blockquote>
<p><strong>Note</strong></p>
<p>Buildx v0.10 enables support for a minimal <a href="https://slsa.dev/provenance/ ">SLSA Provenance</a> attestation, which requires support for <a href="https://github.com/opencontainers/image-spec ">OCI-compliant</a> multi-platform images. This may introduce issues with registry and runtime support (e.g. <a href="https://github-redirect.dependabot.com/docker/buildx/issues/1533 ">Google Cloud Run and AWS Lambda</a>). You can optionally disable the default provenance attestation functionality using <code>provenance: false</code>.</p>
</blockquote>
<ul>
<li>Add <code>attests</code>, <code>provenance</code> and <code>sbom</code> inputs by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/746 ">#746</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/759 ">#759</a>)</li>
<li>Log GitHub Actions runtime token access controls by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/707 ">#707</a>)</li>
<li>Examples moved to <a href="https://docs.docker.com/build/ci/github-actions/examples/ ">docs website</a> by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/718 ">#718</a>)</li>
<li>Bump minimatch from 3.0.4 to 3.1.2 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/732 ">#732</a>)</li>
<li>Bump csv-parse from 5.3.0 to 5.3.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/729 ">#729</a>)</li>
<li>Bump json5 from 2.2.0 to 2.2.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/749 ">#749</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v3.2.0...v3.3.0 ">https://github.com/docker/build-push-action/compare/v3.2.0...v3.3.0 </a></p>
<h2>v3.2.0</h2>
<ul>
<li>Remove workaround for <code>setOutput</code> by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/704 ">#704</a>)</li>
<li>Docs: fix Git context link and add more details about subdir support by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/685 ">#685</a>)</li>
<li>Docs: named context by <a href="https://github.com/baibaratsky "><code>`@baibaratsky</code></a>` and <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/665 ">#665</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.9.0 to 1.10.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/667 ">#667</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/695 ">#695</a>)</li>
<li>Bump <code>`@actions/github</code>` from 5.0.3 to 5.1.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/696 ">#696</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v3.1.1...v3.2.0 ">https://github.com/docker/build-push-action/compare/v3.1.1...v3.2.0 </a></p>
<h2>v3.1.1</h2>
<ul>
<li>Fix GitHub token not passed with Git context if subdir defined by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/663 ">#663</a>)</li>
<li>Replace deprecated <code>fs.rmdir</code> with <code>fs.rm</code> by <a href="https://github.com/bendrucker "><code>`@bendrucker</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/657 ">#657</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v3.1.0...v3.1.1 ">https://github.com/docker/build-push-action/compare/v3.1.0...v3.1.1 </a></p>
<h2>v3.1.0</h2>
<ul>
<li><code>no-cache-filters</code> input by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/653 ">#653</a>)</li>
<li>Bump <code>`@actions/github</code>` from 5.0.1 to 5.0.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/619 ">#619</a>)</li>
<li>Bump <code>`@actions/core</code>` from 1.6.0 to 1.9.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/620 ">#620</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/637 ">#637</a>)</li>
<li>Bump csv-parse from 5.0.4 to 5.3.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/623 ">#623</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/650 ">#650</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v3.0.0...v3.1.0 ">https://github.com/docker/build-push-action/compare/v3.0.0...v3.1.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3b5e8027fchttps://github-redirect.dependabot.com/docker/build-push-action/issues/784 ">#784</a> from crazy-max/enable-provenance</li>
<li><a href="02d3266a89f403dafe18https://github.com/docker/build-push-action/compare/v3...v4 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-01 18:13:15 +00:00
0bc1a18f52
Use Languages list detected during indexing at search time
2023-02-01 18:57:43 +01:00
643d99e0f9
Add expectancy test
2023-02-01 18:39:54 +01:00
a36b1dbd70
Fix the tasks with the new patterns
2023-02-01 18:21:45 +01:00
5672165e44
Bump docker/build-push-action from 3 to 4
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 3 to 4.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](https://github.com/docker/build-push-action/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-01 17:02:17 +00:00
d563ed8a39
Making it work with index uid patterns
2023-02-01 17:51:30 +01:00
36cae3b480
Merge #3399
...
3399: Rework technical information in the README r=Kerollmops a=curquiza
Following this https://github.com/meilisearch/meilisearch/pull/3346#discussion_r1073289399
Co-authored-by: curquiza <clementine@meilisearch.com >
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com >
2023-02-01 14:34:55 +00:00
064158e4e2
Update test
2023-02-01 15:34:01 +01:00
77d32d0ee8
Fix codec deserialization
2023-02-01 15:26:26 +01:00
f4569b04ad
Update Charabia version
2023-02-01 15:26:26 +01:00
5e12af88e2
Merge #3445
...
3445: Bump milli to v0.41.1 r=curquiza a=dureuill
# Pull Request
## Related issue
Fixes #3438 .
## What does this PR do?
- Bump milli to [v0.41.1](https://github.com/meilisearch/milli/releases/tag/v0.41.1 ) that includes a bugfix for #3438
Co-authored-by: Louis Dureuil <louis@meilisearch.com >
2023-02-01 11:07:46 +00:00
231067a1c4
Bump milli to v0.41.1
2023-02-01 11:53:39 +01:00
2a1a7ef00a
Integrate Uffizzi
2023-02-01 13:06:27 +05:30
758b4acea7
Merge #776
...
776: Reduce incremental indexing time of `words_prefix_position_docids` DB r=curquiza a=loiclec
Fixes partially https://github.com/meilisearch/milli/issues/605
The `words_prefix_position_docids` can easily contain millions of entries. Thus, iterating
over it can be very expensive. But we do so needlessly for every document addition tasks.
It can sometimes cause indexing performance issues when :
- a user sends many `documentAdditionOrUpdate` tasks that cannot be all batched together (for example if they are interspersed with `documentDeletion` tasks)
- the documents contain long, diverse text fields, thus increasing the number of entries in `words_prefix_position_docids`
- the index has accumulated many soft-deleted documents, further increasing the size of `words_prefix_position_docids`
- the machine running Meilisearch does not have great IO performance (e.g. slow SSD, or quota-limited by the cloud provider)
Note, before approving the PR: the only changed file should be `milli/src/update/words_prefix_position_docids.rs`.
Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com >
2023-01-31 15:52:28 +00:00
20f8184c06
Merge #3441
...
3441: Fix import of dump v2 r=dureuill a=irevoire
# Pull Request
This bug was introduced because of a mistake we did earlier: We said the last version to export dump v2 was the v0.21.0 while it was the v0.22.0.
To fix the bug I updated our whole v2 reader to use the code from meilisearch v0.22.0.
Also:
- Import the bugged dump in the tests
- Test the import of this dump in the v2 reader and current reader
## Related issue
Fixes #3435
Co-authored-by: Tamo <tamo@meilisearch.com >
2023-01-31 13:23:57 +00:00
2f8ebd0501
Merge #3439
...
3439: Add git config about ownership in Docker CI r=curquiza a=curquiza
The docker CI si failing because of git usage: https://github.com/meilisearch/meilisearch/actions/runs/4053334082/jobs/6973827940
<img width="960" alt="Capture d’écran 2023-01-31 à 12 12 44" src="https://user-images.githubusercontent.com/20380692/215745119-b866bcf2-7077-48e4-b018-7a2085b23680.png ">
> fatal: detected dubious ownership in repository at '/home/meili/actions-runner/_work/meilisearch/meilisearch'
I made some research and I found out this https://github.com/actions/runner-images/issues/6775
Co-authored-by: curquiza <clementine@meilisearch.com >
2023-01-31 12:58:59 +00:00
6be9a828fa
makes clippy happy
2023-01-31 13:03:28 +01:00
4b7b2d6a90
fix the import of dump v2 generated by meilisearch v0.22.0
2023-01-31 13:03:28 +01:00
a4e8158239
Merge #774
...
774: Update version for the next release (v0.41.1) in Cargo.toml files r=curquiza a=meili-bot
⚠️ This PR is automatically generated. Check the new version is the expected one before merging.
Co-authored-by: curquiza <curquiza@users.noreply.github.com >
2023-01-31 11:51:42 +00:00
151e52c481
Merge #3433
...
3433: Add prototype guide to CONTRIBUTING.md r=curquiza a=curquiza
Co-authored-by: curquiza <clementine@meilisearch.com >
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com >
2023-01-31 11:25:46 +00:00
e269027cdd
Add git config about ownershio in Docker CI
2023-01-31 12:04:41 +01:00
a2690ea8d4
Reduce incremental indexing time of words_prefix_position_docids DB
...
This database can easily contain millions of entries. Thus, iterating
over it can be very expensive.
For regular `documentAdditionOrUpdate` tasks, `del_prefix_fst_words`
will always be empty. Thus, we can save a significant amount of time
by adding this `if !del_prefix_fst_words.is_empty()` condition.
The code's behaviour remains completely unchanged.
2023-01-31 11:42:24 +01:00
33f61d2cd4
Merge #775
...
775: Fix clippy for Rust 1.67, allow `uninlined_format_args` r=dureuill a=dureuill
# Pull Request
milli part of https://github.com/meilisearch/meilisearch/pull/3437
Co-authored-by: Louis Dureuil <louis@meilisearch.com >
2023-01-31 10:29:24 +00:00
