d082ded7ad
Explicitly restrict log level options to those that are documented
...
Fixes https://github.com/meilisearch/meilisearch/issues/3292
2023-01-04 09:40:24 +01:00
947f08793a
Merge #3296
...
3296: Remove `--disable-auto-batching` CLI option r=gmourier a=loiclec
Fixes #3294
The `index-scheduler` code is not modified, only the CLI options have changed.
Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com >
2023-01-03 16:57:14 +00:00
17dac72464
Characters -> bytes
2023-01-03 15:31:02 +01:00
b821c72459
Remove --disable-auto-batching CLI option
2023-01-03 15:01:04 +01:00
7b2575c646
Master Key -> master key
2023-01-03 14:45:23 +01:00
6425e06cf2
Merge #3274
...
3274: Reject master keys that are less than 16 bytes and add `--generate-master-key` CLI option r=irevoire a=dureuill
# Pull Request
## Related issue
Fix #3272
Fix #3287
## What does this PR do?
### User standpoint
---
- Adds a `--generate-master-key` CLI flag to generate a fresh Master Key and exit.
<img width="1351" alt="Capture d’écran 2022-12-22 à 14 18 58" src="https://user-images.githubusercontent.com/41078892/209142778-eab52eeb-eaa8-409b-897a-c0d5728c8aaa.png ">
---
(relevant fragment of the `--help` message)
<img width="1351" alt="Capture d’écran 2022-12-22 à 14 19 40" src="https://user-images.githubusercontent.com/41078892/209142891-ebfa2ed6-f231-4f76-a3ae-b7542c7aef04.png ">
---
- When `meilisearch` is started in the `development` environment and no Master Key has been provided, then the binary prints a warning before starting.
<img width="1351" alt="Capture d’écran 2022-12-22 à 14 14 49" src="https://user-images.githubusercontent.com/41078892/209142158-54eba3b7-bf71-4f3f-8840-0600b13a1a9f.png ">
---
- When `meilisearch` is started in the `development` environment and the provided Master Key is shorter than 16 bytes, then the binary prints a warning before starting.
<img width="1351" alt="Capture d’écran 2022-12-22 à 14 15 58" src="https://user-images.githubusercontent.com/41078892/209142295-0209fe47-c03b-424f-a73f-cee9b633137a.png ">
---
- When `meilisearch` is started in the `production` environment, and no Master Key is provided, the error message is altered to generate a fresh Master Key.
<img width="1351" alt="Capture d’écran 2022-12-22 à 17 29 02" src="https://user-images.githubusercontent.com/41078892/209180540-0def5798-15db-47f0-a6ec-8cfa081dea77.png ">
---
- When `meilisearch` is started in the `production` environment, and the provided Master Key is shorter than 16 bytes, then the binary exits with an error.
<img width="1351" alt="Capture d’écran 2022-12-22 à 17 28 47" src="https://user-images.githubusercontent.com/41078892/209180567-fa54fe33-fbc4-4b9f-b281-7dfb7b33af85.png ">
---
This implements the solution B described here: https://github.com/meilisearch/product/discussions/538#discussioncomment-4391346
### Implementation standpoint
- Add a new `meilisearch-auth::generate_master_key` function that uses a Cryptographic Random Number Generator (CRNG) to fill a vector of 32 bytes before encoding these bytes as base64
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: Louis Dureuil <louis@meilisearch.com >
Co-authored-by: Tamo <tamo@meilisearch.com >
2023-01-02 16:00:40 +00:00
1692f58b83
slightly update the message associated with the cli parameter + accept an env variable
2023-01-02 16:49:35 +01:00
9ba4d0f921
update the error messages according to the spec
2023-01-02 16:43:23 +01:00
3cba476a9f
Add --generate-master-key CLI option
2022-12-26 10:36:45 +01:00
57e851d8a9
Check for key length
2022-12-26 10:36:45 +01:00
9a39c4e40d
Get date from IndexMetaData
2022-12-22 11:46:17 +01:00
df176aaf01
Insert dump_reader.date() into create_raw_index(_) argument
2022-12-21 15:16:31 +01:00
0893b175dc
Merge branch 'main' into 2983-forward-date-to-milli
2022-12-21 14:31:19 +01:00
d5978d11e1
Refactor
2022-12-21 14:28:00 +01:00
2780e365e2
test update and ndjson serde use from_slice
2022-12-21 14:31:45 +08:00
bf2a401a05
serde ndjson fix
2022-12-21 11:27:15 +08:00
869d331680
Clippy fixes after updating Rust to v1.66
2022-12-19 14:17:12 +01:00
60ebf0ea0b
Add a specific test on finite pagination placeolder search with distinct attributes
2022-12-15 17:28:20 +01:00
ce84a59873
Re-apply some changes from #3132
2022-12-14 20:02:39 +01:00
d66bb3a53f
rename the two new functions
2022-12-14 17:27:43 +01:00
6c0b8edab5
Fix typos
...
Co-authored-by: Louis Dureuil <louis@meilisearch.com >
2022-12-14 17:27:37 +01:00
fbbc6eaeca
Fix the import of dumps and snapshot.
...
Some flags were badly applied + the database wrongly deleted when they shouldn't
2022-12-14 17:27:28 +01:00
7b2f2a4f9c
Do only one convertion to u64
2022-12-13 15:31:55 +01:00
5d5615ef45
Rename the ReceivePayload error variant
2022-12-13 15:07:35 +01:00
23c1b223b3
Merge branch 'fix-3037' of github.com:jiangbo212/meilisearch into fix-3037
2022-12-13 10:41:50 +08:00
87ae0032bf
review change
2022-12-13 10:41:43 +08:00
7c24fea9f2
Merge branch 'main' into fix-3037
2022-12-13 05:16:03 +08:00
fa46dfb7bb
fmt fix
2022-12-12 22:02:56 +08:00
169682d3ec
Merge branch 'main' into fix-3037-new
2022-12-12 21:36:10 +08:00
6f1c30b247
Fix the instance-uid in the data.ms
...
We were writing the instance-uid as bytes instead of string in the data.ms and thus we were unable to parse it later.
Also it was less practical for our user to retrieve it and send it to us.
2022-12-08 18:16:43 +01:00
2262766494
chore: run fmt nightly on project
2022-12-08 08:31:15 -07:00
ad2b1467da
Renames meilisearch-http to meilisearch
2022-12-08 08:22:53 -07:00
