7666e4f34a
follow the suggestions
2021-10-14 21:37:59 +08:00
2ea2f7570c
use nightly cargo to format the code
2021-10-14 16:46:13 +08:00
e750465e15
check logic for geolocation.
2021-10-14 16:12:00 +08:00
cd359cd96e
WIP: extract the error trait bound to new trait.
2021-10-13 18:04:15 +08:00
5de5dd80a3
WIP: remove '_nom' suffix/redundant error enum/...
2021-10-13 11:06:15 +08:00
2c65781d91
format
2021-10-12 22:20:22 +08:00
d323e35001
add a test case
2021-10-12 13:30:40 +08:00
70f576d5d3
error handling
2021-10-12 13:30:40 +08:00
28f9be8d7c
support syntax
2021-10-12 13:30:40 +08:00
469d92c569
tweak error handling
2021-10-12 13:30:40 +08:00
7a90a101ee
reorganize parser logic
2021-10-12 13:30:40 +08:00
f7796edc7e
remove everything about pest
2021-10-12 13:30:40 +08:00
ac1df9d9d7
fix typo and remove pest
2021-10-12 13:30:40 +08:00
50ad750ec1
enhance error handling
2021-10-12 13:30:40 +08:00
8748df2ca4
draft without error handling
2021-10-12 13:30:40 +08:00
99889a0ed0
add obkv document serialization test
2021-10-11 15:13:17 +02:00
799f3d43c8
fix serialization to obkv format
2021-10-11 15:04:47 +02:00
b65aa7b5ac
Apply suggestions from code review
...
Co-authored-by: Clément Renault <clement@meilisearch.com >
2021-10-07 17:51:52 +02:00
11dfe38761
Update the check on the latitude and longitude
...
Latitude are not supposed to go beyound 90 degrees or below -90.
The same goes for longitude with 180 or -180.
This was badly implemented in the filters, and was not implemented for the AscDesc rules.
2021-10-07 16:10:43 +02:00
085bc6440c
Apply PR comments
2021-10-06 11:12:26 +02:00
1bd15d849b
Reduce candidates threshold
2021-10-05 18:52:14 +02:00
ea4bd29d14
Apply PR comments
2021-10-05 17:35:07 +02:00
3296bb243c
Simplify word level position DB into a word position DB
2021-10-05 12:15:02 +02:00
75d341d928
Re-implement set based algorithm for attribute criterion
2021-10-05 12:14:50 +02:00
d9eba9d145
improve and test the sort error message
2021-09-30 14:38:27 +02:00
0ee67bb7d1
improve the reserved keyword error message for the filters
2021-09-30 14:38:27 +02:00
22551d0941
Merge #379
...
379: Revert "Change chunk size to 4MiB to fit more the end user usage" r=curquiza a=ManyTheFish
Reverts meilisearch/milli#370
Co-authored-by: Many <legendre.maxime.isn@gmail.com >
2021-09-29 13:20:53 +00:00
26b5dad042
Revert "Change chunk size to 4MiB to fit more the end user usage"
2021-09-29 15:08:39 +02:00
2e49230ca2
Update milli/src/search/criteria/attribute.rs
...
Co-authored-by: Clément Renault <clement@meilisearch.com >
2021-09-29 14:49:45 +02:00
7ad0214089
Update milli/src/search/criteria/attribute.rs
...
Co-authored-by: Clément Renault <clement@meilisearch.com >
2021-09-29 14:49:41 +02:00
1df5b8712b
Hotfix meilisearch#1707
2021-09-29 14:41:56 +02:00
f65153ad64
stop casting integer docids to string
2021-09-28 18:35:54 +02:00
785c1372f2
Change "settings" to "setting"
...
Co-authored-by: Clément Renault <renault.cle@gmail.com >
2021-09-28 20:11:32 +05:30
3580b2d803
Fixes #365
2021-09-28 19:30:23 +05:30
3a12f5887e
Merge #373
...
373: Improve error message for bad sort syntax with geosearch r=Kerollmops a=irevoire
`@Kerollmops` This should be the last PR for the geosearch and error handling, sorry for doing it in so many steps 😬
Co-authored-by: Tamo <tamo@meilisearch.com >
2021-09-28 12:39:32 +00:00
a80dcfd4a3
improve error message for bad sort syntax with geosearch
2021-09-28 14:32:24 +02:00
b2a332599e
Merge #372
...
372: Fix Meilisearch 1714 r=Kerollmops a=ManyTheFish
The bug comes from the typo tolerance, to know how many typos are accepted we were counting bytes instead of characters in a word.
On Chinese Script characters, we were allowing 2 typos on 3 characters words.
We are now counting the number of char instead of counting bytes to assign the typo tolerance.
Related to [Meilisearch#1714](https://github.com/meilisearch/MeiliSearch/issues/1714 )
Co-authored-by: many <maxime@meilisearch.com >
2021-09-28 11:59:45 +00:00
8046ae4bd5
Count the number of char instead of counting bytes to assign the typo tolerance
2021-09-28 12:10:43 +02:00
1988416295
Add failing test related to Meilisearch#1714
2021-09-28 12:05:11 +02:00
c7cb816ae1
simplify the error handling of the sort syntax for meilisearch
2021-09-27 19:07:22 +02:00
b188063869
Change chunk size to 4MiB to fit more the end user usage
2021-09-27 14:26:21 +02:00
551df0cb77
Add test checking the bug reported in meilisearch issue 1716
2021-09-23 15:55:39 +02:00
218f0a6661
Apply suggestions from code review
...
Co-authored-by: Clément Renault <clement@meilisearch.com >
2021-09-22 17:00:27 +02:00
47ee93b0bd
return an error when _geoPoint is used but _geo is not sortable
2021-09-22 16:37:41 +02:00
1e5e3d57e2
auto convert AscDescError into CriterionError
2021-09-22 16:37:41 +02:00
023446ecf3
create a smaller and easier to maintain CriterionError type
2021-09-22 16:37:41 +02:00
86e272856a
create an asc_desc error type that is never supposed to be returned to the end user
2021-09-22 16:37:41 +02:00
257e621d40
create an asc_desc module
2021-09-22 16:37:41 +02:00
113a061bee
fix the error handling on the criterion side
2021-09-22 15:09:07 +02:00
78b0bce9a1
fix the returned error when asc desc fails to be parsed
2021-09-22 11:37:05 +02:00
