549f1bcccf
Merge #4125
...
4125: Rename benchmark CI file to find it easily in the manifest list r=Kerollmops a=curquiza
Co-authored-by: curquiza <clementine@meilisearch.com >
2023-10-16 11:38:28 +00:00
689ec7c7ad
Make the experimental route /metrics activable via HTTP
2023-10-13 22:12:54 +00:00
3655d4bdca
Move the puffin file export logic into the run function
2023-10-13 13:11:30 +02:00
055ca3935b
Update index-scheduler/src/batch.rs
...
Co-authored-by: Tamo <tamo@meilisearch.com >
2023-10-13 13:11:30 +02:00
1b8871a585
Make cargo insta happy
2023-10-13 13:11:30 +02:00
bf8fac6676
Fix the tests
2023-10-13 13:11:30 +02:00
f2a9e1ebbb
Improve the debugging experience in the puffin reports
2023-10-13 13:11:30 +02:00
c45c6cf54c
Update the PROFILING.md file
2023-10-13 13:11:30 +02:00
513e61e9a3
Remove the experimental CLI flag
2023-10-13 13:11:29 +02:00
90a626bf80
Use the runtime feature to enable puffin report exporting
2023-10-13 13:11:29 +02:00
0d4acf2daa
Fix the metrics product URL
2023-10-13 13:11:29 +02:00
58db8d85ec
Add the exportPuffinReports option to the runtime features route
2023-10-13 13:11:29 +02:00
62dfd09dc6
Add more puffin logs to the deletion functions
2023-10-13 13:11:09 +02:00
656dadabea
Expose an experimental flag to write the puffin reports to disk
2023-10-13 13:11:09 +02:00
c5f7893fbb
Remove the puffin http dependency
2023-10-13 13:11:08 +02:00
8cf2ccf168
Rename benchmark CI file to find it easily in the manifest list
2023-10-12 18:41:26 +02:00
0913373a5e
Merge #4122
...
4122: Bring back changes from `release-v1.4.1` into `main` r=Kerollmops a=curquiza
Co-authored-by: curquiza <curquiza@users.noreply.github.com >
Co-authored-by: meili-bors[bot] <89034592+meili-bors[bot]@users.noreply.github.com>
Co-authored-by: Tamo <tamo@meilisearch.com >
Co-authored-by: Vivek Kumar <vivek.26@outlook.com >
Co-authored-by: Clément Renault <clement@meilisearch.com >
2023-10-12 15:57:47 +00:00
1a7f1282af
Fix test to use new common Value type
2023-10-12 17:37:04 +02:00
bc747aac3a
Cut the first 8 characters
2023-10-12 15:04:37 +02:00
be92376ab3
Fix originating commit branch
2023-10-12 13:51:41 +02:00
cf7e355735
Fix originating commit command
2023-10-12 13:12:53 +02:00
5f09d89ad1
Fetch the whole git history when cloning
2023-10-12 12:25:26 +02:00
6ecb26a3f8
Add more info on the commenting CI command
2023-10-12 11:54:56 +02:00
76c6f554d6
Merge #4101
...
4101: Bump webpki from 0.22.1 to 0.22.2 r=curquiza a=dependabot[bot]
Bumps [webpki](https://github.com/briansmith/webpki ) from 0.22.1 to 0.22.2.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/briansmith/webpki/commits ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/meilisearch/meilisearch/network/alerts ).
</details>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-12 08:46:04 +00:00
f343ef5f2f
Merge #4108
...
4108: Fix bug where search with distinct attribute and no ranking, returns offset+limit hits r=curquiza a=vivek-26
# Pull Request
## Related issue
Fixes #4078
## What does this PR do?
This PR -
- Fixes bug where search with distinct attribute and no ranking, returns offset+limit hits.
- Adds unit and integration tests.
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: Vivek Kumar <vivek.26@outlook.com >
2023-10-12 07:51:29 +00:00
96982a768a
Triggers for every type of issue_comment
2023-10-11 23:18:29 +02:00
fca78fbc46
Merge #4082
...
4082: Update sprint_issue.md r=curquiza a=curquiza
Following internal recent discussions
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com >
2023-10-11 15:12:38 +00:00
67a678cfb6
Merge #4089
...
4089: Use a bufreader and bufwriter everytime there is a grenad<file> r=curquiza a=irevoire
# Pull Request
Wrap all the files we give to a grenad in a `BufReader` or `BufWriter`.
The dump import I tried in the issue went from 2h to 10 minutes on my machine.
I also ran a bunch of benchmarks on my machine, and we're faster by a few seconds everywhere but nothing huge.
-----
The one thing I’m afraid about is if we used to get the inner file in a grenad and then do a read right after without a seek at the beginning of the file or a reopen.
Since we now use a bufreader our read would return the bytes one buffer later and probably completely corrupt what we were supposed to read.
From what I see, it looks like it works, but I may have missed something, I don't know much about this part of the codebase.
This issue should not arise on the bufwriter, though, because if we're not able to write the content of the buffer I ensured that the `into_inner` of the bufwriter should return an internal error.
## Related issue
Fixes #4087
Co-authored-by: Tamo <tamo@meilisearch.com >
2023-10-11 14:27:00 +00:00
d1331d8abf
add integration test for distinct search with no ranking
2023-10-11 19:12:56 +05:30
19ba129165
add unit test for distinct search with no ranking
2023-10-11 19:02:27 +05:30
d4da06ff47
fix bug where distinct search with no ranking returns offset+limit hits
2023-10-11 19:02:16 +05:30
3e0471edae
Only trigger CI on created or edited comments
2023-10-11 15:15:15 +02:00
432df03c4c
Use the correct base filename in the comment bench CI
2023-10-11 14:57:03 +02:00
11958016dd
Force a small if to evoid triggering the CI every time
2023-10-11 14:27:51 +02:00
63c250a04d
Do not use the GITHUB_REF variable
2023-10-11 13:05:54 +02:00
06d8cd5b72
Make sure that we checkout on the right branch
2023-10-11 12:02:44 +02:00
c0f2724c2d
get rids of the new introduced error code in favor of an io::Error
2023-10-10 15:12:23 +02:00
d772073dfa
use a bufreader everytime there is a grenad<file>
2023-10-10 15:00:30 +02:00
8fe8ddea79
Merge #4112
...
4112: Update version for the next release (v1.4.1) in Cargo.toml r=curquiza a=meili-bot
⚠️ This PR is automatically generated. Check the new version is the expected one and Cargo.lock has been updated before merging.
Co-authored-by: curquiza <curquiza@users.noreply.github.com >
2023-10-10 09:05:10 +00:00
8a95bf28e5
Update version for the next release (v1.4.1) in Cargo.toml
2023-10-10 09:01:45 +00:00
c0fd3dffb8
Setup a Github Token env var
2023-10-09 18:04:49 +02:00
c42fd5375f
Fix the git commands again
2023-10-09 17:36:19 +02:00
b418c3a756
Use the PAT token instead
2023-10-09 16:52:04 +02:00
1cde455758
Fix workflow CI
2023-10-09 16:30:46 +02:00
ca19bae72f
Prefer using a action to manage commands
2023-10-09 14:56:41 +02:00
705878ff59
Merge #4102
...
4102: Introduce the first bot that shows benchmarks results r=curquiza a=Kerollmops
TBD
Co-authored-by: Kerollmops <clement@meilisearch.com >
Co-authored-by: Clément Renault <clement@meilisearch.com >
2023-10-05 10:11:06 +00:00
92c280d1c8
Update .github/workflows/trigger-benchmarks-on-message.yml
...
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com >
2023-10-05 12:09:52 +02:00
181e7a1e53
Introduce the first bot that triggers benchmarks
2023-10-05 12:05:38 +02:00
2e5abb4d2c
Merge #4098
...
4098: Bump docker/metadata-action from 4 to 5 r=curquiza a=dependabot[bot]
Bumps [docker/metadata-action](https://github.com/docker/metadata-action ) from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/metadata-action/releases ">docker/metadata-action's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<ul>
<li>Node 20 as default runtime (requires <a href="https://github.com/actions/runner/releases/tag/v2.308.0 ">Actions Runner v2.308.0</a> or later) by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` in <a href="https://redirect.github.com/docker/metadata-action/pull/328 ">docker/metadata-action#328</a></li>
<li>Bump <code>`@actions/core</code>` from 1.10.0 to 1.10.1 in <a href="https://redirect.github.com/docker/metadata-action/pull/333 ">docker/metadata-action#333</a></li>
<li>Bump csv-parse from 5.4.0 to 5.5.0 in <a href="https://redirect.github.com/docker/metadata-action/pull/320 ">docker/metadata-action#320</a></li>
<li>Bump semver from 7.5.1 to 7.5.2 in <a href="https://redirect.github.com/docker/metadata-action/pull/304 ">docker/metadata-action#304</a></li>
<li>Bump handlebars from 4.7.7 to 4.7.8 in <a href="https://redirect.github.com/docker/metadata-action/pull/315 ">docker/metadata-action#315</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/metadata-action/compare/v4.6.0...v5.0.0 ">https://github.com/docker/metadata-action/compare/v4.6.0...v5.0.0 </a></p>
<h2>v4.6.0</h2>
<ul>
<li>Dedup and sort labels by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` in <a href="https://redirect.github.com/docker/metadata-action/pull/301 ">docker/metadata-action#301</a></li>
<li>Bump <code>`@docker/actions-toolkit</code>` from 0.3.0 to 0.5.0 in <a href="https://redirect.github.com/docker/metadata-action/pull/302 ">docker/metadata-action#302</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/metadata-action/compare/v4.5.0...v4.6.0 ">https://github.com/docker/metadata-action/compare/v4.5.0...v4.6.0 </a></p>
<h2>v4.5.0</h2>
<ul>
<li>Bump <code>`@docker/actions-toolkit</code>` from 0.1.0 to 0.3.0 in <a href="https://redirect.github.com/docker/metadata-action/pull/296 ">docker/metadata-action#296</a></li>
<li>Bump csv-parse from 5.3.8 to 5.4.0 in <a href="https://redirect.github.com/docker/metadata-action/pull/294 ">docker/metadata-action#294</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/metadata-action/compare/v4.4.0...v4.5.0 ">https://github.com/docker/metadata-action/compare/v4.4.0...v4.5.0 </a></p>
<h2>v4.4.0</h2>
<ul>
<li>Add <code>context</code> input to define the metadata provider by <a href="https://github.com/neilime "><code>`@neilime</code></a>` in <a href="https://redirect.github.com/docker/metadata-action/pull/248 ">docker/metadata-action#248</a></li>
<li>Switch to actions-toolkit implementation by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` in <a href="https://redirect.github.com/docker/metadata-action/pull/266 ">docker/metadata-action#266</a> <a href="https://redirect.github.com/docker/metadata-action/pull/273 ">docker/metadata-action#273</a> <a href="https://redirect.github.com/docker/metadata-action/pull/284 ">docker/metadata-action#284</a></li>
<li>Bump csv-parse from 5.3.3 to 5.3.8 in <a href="https://redirect.github.com/docker/metadata-action/pull/271 ">docker/metadata-action#271</a> <a href="https://redirect.github.com/docker/metadata-action/pull/286 ">docker/metadata-action#286</a></li>
<li>Bump moment-timezone from 0.5.40 to 0.5.43 in <a href="https://redirect.github.com/docker/metadata-action/pull/268 ">docker/metadata-action#268</a> <a href="https://redirect.github.com/docker/metadata-action/pull/278 ">docker/metadata-action#278</a> <a href="https://redirect.github.com/docker/metadata-action/pull/281 ">docker/metadata-action#281</a></li>
<li>Bump semver from 7.4.0 to 7.5.0 in <a href="https://redirect.github.com/docker/metadata-action/pull/285 ">docker/metadata-action#285</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/metadata-action/compare/v4.3.0...v4.4.0 ">https://github.com/docker/metadata-action/compare/v4.3.0...v4.4.0 </a></p>
<h2>v4.3.0</h2>
<ul>
<li>Provide outputs as env vars by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://redirect.github.com/docker/metadata-action/issues/257 ">#257</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/metadata-action/compare/v4.2.0...v4.3.0 ">https://github.com/docker/metadata-action/compare/v4.2.0...v4.3.0 </a></p>
<h2>v4.2.0</h2>
<ul>
<li>Add <code>tz</code> attribute to handlebar date function by <a href="https://github.com/chroju "><code>`@chroju</code></a>` (<a href="https://redirect.github.com/docker/metadata-action/issues/251 ">#251</a>)</li>
<li>Bump minimatch from 3.0.4 to 3.1.2 (<a href="https://redirect.github.com/docker/metadata-action/issues/242 ">#242</a>)</li>
<li>Bump csv-parse from 5.3.1 to 5.3.3 (<a href="https://redirect.github.com/docker/metadata-action/issues/245 ">#245</a>)</li>
<li>Bump json5 from 2.2.0 to 2.2.3 (<a href="https://redirect.github.com/docker/metadata-action/issues/252 ">#252</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/metadata-action/compare/v4.1.1...v4.2.0 ">https://github.com/docker/metadata-action/compare/v4.1.1...v4.2.0 </a></p>
<h2>v4.1.1</h2>
<ul>
<li>Revert changes to set associated head sha on pull request event by <a href="https://github.com/crazy-max "><code>`@crazy-max</code></a>` (<a href="https://redirect.github.com/docker/metadata-action/issues/239 ">#239</a>)
<ul>
<li>User can still set associated head sha on PR by setting the env var <code>DOCKER_METADATA_PR_HEAD_SHA=true</code></li>
</ul>
</li>
<li>Bump csv-parse from 5.3.0 to 5.3.1 (<a href="https://redirect.github.com/docker/metadata-action/issues/237 ">#237</a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/metadata-action/compare/v4.1.0...v4.1.1 ">https://github.com/docker/metadata-action/compare/v4.1.0...v4.1.1 </a></p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Upgrade guide</summary>
<p><em>Sourced from <a href="https://github.com/docker/metadata-action/blob/master/UPGRADE.md ">docker/metadata-action's upgrade guide</a>.</em></p>
<blockquote>
<h1>Upgrade notes</h1>
<h2>v2 to v3</h2>
<ul>
<li>Repository has been moved to docker org. Replace <code>crazy-max/ghaction-docker-meta@v2</code>
with <code>docker/metadata-action@v5</code></li>
<li>The default bake target has been changed: <code>ghaction-docker-meta</code> > <code>docker-metadata-action</code></li>
</ul>
<h2>v1 to v2</h2>
<ul>
<li><a href="https://github.com/docker/metadata-action/blob/master/#inputs ">inputs</a>
<ul>
<li><a href="https://github.com/docker/metadata-action/blob/master/#tag-sha "><code>tag-sha</code></a></li>
<li><a href="https://github.com/docker/metadata-action/blob/master/#tag-edge--tag-edge-branch "><code>tag-edge</code> / <code>tag-edge-branch</code></a></li>
<li><a href="https://github.com/docker/metadata-action/blob/master/#tag-semver "><code>tag-semver</code></a></li>
<li><a href="https://github.com/docker/metadata-action/blob/master/#tag-match--tag-match-group "><code>tag-match</code> / <code>tag-match-group</code></a></li>
<li><a href="https://github.com/docker/metadata-action/blob/master/#tag-latest "><code>tag-latest</code></a></li>
<li><a href="https://github.com/docker/metadata-action/blob/master/#tag-schedule "><code>tag-schedule</code></a></li>
<li><a href="https://github.com/docker/metadata-action/blob/master/#tag-custom--tag-custom-only "><code>tag-custom</code> / <code>tag-custom-only</code></a></li>
<li><a href="https://github.com/docker/metadata-action/blob/master/#label-custom "><code>label-custom</code></a></li>
</ul>
</li>
<li><a href="https://github.com/docker/metadata-action/blob/master/#basic-workflow ">Basic workflow</a></li>
<li><a href="https://github.com/docker/metadata-action/blob/master/#semver-workflow ">Semver workflow</a></li>
</ul>
<h3>inputs</h3>
<table>
<thead>
<tr>
<th>New</th>
<th>Unchanged</th>
<th>Removed</th>
</tr>
</thead>
<tbody>
<tr>
<td><code>tags</code></td>
<td><code>images</code></td>
<td><code>tag-sha</code></td>
</tr>
<tr>
<td><code>flavor</code></td>
<td><code>sep-tags</code></td>
<td><code>tag-edge</code></td>
</tr>
<tr>
<td><code>labels</code></td>
<td><code>sep-labels</code></td>
<td><code>tag-edge-branch</code></td>
</tr>
<tr>
<td></td>
<td></td>
<td><code>tag-semver</code></td>
</tr>
<tr>
<td></td>
<td></td>
<td><code>tag-match</code></td>
</tr>
<tr>
<td></td>
<td></td>
<td><code>tag-match-group</code></td>
</tr>
<tr>
<td></td>
<td></td>
<td><code>tag-latest</code></td>
</tr>
<tr>
<td></td>
<td></td>
<td><code>tag-schedule</code></td>
</tr>
<tr>
<td></td>
<td></td>
<td><code>tag-custom</code></td>
</tr>
<tr>
<td></td>
<td></td>
<td><code>tag-custom-only</code></td>
</tr>
<tr>
<td></td>
<td></td>
<td><code>label-custom</code></td>
</tr>
</tbody>
</table>
<h4><code>tag-sha</code></h4>
<pre lang="yaml"><code>tags: |
type=sha
</code></pre>
<h4><code>tag-edge</code> / <code>tag-edge-branch</code></h4>
<pre lang="yaml"><code>tags: |
# default branch
</tr></table>
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="96383f4557https://redirect.github.com/docker/metadata-action/issues/320 ">#320</a> from docker/dependabot/npm_and_yarn/csv-parse-5.5.0</li>
<li><a href="f138b9677b9cf7015b155a8a5ff8dfhttps://redirect.github.com/docker/metadata-action/issues/315 ">#315</a> from docker/dependabot/npm_and_yarn/handlebars-4.7.8</li>
<li><a href="2279d9af58c65993321348d23ccc05https://redirect.github.com/docker/metadata-action/issues/333 ">#333</a> from docker/dependabot/npm_and_yarn/actions/core-1.10.1</li>
<li><a href="b83ffb48d63207f2405f63f4a263e5https://redirect.github.com/docker/metadata-action/issues/328 ">#328</a> from crazy-max/update-node20</li>
<li>Additional commits viewable in <a href="https://github.com/docker/metadata-action/compare/v4...v5 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-04 08:40:29 +00:00
44aaf5d9e3
Bump docker/metadata-action from 4 to 5
...
Bumps [docker/metadata-action](https://github.com/docker/metadata-action ) from 4 to 5.
- [Release notes](https://github.com/docker/metadata-action/releases )
- [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md )
- [Commits](https://github.com/docker/metadata-action/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: docker/metadata-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-03 23:09:04 +00:00
