Clément Renault 
							
						 
					 
					
						
						
							
						
						5df5eb2db2 
					 
					
						
						
							
							Clarify a method name  
						
						
						
						
							
						
					 
					
						2024-12-02 10:10:48 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						30eb0e5b5b 
					 
					
						
						
							
							Rename recv and read methods to recv_action and recv_frame  
						
						
						
						
							
						
					 
					
						2024-12-02 10:08:01 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						5b860cb989 
					 
					
						
						
							
							Fix english in the doc  
						
						
						
						
							
						
					 
					
						2024-12-02 10:06:35 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						76d0623b11 
					 
					
						
						
							
							Reduce the number of unwraps  
						
						
						
						
							
						
					 
					
						2024-12-02 10:05:06 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						db4eaf4d2d 
					 
					
						
						
							
							Rename serialize_into into serialize_into_writer  
						
						
						
						
							
						
					 
					
						2024-12-02 10:03:27 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						13f21206a6 
					 
					
						
						
							
							Call the serialize_into_writer method from the serialize_into one  
						
						
						
						
							
						
					 
					
						2024-12-02 10:03:01 +01:00 
						 
				 
			
				
					
						
							
							
								dependabot[bot] 
							
						 
					 
					
						
						
							
						
						27bb591331 
					 
					
						
						
							
							Bump xt0rted/pull-request-comment-branch from 2 to 3  
						
						... 
						
						
						
						Bumps [xt0rted/pull-request-comment-branch](https://github.com/xt0rted/pull-request-comment-branch ) from 2 to 3.
- [Release notes](https://github.com/xt0rted/pull-request-comment-branch/releases )
- [Changelog](https://github.com/xt0rted/pull-request-comment-branch/blob/main/CHANGELOG.md )
- [Commits](https://github.com/xt0rted/pull-request-comment-branch/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: xt0rted/pull-request-comment-branch
  dependency-type: direct:production
  update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com > 
						
						
							
						
					 
					
						2024-12-01 17:52:21 +00:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						14ee7aa84c 
					 
					
						
						
							
							Make sure the BBQueue is at least 50 MiB  
						
						
						
						
							
						
					 
					
						2024-11-28 18:02:48 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						8a35cd1743 
					 
					
						
						
							
							Adjust the BBQueue buffers to use 2% instead of 10%  
						
						
						
						
							
						
					 
					
						2024-11-28 16:00:15 +01:00 
						 
				 
			
				
					
						
							
							
								meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						8d33af1dff 
					 
					
						
						
							
							Merge  #5102  
						
						... 
						
						
	
		
			
	 
	
	
		
	
	
		
			
				
	Test suite / Tests almost all features (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Test disabled tokenization (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Tests on ubuntu-20.04 (push) Failing after 24s 
				
					
					
			 
		
			
				
	Test suite / Tests on ${{ matrix.os }} (windows-2022) (push) Failing after 28s 
				
					
					
			 
		
			
				
	Test suite / Run tests in debug (push) Failing after 28s 
				
					
					
			 
		
			
				
	Test suite / Run Rustfmt (push) Successful in 3m52s 
				
					
					
			 
		
			
				
	Test suite / Run Clippy (push) Successful in 9m8s 
				
					
					
			 
		
			
				
	Test suite / Tests on ${{ matrix.os }} (macos-13) (push) Has been cancelled 
				
					
					
			 
		
		
	 
 
	 
						
						5102: Update mini-dashboard to v0.2.16 version r=curquiza a=curquiza
Fixes https://github.com/meilisearch/meilisearch/issues/5093 
Fixes this bug: https://github.com/meilisearch/mini-dashboard/issues/563 
Co-authored-by: curquiza <clementine@meilisearch.com > 
						
						
							
 
						
					 
					
						2024-11-28 14:57:27 +00:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						3c7ac093d3 
					 
					
						
						
							
							Take the BBQueue capacity into account in the max memory  
						
						
						
						
							
						
					 
					
						2024-11-28 15:43:14 +01:00 
						 
				 
			
				
					
						
							
							
								meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						d49d127863 
					 
					
						
						
							
							Merge  #5101  
						
						... 
						
						
						
						5101: Fix index settings opt out r=Kerollmops a=ManyTheFish
# Pull Request
## Related issue
Fixes  #5099  
## What does this PR do?
- Refactor the settings implementation ensuring the routes are configured
- Add a test checking if all the routes are tested
- Refactor the tests to ease the modifications
Co-authored-by: ManyTheFish <many@meilisearch.com > 
						
						
							
						
					 
					
						2024-11-28 14:23:33 +00:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						b57dd5c58e 
					 
					
						
						
							
							Remove the Vector variant and use the Vectors  
						
						
						
						
							
						
					 
					
						2024-11-28 15:20:43 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						90b428a8c3 
					 
					
						
						
							
							Apply change requests  
						
						
						
						
							
						
					 
					
						2024-11-28 15:16:13 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						096a28656e 
					 
					
						
						
							
							Fix a bug around deleting all the vectors of a doc  
						
						
						
						
							
						
					 
					
						2024-11-28 15:15:06 +01:00 
						 
				 
			
				
					
						
							
							
								curquiza 
							
						 
					 
					
						
						
							
						
						3dc87f5baa 
					 
					
						
						
							
							Update mini-dashboard to v0.2.16 version  
						
						
						
						
							
						
					 
					
						2024-11-28 14:33:05 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						cc4bd54669 
					 
					
						
						
							
							Correctly construct the Embeddings struct  
						
						
						
						
							
						
					 
					
						2024-11-28 13:53:25 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						5383f41bba 
					 
					
						
						
							
							Polish test_setting_routes!  
						
						
						
						
							
						
					 
					
						2024-11-28 12:04:21 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						58eab9a018 
					 
					
						
						
							
							Send large payload through crossbeam  
						
						
						
						
							
						
					 
					
						2024-11-28 12:01:06 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						9f36ffcbdb 
					 
					
						
						
							
							Polish make_setting_routes!  
						
						
						
						
							
						
					 
					
						2024-11-28 11:44:09 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						68c4717e21 
					 
					
						
						
							
							Change the settings tests and macros to avoid oversights  
						
						
						
						
							
						
					 
					
						2024-11-28 11:34:35 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						5c488e20cc 
					 
					
						
						
							
							Send the geo rtree through crossbeam channel  
						
						
						
						
							
						
					 
					
						2024-11-27 18:03:45 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						da650f834e 
					 
					
						
						
							
							Plug the NoPanicThreadPool in the tests and benchmarks  
						
						
						
						
							
						
					 
					
						2024-11-27 17:04:49 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						e83534a430 
					 
					
						
						
							
							Fix the indexer::index to correctly use the rayon::ThreadPool  
						
						
						
						
							
						
					 
					
						2024-11-27 16:27:43 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						98d4a2909e 
					 
					
						
						
							
							Fix the way we spawn the rayon threadpool  
						
						
						
						
							
						
					 
					
						2024-11-27 16:05:44 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						a514ce472a 
					 
					
						
						
							
							Make clippy happy  
						
						
						
						
							
						
					 
					
						2024-11-27 14:59:04 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						cc63802115 
					 
					
						
						
							
							Modify and return the IndexEmbeddings to write them later  
						
						
						
						
							
						
					 
					
						2024-11-27 14:58:03 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						acec45ad7c 
					 
					
						
						
							
							Send a WakeUp when writing data in the BBQueue buffers  
						
						
						
						
							
						
					 
					
						2024-11-27 14:33:23 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						08d6413365 
					 
					
						
						
							
							Fix result types  
						
						
						
						
							
						
					 
					
						2024-11-27 14:32:42 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						70802eb7c7 
					 
					
						
						
							
							Fix most issues with the lifetimes  
						
						
						
						
							
						
					 
					
						2024-11-27 14:32:42 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						6ac5b3b136 
					 
					
						
						
							
							Finish most of the channels types  
						
						
						
						
							
						
					 
					
						2024-11-27 14:32:26 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						e1e76f39d0 
					 
					
						
						
							
							Clean up dependencies  
						
						
						
						
							
						
					 
					
						2024-11-27 14:30:34 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						2094ce8a9a 
					 
					
						
						
							
							Move the arroy building after the writing loop  
						
						
						
						
							
						
					 
					
						2024-11-27 14:30:33 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						8442db8101 
					 
					
						
						
							
							Implement mostly all senders  
						
						
						
						
							
						
					 
					
						2024-11-27 14:16:35 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						79671c9faa 
					 
					
						
						
							
							Implement a first version of the bbqueue channels  
						
						
						
						
							
						
					 
					
						2024-11-27 14:15:00 +01:00 
						 
				 
			
				
					
						
							
							
								meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						a2f64f6552 
					 
					
						
						
							
							Merge  #5095  
						
						... 
						
						
	
		
			
	 
	
	
		
	
	
		
			
				
	Test suite / Tests on ${{ matrix.os }} (macos-13) (push) Waiting to run 
				
					
					
			 
		
			
				
	Test suite / Tests almost all features (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Test disabled tokenization (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Tests on ubuntu-20.04 (push) Failing after 13s 
				
					
					
			 
		
			
				
	Test suite / Run tests in debug (push) Failing after 12s 
				
					
					
			 
		
			
				
	Test suite / Tests on ${{ matrix.os }} (windows-2022) (push) Failing after 40s 
				
					
					
			 
		
			
				
	Test suite / Run Rustfmt (push) Successful in 1m46s 
				
					
					
			 
		
			
				
	Test suite / Run Clippy (push) Successful in 9m55s 
				
					
					
			 
		
		
	 
 
	 
						
						5095: Span to measure the part of db writes that is after the merge/extraction r=curquiza a=dureuill
Co-authored-by: Louis Dureuil <louis@meilisearch.com > 
						
						
							
 
 
						
					 
					
						2024-11-27 11:10:00 +00:00 
						 
				 
			
				
					
						
							
							
								meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						fde2e0691c 
					 
					
						
						
							
							Merge  #5098  
						
						... 
						
						
						
						5098: Update charabia v0.9.2 r=dureuill a=ManyTheFish
# Pull Request
## Related issue
Fixes  #5097 
Co-authored-by: ManyTheFish <many@meilisearch.com > 
						
						
							
						
					 
					
						2024-11-27 10:28:04 +00:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						18a9af353c 
					 
					
						
						
							
							Update Charabia version to v0.9.2  
						
						
						
						
							
						
					 
					
						2024-11-27 11:12:08 +01:00 
						 
				 
			
				
					
						
							
							
								meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						aae0dc715d 
					 
					
						
						
							
							Merge  #5063  
						
						... 
						
						
						
						5063: Fix pagination when embedding fails r=Kerollmops a=dureuill
# Pull Request
## Related issue
Fixes https://github.com/meilisearch/meilisearch/issues/5045 
## What does this PR do?
- Use `return_keyword_results` function when embedding fails
Co-authored-by: Louis Dureuil <louis@meilisearch.com > 
						
						
							
						
					 
					
						2024-11-27 09:13:28 +00:00 
						 
				 
			
				
					
						
							
							
								meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						d0b2c0a523 
					 
					
						
						
							
							Merge  #5091  
						
						... 
						
						
	
		
			
	 
	
	
		
	
	
		
			
				
	Test suite / Tests on ${{ matrix.os }} (macos-13) (push) Waiting to run 
				
					
					
			 
		
			
				
	Test suite / Tests almost all features (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Test disabled tokenization (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Tests on ubuntu-20.04 (push) Failing after 11s 
				
					
					
			 
		
			
				
	Test suite / Run tests in debug (push) Failing after 10s 
				
					
					
			 
		
			
				
	Test suite / Tests on ${{ matrix.os }} (windows-2022) (push) Failing after 39s 
				
					
					
			 
		
			
				
	Test suite / Run Rustfmt (push) Successful in 1m38s 
				
					
					
			 
		
			
				
	Test suite / Run Clippy (push) Successful in 23m11s 
				
					
					
			 
		
		
	 
 
	 
						
						5091: Settings opt out r=Kerollmops a=ManyTheFish
# Pull Request
Related PRD: https://www.notion.so/meilisearch/API-usage-Settings-to-opt-out-indexing-features-fff4b06b651f8108ade3f858aeb16b14?pvs=4 
## Related issue
Fixes  #4979  
- [x] Add setting opt-out
- [x] Add analytics
- [x] Add tests
Co-authored-by: ManyTheFish <many@meilisearch.com >
Co-authored-by: Many the fish <many@meilisearch.com > 
						
						
							
						
					 
					
						2024-11-26 15:50:28 +00:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						2e896f30a5 
					 
					
						
						
							
							Fix PR comments  
						
						
						
						
							
						
					 
					
						2024-11-26 16:06:33 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						8f57b4fdf4 
					 
					
						
						
							
							Span to measure the part of db writes that is after the merge/extraction  
						
						
						
						
							
						
					 
					
						2024-11-26 14:46:36 +01:00 
						 
				 
			
				
					
						
							
							
								Many the fish 
							
						 
					 
					
						
						
							
						
						f014e78684 
					 
					
						
						
							
							Update crates/milli/src/index.rs  
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
							
						
					 
					
						2024-11-26 14:46:01 +01:00 
						 
				 
			
				
					
						
							
							
								Many the fish 
							
						 
					 
					
						
						
							
						
						9008ecda3d 
					 
					
						
						
							
							Update crates/meilisearch-types/src/settings.rs  
						
						... 
						
						
						
						Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
							
						
					 
					
						2024-11-26 14:44:24 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						d7bcfb2d19 
					 
					
						
						
							
							fix clippy  
						
						
						
						
							
						
					 
					
						2024-11-26 14:04:16 +01:00 
						 
				 
			
				
					
						
							
							
								meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						fb66fec398 
					 
					
						
						
							
							Merge  #5092  
						
						... 
						
						
	
		
			
	 
	
	
		
	
	
		
			
				
	Test suite / Tests on ${{ matrix.os }} (macos-13) (push) Waiting to run 
				
					
					
			 
		
			
				
	Test suite / Tests almost all features (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Test disabled tokenization (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Tests on ubuntu-20.04 (push) Failing after 12s 
				
					
					
			 
		
			
				
	Test suite / Run tests in debug (push) Failing after 11s 
				
					
					
			 
		
			
				
	Test suite / Tests on ${{ matrix.os }} (windows-2022) (push) Failing after 23s 
				
					
					
			 
		
			
				
	Test suite / Run Rustfmt (push) Successful in 1m41s 
				
					
					
			 
		
			
				
	Test suite / Run Clippy (push) Successful in 5m36s 
				
					
					
			 
		
		
	 
 
	 
						
						5092: Precise spans for new indexer r=dureuill a=dureuill
- Separate extract and merge spans
- Add span around commit
Co-authored-by: Louis Dureuil <louis@meilisearch.com > 
						
						
							
						
					 
					
						2024-11-26 10:59:40 +00:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						fa15be5bc4 
					 
					
						
						
							
							Add span around commit  
						
						
						
						
							
						
					 
					
						2024-11-26 09:45:48 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						aa460819a7 
					 
					
						
						
							
							Add more precise spans  
						
						
						
						
							
						
					 
					
						2024-11-26 09:45:36 +01:00 
						 
				 
			
				
					
						
							
							
								meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						e241f91285 
					 
					
						
						
							
							Merge  #5062  
						
						... 
						
						
						
						5062: Fix bugs for v1.12 r=Kerollmops a=ManyTheFish
# Pull Request
## Related issue
Fixes  #4984 
Fixes https://github.com/meilisearch/meilisearch/issues/4974 
Fixes [SDK test](https://github.com/meilisearch/meilisearch/actions/runs/11886701996/job/33118278794 )
## What does this PR do?
- add 3 tests
- fix bugs
Co-authored-by: ManyTheFish <many@meilisearch.com > 
						
						
							
						
					 
					
						2024-11-26 08:10:50 +00:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						d66dc363ed 
					 
					
						
						
							
							Test and implement settings opt-out  
						
						
						
						
							
						
					 
					
						2024-11-25 18:23:22 +01:00