2741756248
Merge remote-tracking branch 'origin/main' into facet-levels-refactor
2022-10-26 14:03:23 +02:00
3b1f908e5e
Revert behaviour of facet distribution to what it was before
...
Where the docid that is used to get the original facet string value
definitely belongs to the candidates
2022-10-26 13:48:01 +02:00
a034a1e628
Move StrRefCodec and ByteSliceRefCodec to their own files
2022-10-26 13:47:46 +02:00
d0109627b9
Fix a bug in facet_range_search and add documentation
2022-10-26 13:47:04 +02:00
cb8442a119
Further unify facet databases of f64s and strings
2022-10-26 13:47:04 +02:00
86d9f50b9c
Fix bugs in incremental facet indexing with variable parameters
...
e.g. add one facet value incrementally with a group_size = X and then
add another one with group_size = Y
It is not actually possible to do so with the public API of milli,
but I wanted to make sure the algorithm worked well in those cases
anyway.
The bugs were found by fuzzing the code with fuzzcheck, which I've added
to milli as a conditional dev-dependency. But it can be removed later.
2022-10-26 13:47:04 +02:00
de52a9bf75
Improve documentation of some facet-related algorithms
2022-10-26 13:47:04 +02:00
985a94adfc
cargo fmt
2022-10-26 13:47:04 +02:00
3d7ed3263f
Fix bug in string facet distribution with few candidates
2022-10-26 13:47:04 +02:00
fca4577e23
Return original string in facet distributions, work on facet tests
2022-10-26 13:47:04 +02:00
b2f01ad204
Refactor facet database tests
2022-10-26 13:47:04 +02:00
9026867d17
Give same interface to bulk and incremental facet indexing types
...
+ cargo fmt, oops, sorry for the bad history :(
2022-10-26 13:47:04 +02:00
330c9eb1b2
Rename facet codecs and refine FacetsUpdate API
2022-10-26 13:47:04 +02:00
485a72306d
Refactor facet-related codecs
2022-10-26 13:47:04 +02:00
3d145d7f48
Merge the two <facetttype>_faceted_documents_ids methods into one
2022-10-26 13:47:04 +02:00
079ed4a992
Add more snapshots
2022-10-26 13:47:04 +02:00
afdf87f6f7
Fix bugs in asc/desc criterion and facet indexing
2022-10-26 13:47:04 +02:00
a7201ece04
cargo fmt
2022-10-26 13:47:04 +02:00
36296bbb20
Add facet incremental indexing snapshot tests + fix bug
2022-10-26 13:47:04 +02:00
07ff92c663
Add more snapshots from facet tests
2022-10-26 13:47:04 +02:00
61252248fb
Fix some facet indexing bugs
2022-10-26 13:47:04 +02:00
68cbcdf08b
Fix compile errors/warnings in http-ui and infos
2022-10-26 13:47:04 +02:00
85824ee203
Try to make facet indexing incremental
2022-10-26 13:47:04 +02:00
d30c89e345
Fix compile error+warnings in new tests
2022-10-26 13:46:46 +02:00
e8a156d682
Reorganise facets database indexing code
2022-10-26 13:46:46 +02:00
e570c23153
Reintroduce asc/desc functionality
2022-10-26 13:46:14 +02:00
bd2c0e1ab6
Remove unused code
2022-10-26 13:46:14 +02:00
39a4a0a362
Reintroduce filter range search and facet extractors
2022-10-26 13:46:14 +02:00
5a904cf29d
Reintroduce facet distribution functionality
2022-10-26 13:46:14 +02:00
b8a1caad5e
Add range search and incremental indexing algorithm
2022-10-26 13:46:14 +02:00
63ef0aba18
Start porting facet distribution and sort to new database structure
2022-10-26 13:46:14 +02:00
c3f49f766d
Prepare refactor of facets database
...
Prepare refactor of facets database
2022-10-26 13:46:14 +02:00
c8f16530d5
Merge #616
...
616: Introduce an indexation abortion function when indexing documents r=Kerollmops a=Kerollmops
Co-authored-by: Kerollmops <clement@meilisearch.com >
Co-authored-by: Clément Renault <clement@meilisearch.com >
2022-10-26 11:41:18 +00:00
2ce025a906
Fixes after rebase to fix new issues.
2022-10-25 20:58:31 +02:00
17f7922bfc
Remove unneeded lifetimes.
2022-10-25 20:49:04 +02:00
6b2fe94192
Fixes for clippy bringing us down to 18 remaining issues.
...
This brings us a step closer to enforcing clippy on each build.
2022-10-25 20:49:02 +02:00
be302fd250
Remove outdated workaround for duplicate words in phrase search
2022-10-24 15:27:06 +02:00
d76d0cb1bf
Merge branch 'main' into word-pair-proximity-docids-refactor
2022-10-24 15:23:00 +02:00
a983129613
Apply suggestions from code review
2022-10-20 09:49:37 +02:00
f11a4087da
Merge #665
...
665: Fixing piles of clippy errors. r=ManyTheFish a=ehiggs
## Related issue
No issue fixed. Simply cleaning up some code for clippy on the march towards a clean build when #659 is merged.
## What does this PR do?
Most of these are calling clone when the struct supports Copy.
Many are using & and &mut on `self` when the function they are called from already has an immutable or mutable borrow so this isn't needed.
I tried to stay away from actual changes or places where I'd have to name fresh variables.
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Co-authored-by: Ewan Higgs <ewan.higgs@gmail.com >
2022-10-20 07:19:46 +00:00
176ffd23f5
Fix compile error after rebasing wppd-refactor
2022-10-18 10:40:26 +02:00
e6e76fbefe
Improve performance of resolve_phrase at the cost of some relevancy
2022-10-18 10:37:34 +02:00
830a7c0c7a
Use resolve_phrase function for exactness criteria as well
2022-10-18 10:37:34 +02:00
18d578dfc4
Adjust some algorithms using DBs of word pair proximities
2022-10-18 10:37:34 +02:00
1dbbd8694f
Rename StrStrU8Codec to U8StrStrCodec and reorder its fields
2022-10-18 10:37:34 +02:00
81919a35a2
Update milli/src/search/criteria/initial.rs
...
Co-authored-by: Clément Renault <clement@meilisearch.com >
2022-10-17 18:23:20 +02:00
516e838eb4
Update milli/src/search/criteria/initial.rs
...
Co-authored-by: Clément Renault <clement@meilisearch.com >
2022-10-17 18:23:15 +02:00
6603437cb1
Introduce an indexation abortion function when indexing documents
2022-10-17 17:28:03 +02:00
6f55e7844c
Add some code comments
2022-10-17 14:41:57 +02:00
cf203b7fde
Take filter in account when computing the pages candidates
2022-10-17 14:13:44 +02:00
