meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						c1d8ee2a8d 
					 
					
						
						
							
							Merge  #5048  
						
						... 
						
						
	
		
			
	 
	
	
		
	
	
		
			
				
	Test suite / Tests almost all features (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Test disabled tokenization (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Tests on ubuntu-20.04 (push) Failing after 14s 
				
					
					
			 
		
			
				
	Test suite / Run tests in debug (push) Failing after 24s 
				
					
					
			 
		
			
				
	Test suite / Tests on ${{ matrix.os }} (windows-2022) (push) Failing after 57s 
				
					
					
			 
		
			
				
	Test suite / Run Rustfmt (push) Successful in 1m36s 
				
					
					
			 
		
			
				
	Test suite / Run Clippy (push) Successful in 6m8s 
				
					
					
			 
		
			
				
	Indexing bench (push) / Run and upload benchmarks (push) Waiting to run 
				
					
					
			 
		
			
				
	Benchmarks of indexing (push) / Run and upload benchmarks (push) Waiting to run 
				
					
					
			 
		
			
				
	Benchmarks of search for geo (push) / Run and upload benchmarks (push) Waiting to run 
				
					
					
			 
		
			
				
	Benchmarks of search for songs (push) / Run and upload benchmarks (push) Waiting to run 
				
					
					
			 
		
			
				
	Benchmarks of search for Wikipedia articles (push) / Run and upload benchmarks (push) Waiting to run 
				
					
					
			 
		
			
				
	Run the indexing fuzzer / Setup the action (push) Successful in 1h4m23s 
				
					
					
			 
		
			
				
	Test suite / Tests on ${{ matrix.os }} (macos-13) (push) Has been cancelled 
				
					
					
			 
		
		
	 
 
	 
						
						5048: Reverse the order of the task queue r=Kerollmops a=irevoire
# Pull Request
## Related issue
Fixes https://github.com/meilisearch/meilisearch/issues/5047 
## What does this PR do?
- Provide a new parameter to reverse the order of the task queue
- Add tests
- Remove some unrelated tests that were duplicated in tests/tasks/mod.rs and tests/tasks/error.rs
Co-authored-by: Tamo <tamo@meilisearch.com > 
						
						
					 
					
						2024-11-18 16:24:12 +00:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						04c38220ca 
					 
					
						
						
							
							Move MostlySend, ThreadLocal, FullySend to their own commit  
						
						
						
						
					 
					
						2024-11-18 16:43:05 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						5f93651cef 
					 
					
						
						
							
							fixes  
						
						
						
						
					 
					
						2024-11-18 16:23:11 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						510ca99996 
					 
					
						
						
							
							Fixes   #4974  
						
						
						
						
					 
					
						2024-11-18 16:08:55 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						8924d486db 
					 
					
						
						
							
							Add a test reproducing the bug  
						
						
						
						
					 
					
						2024-11-18 16:08:55 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						e0c3f3d560 
					 
					
						
						
							
							Fix   #4984  
						
						
						
						
					 
					
						2024-11-18 16:08:53 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						0a21d9bfb3 
					 
					
						
						
							
							Fix double borrow of new fields id map  
						
						
						
						
					 
					
						2024-11-18 15:56:01 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						1f8b01a598 
					 
					
						
						
							
							Fix snap since _vectors is no longer part of the field distributions  
						
						
						
						
					 
					
						2024-11-18 12:50:59 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						e736a74729 
					 
					
						
						
							
							Remove infinite loop in import_vectors  
						
						
						
						
					 
					
						2024-11-18 12:50:56 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						e9d17136b2 
					 
					
						
						
							
							Add deadline of 3 seconds to embedding requests made in the context of hybrid search  
						
						
						
						
					 
					
						2024-11-18 12:15:11 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						a05e448cf8 
					 
					
						
						
							
							Add test  
						
						
						
						
					 
					
						2024-11-18 12:15:11 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						cd796b0f4b 
					 
					
						
						
							
							Fix SDK test  
						
						
						
						
					 
					
						2024-11-18 11:46:00 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						6570da3bcb 
					 
					
						
						
							
							Retry in case where the JSON deserialization fails  
						
						
						
						
					 
					
						2024-11-18 11:33:09 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						5b4c06c24c 
					 
					
						
						
							
							Plug the grenad max memory parameter  
						
						
						
						
					 
					
						2024-11-18 11:28:04 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						3a8051866a 
					 
					
						
						
							
							Use return_keyword_results function instead of returning raw keyword results when the embedder is broken  
						
						
						
						
					 
					
						2024-11-18 11:17:15 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						9150c8f052 
					 
					
						
						
							
							Accept changes to vector format  
						
						
						
						
					 
					
						2024-11-18 11:04:57 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						c202f3dbe2 
					 
					
						
						
							
							fix tests and revert change in behavior when primary_key_from_op != primary_key_from_db && index.is_empty()  
						
						
						
						
					 
					
						2024-11-18 10:59:05 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						677d7293f5 
					 
					
						
						
							
							Fix a lot of primary key related tests  
						
						
						
						
					 
					
						2024-11-18 10:59:05 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						bd31ea2174 
					 
					
						
						
							
							Check for at least one valid task after setting their statuses  
						
						
						
						
					 
					
						2024-11-18 10:59:05 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						83865d2ebd 
					 
					
						
						
							
							Expose intermediate errors when processing batches  
						
						
						
						
					 
					
						2024-11-18 10:59:05 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						72ba353498 
					 
					
						
						
							
							reproduce sdk fail  
						
						
						
						
					 
					
						2024-11-18 10:03:23 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						4ff2b3c2ee 
					 
					
						
						
							
							Fix test on locales  
						
						
						
						
					 
					
						2024-11-14 15:45:04 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						91c58cfa38 
					 
					
						
						
							
							Fix positional databases  
						
						
						
						
					 
					
						2024-11-14 11:40:12 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						9e8367f1e6 
					 
					
						
						
							
							Move the rayon thread pool outside the extract method  
						
						
						
						
					 
					
						2024-11-14 10:40:32 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						0dd321afc7 
					 
					
						
						
							
							reproduce  #4984  
						
						
						
						
					 
					
						2024-11-14 10:02:51 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						0e3c5d91ab 
					 
					
						
						
							
							Document deletion test passes  
						
						
						
						
					 
					
						2024-11-14 08:42:56 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						695c2c6b99 
					 
					
						
						
							
							Cosmetic fix  
						
						
						
						
					 
					
						2024-11-14 08:42:39 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						40dd25d6b2 
					 
					
						
						
							
							Fix issue with Replace document method when adding and deleting a document in the same batch  
						
						
						
						
					 
					
						2024-11-13 22:10:00 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						8e5b1a3ec1 
					 
					
						
						
							
							Compute the field distribution and convert _geo into an f64s  
						
						
						
						
					 
					
						2024-11-13 17:44:05 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						e627e182ce 
					 
					
						
						
							
							Fix facet strings  
						
						
						
						
					 
					
						2024-11-13 17:43:02 +01:00 
						 
				 
			
				
					
						
							
							
								ManyTheFish 
							
						 
					 
					
						
						
							
						
						51b6293738 
					 
					
						
						
							
							Add linear facet databases  
						
						
						
						
					 
					
						2024-11-13 17:43:02 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						b17896d899 
					 
					
						
						
							
							Finialize the GeoExtractor  
						
						
						
						
					 
					
						2024-11-13 17:43:02 +01:00 
						 
				 
			
				
					
						
							
							
								meili-bors[bot] 
							
						 
					 
					
						
						
							
						
						94fb55bb6f 
					 
					
						
						
							
							Merge  #5049  
						
						... 
						
						
	
		
			
	 
	
	
		
	
	
		
			
				
	Test suite / Tests on ${{ matrix.os }} (macos-13) (push) Waiting to run 
				
					
					
			 
		
			
				
	Test suite / Tests on ubuntu-20.04 (push) Failing after 59s 
				
					
					
			 
		
			
				
	Test suite / Tests almost all features (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Test disabled tokenization (push) Has been skipped 
				
					
					
			 
		
			
				
	Test suite / Run tests in debug (push) Failing after 13s 
				
					
					
			 
		
			
				
	Test suite / Tests on ${{ matrix.os }} (windows-2022) (push) Failing after 7m4s 
				
					
					
			 
		
			
				
	Test suite / Run Clippy (push) Successful in 10m58s 
				
					
					
			 
		
			
				
	Test suite / Run Rustfmt (push) Successful in 2m34s 
				
					
					
			 
		
			
				
	Run the indexing fuzzer / Setup the action (push) Successful in 1h5m58s 
				
					
					
			 
		
			
				
	Indexing bench (push) / Run and upload benchmarks (push) Has been cancelled 
				
					
					
			 
		
			
				
	Benchmarks of indexing (push) / Run and upload benchmarks (push) Has been cancelled 
				
					
					
			 
		
			
				
	Benchmarks of search for geo (push) / Run and upload benchmarks (push) Has been cancelled 
				
					
					
			 
		
			
				
	Benchmarks of search for songs (push) / Run and upload benchmarks (push) Has been cancelled 
				
					
					
			 
		
			
				
	Benchmarks of search for Wikipedia articles (push) / Run and upload benchmarks (push) Has been cancelled 
				
					
					
			 
		
		
	 
 
	 
						
						5049: Fix the path used in the flaky tests CI r=irevoire a=Kerollmops
This PR fixes [the flaky tests CI](https://github.com/meilisearch/meilisearch/actions/runs/11741717787 ) path used.
Co-authored-by: Clément Renault <clement@meilisearch.com > 
						
						
					 
					
						2024-11-13 10:26:50 +00:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						a01bc7b454 
					 
					
						
						
							
							Fix error_document_field_limit_reached_in_one_document test  
						
						
						
						
					 
					
						2024-11-13 10:34:54 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						7accfea624 
					 
					
						
						
							
							Don't short circuit when we encounter a semantic error while extracting fields and external docid  
						
						
						
						
					 
					
						2024-11-13 10:33:59 +01:00 
						 
				 
			
				
					
						
							
							
								Clément Renault 
							
						 
					 
					
						
						
							
						
						009709eace 
					 
					
						
						
							
							Fix the path used in the flaky tests CI  
						
						
						
						
					 
					
						2024-11-13 09:52:10 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						82dcaba6ca 
					 
					
						
						
							
							Fix test: somehow on main vectors where displayed even though retrieveVectors: false  
						
						
						
						
					 
					
						2024-11-12 23:58:25 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						cb1d6613dd 
					 
					
						
						
							
							Adjust snapshots  
						
						
						
						
					 
					
						2024-11-12 23:26:30 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						3b0cb5b487 
					 
					
						
						
							
							Fix vector error messages  
						
						
						
						
					 
					
						2024-11-12 23:26:16 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						bfdcd1cf33 
					 
					
						
						
							
							Space changes  
						
						
						
						
					 
					
						2024-11-12 22:52:45 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						1d13e804f7 
					 
					
						
						
							
							Adjust test snapshots  
						
						
						
						
					 
					
						2024-11-12 22:52:41 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						c4e9f761e9 
					 
					
						
						
							
							Emit better error messages when parsing vectors  
						
						
						
						
					 
					
						2024-11-12 22:49:22 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						8a6e61c77f 
					 
					
						
						
							
							InvalidVectorsEmbedderConf error takes a String rather than a deserr error  
						
						
						
						
					 
					
						2024-11-12 22:47:57 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						68bbf674c9 
					 
					
						
						
							
							Make REST mock thread independent  
						
						
						
						
					 
					
						2024-11-12 16:31:31 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						980921e078 
					 
					
						
						
							
							Vector fixes  
						
						
						
						
					 
					
						2024-11-12 16:31:22 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						1fcd5f091e 
					 
					
						
						
							
							Remove progress from task  
						
						
						
						
					 
					
						2024-11-12 12:23:13 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						6094bb299a 
					 
					
						
						
							
							Fix user_provided vectors  
						
						
						
						
					 
					
						2024-11-12 10:15:55 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						bef8fc6cf1 
					 
					
						
						
							
							Fix hf embedder  
						
						
						
						
					 
					
						2024-11-08 13:10:17 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						e32677999f 
					 
					
						
						
							
							Adapt some snapshots  
						
						
						
						
					 
					
						2024-11-08 00:06:33 +01:00 
						 
				 
			
				
					
						
							
							
								Louis Dureuil 
							
						 
					 
					
						
						
							
						
						5185aa21b8 
					 
					
						
						
							
							Know if your vectors are implicit when writing them back in documents + don't write empty _vectors  
						
						
						
						
					 
					
						2024-11-08 00:05:36 +01:00