snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-10-10 13:46:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a potential bug where prefixes were not deleted

Browse Source
This commit is contained in:
Kerollmops
2025-10-03 09:49:05 +02:00
parent dc36f681be
commit ea92c64fdc
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
crates/milli/src/update/new/words_prefix_docids.rs
View File

@@ -226,6 +226,7 @@ impl<'i> WordPrefixIntegerDocids<'i> {
} }
let mut bitmaps_bytes_at_positions = HashMap::new(); let mut bitmaps_bytes_at_positions = HashMap::new();
let mut prev_pos = None;
for result in self for result in self
.database .database
.remap_data_type::<Bytes>() .remap_data_type::<Bytes>()
@@ -234,13 +235,24 @@ impl<'i> WordPrefixIntegerDocids<'i> {
let (key, bitmap_bytes) = result?; let (key, bitmap_bytes) = result?;
let (_word, pos) = let (_word, pos) =
StrBEU16Codec::bytes_decode(key).map_err(Error::Decoding)?; StrBEU16Codec::bytes_decode(key).map_err(Error::Decoding)?;
// TODO track position with no corresponding bitmap bytes
// these means that the prefix no longer exists in the database // Track positions with no corresponding bitmap bytes,
// and must, therefore, be removed from the index // these means that the prefix no longer exists in the database
// and must, therefore, be removed from the index.
if let Some(prev_pos) = prev_pos {
// A range with the left bigger than the right bound results in an empty range.
for pos in prev_pos..pos {
// They are represented by an empty set of bitmaps.
bitmaps_bytes_at_positions.entry(pos).or_insert_with(Vec::new);
}
}
bitmaps_bytes_at_positions bitmaps_bytes_at_positions
.entry(pos) .entry(pos)
.or_insert_with(Vec::new) .or_insert_with(Vec::new)
.push(bitmap_bytes); .push(bitmap_bytes);
prev_pos = Some(pos);
} }
for (pos, bitmaps_bytes) in bitmaps_bytes_at_positions { for (pos, bitmaps_bytes) in bitmaps_bytes_at_positions {