snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-12-22 20:37:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

skip settings validation when we have an origin

Browse Source
This commit is contained in:
Louis Dureuil
2025-12-09 18:32:18 +01:00
parent ccc54b1d23
commit e484bfc514
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
crates/meilisearch/src/routes/indexes/settings.rs
View File

@@ -197,11 +197,6 @@ macro_rules! make_setting_route {
..Default::default() ..Default::default()
}; };
let new_settings = $crate::routes::indexes::settings::validate_settings(
new_settings,
&index_scheduler,
)?;
let task = register_new_settings(new_settings, false, index_scheduler, &req, index_uid, opt).await?; let task = register_new_settings(new_settings, false, index_scheduler, &req, index_uid, opt).await?;
debug!(returns = ?task, "Update settings"); debug!(returns = ?task, "Update settings");
@@ -550,7 +545,6 @@ pub async fn update_all(
let new_settings: Settings<Unchecked> = body.into_inner(); let new_settings: Settings<Unchecked> = body.into_inner();
debug!(parameters = ?new_settings, "Update all settings"); debug!(parameters = ?new_settings, "Update all settings");
let new_settings = validate_settings(new_settings, &index_scheduler)?;
analytics.publish( analytics.publish(
SettingsAnalytics { SettingsAnalytics {
@@ -616,6 +610,13 @@ async fn register_new_settings(
let network = index_scheduler.network(); let network = index_scheduler.network();
let task_network = task_network_and_check_leader_and_version(req, &network)?; let task_network = task_network_and_check_leader_and_version(req, &network)?;
// validate settings unless this is a duplicated task
let new_settings = if task_network.is_none() {
validate_settings(new_settings, &index_scheduler)?
} else {
new_settings
};
let allow_index_creation = index_scheduler.filters().allow_index_creation(&index_uid); let allow_index_creation = index_scheduler.filters().allow_index_creation(&index_uid);
let index_uid = IndexUid::try_from(index_uid.into_inner())?.into_inner(); let index_uid = IndexUid::try_from(index_uid.into_inner())?.into_inner();
let task = KindWithContent::SettingsUpdate { let task = KindWithContent::SettingsUpdate {