rename to a clearer name

This commit is contained in:
YoEight
2025-12-11 14:31:16 -05:00
parent d5f66c195d
commit e359325dbd
10 changed files with 41 additions and 41 deletions

View File

@@ -164,7 +164,7 @@ impl<'a> Dump<'a> {
content_file: content_uuid.ok_or(Error::CorruptedDump)?,
documents_count,
allow_index_creation,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
KindDump::DocumentDeletion { documents_ids } => KindWithContent::DocumentDeletion {
documents_ids,

View File

@@ -40,7 +40,7 @@ fn doc_imp(
content_file: Uuid::new_v4(),
documents_count: 0,
allow_index_creation,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
}
}

View File

@@ -294,7 +294,7 @@ fn document_addition_and_index_deletion() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -483,7 +483,7 @@ fn document_addition_and_index_deletion_on_unexisting_index() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,

View File

@@ -31,7 +31,7 @@ fn document_addition() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -68,7 +68,7 @@ fn document_addition_and_document_deletion() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -135,7 +135,7 @@ fn document_deletion_and_document_addition() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -188,7 +188,7 @@ fn test_document_replace() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -240,7 +240,7 @@ fn test_document_update() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -294,7 +294,7 @@ fn test_mixed_document_addition() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -346,7 +346,7 @@ fn test_document_replace_without_autobatching() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -402,7 +402,7 @@ fn test_document_update_without_autobatching() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -462,7 +462,7 @@ fn test_document_addition_cant_create_index_without_index() {
content_file: uuid,
documents_count,
allow_index_creation: false,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -515,7 +515,7 @@ fn test_document_addition_cant_create_index_without_index_without_autobatching()
content_file: uuid,
documents_count,
allow_index_creation: false,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -578,7 +578,7 @@ fn test_document_addition_cant_create_index_with_index() {
content_file: uuid,
documents_count,
allow_index_creation: false,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -646,7 +646,7 @@ fn test_document_addition_cant_create_index_with_index_without_autobatching() {
content_file: uuid,
documents_count,
allow_index_creation: false,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -719,7 +719,7 @@ fn test_document_addition_mixed_rights_with_index() {
content_file: uuid,
documents_count,
allow_index_creation,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -777,7 +777,7 @@ fn test_document_addition_mixed_right_without_index_starts_with_cant_create() {
content_file: uuid,
documents_count,
allow_index_creation,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -834,7 +834,7 @@ fn test_document_addition_with_multiple_primary_key() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -898,7 +898,7 @@ fn test_document_addition_with_multiple_primary_key_batch_wrong_key() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -959,7 +959,7 @@ fn test_document_addition_with_bad_primary_key() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -1046,7 +1046,7 @@ fn test_document_addition_with_set_and_null_primary_key() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -1122,7 +1122,7 @@ fn test_document_addition_with_set_and_null_primary_key_inference_works() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,

View File

@@ -173,7 +173,7 @@ fn import_vectors() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -264,7 +264,7 @@ fn import_vectors() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -401,7 +401,7 @@ fn import_vectors_first_and_embedder_later() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -542,7 +542,7 @@ fn import_vectors_first_and_embedder_later() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -644,7 +644,7 @@ fn delete_document_containing_vector() {
content_file: uuid,
documents_count,
allow_index_creation: false,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -823,7 +823,7 @@ fn delete_embedder_with_user_provided_vectors() {
content_file: uuid,
documents_count,
allow_index_creation: false,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,

View File

@@ -52,7 +52,7 @@ fn fail_in_process_batch_for_document_addition() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -95,7 +95,7 @@ fn fail_in_update_task_after_process_batch_success_for_document_addition() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,
@@ -162,7 +162,7 @@ fn fail_in_process_batch_for_document_deletion() {
content_file: uuid,
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
},
None,
false,

View File

@@ -197,7 +197,7 @@ pub(crate) fn replace_document_import_task(
content_file: Uuid::from_u128(content_file_uuid),
documents_count,
allow_index_creation: true,
document_creation_policy: Default::default(),
on_missing_document: Default::default(),
}
}

View File

@@ -5,7 +5,7 @@ use std::str::FromStr;
use byte_unit::Byte;
use enum_iterator::Sequence;
use milli::update::{DocumentCreationPolicy, IndexDocumentsMethod};
use milli::update::{MissingDocumentPolicy, IndexDocumentsMethod};
use milli::Object;
use roaring::RoaringBitmap;
use serde::{Deserialize, Serialize, Serializer};
@@ -114,7 +114,7 @@ pub enum KindWithContent {
content_file: Uuid,
documents_count: u64,
allow_index_creation: bool,
document_creation_policy: DocumentCreationPolicy,
on_missing_document: MissingDocumentPolicy,
},
DocumentDeletion {
index_uid: String,

View File

@@ -20,7 +20,7 @@ use meilisearch_types::heed::RoTxn;
use meilisearch_types::index_uid::IndexUid;
use meilisearch_types::milli::documents::sort::recursive_sort;
use meilisearch_types::milli::index::EmbeddingsWithMetadata;
use meilisearch_types::milli::update::{DocumentCreationPolicy, IndexDocumentsMethod};
use meilisearch_types::milli::update::{MissingDocumentPolicy, IndexDocumentsMethod};
use meilisearch_types::milli::vector::parsed_vectors::ExplicitVectors;
use meilisearch_types::milli::{AscDesc, DocumentId};
use meilisearch_types::serde_cs::vec::CS;
@@ -1108,10 +1108,10 @@ async fn document_addition(
primary_key,
allow_index_creation,
index_uid: index_uid.to_string(),
document_creation_policy: if matches!(skip_creation, Some(true)) {
DocumentCreationPolicy::Skip
on_missing_document: if matches!(skip_creation, Some(true)) {
MissingDocumentPolicy::Skip
} else {
DocumentCreationPolicy::Allow
MissingDocumentPolicy::Create
},
};

View File

@@ -72,10 +72,10 @@ pub enum IndexDocumentsMethod {
/// This policy is checked when processing a document whose ID is not found in the index.
/// It applies to both add and update operations.
#[derive(Default, Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub enum DocumentCreationPolicy {
pub enum MissingDocumentPolicy {
/// Create the document if it doesn't exist. This is the default behavior.
#[default]
Allow,
Create,
/// Skip the document silently if it doesn't exist. No error is returned, the document is simply
/// not indexed.