snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-09-04 19:56:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add new errors

Browse Source
This commit is contained in:
Mubelotix
2025-07-30 15:18:43 +02:00
parent 064d9d5ff8
commit dc7af47371
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
crates/meilisearch/src/routes/webhooks.rs
View File

@ -125,12 +125,20 @@ impl Aggregate for PatchWebhooksAnalytics {
enum WebhooksError { enum WebhooksError {
#[error("The URL for the webhook `{0}` is missing.")] #[error("The URL for the webhook `{0}` is missing.")]
MissingUrl(String), MissingUrl(String),
#[error("Defining too many webhooks would crush the server. Please limit the number of webhooks to 20. You may use a third-party proxy server to dispatch events to more than 20 endpoints.")]
TooManyWebhooks,
#[error("Too many headers for the webhook `{0}`. Please limit the number of headers to 200.")]
TooManyHeaders(String),
} }
impl ErrorCode for WebhooksError { impl ErrorCode for WebhooksError {
fn error_code(&self) -> meilisearch_types::error::Code { fn error_code(&self) -> meilisearch_types::error::Code {
match self { match self {
WebhooksError::MissingUrl(_) => meilisearch_types::error::Code::InvalidWebhooksUrl, WebhooksError::MissingUrl(_) => meilisearch_types::error::Code::InvalidWebhooksUrl,
WebhooksError::TooManyWebhooks => meilisearch_types::error::Code::InvalidWebhooks,
WebhooksError::TooManyHeaders(_) => {
meilisearch_types::error::Code::InvalidWebhooksHeaders
}
} }
} }
} }
@ -217,6 +225,9 @@ async fn patch_webhooks(
Setting::Set(new_webhook) => { Setting::Set(new_webhook) => {
let old_webhook = webhooks.remove(&name); let old_webhook = webhooks.remove(&name);
let webhook = merge_webhook(&name, old_webhook, new_webhook)?; let webhook = merge_webhook(&name, old_webhook, new_webhook)?;
if webhook.headers.len() > 200 {
return Err(WebhooksError::TooManyHeaders(name).into());
}
webhooks.insert(name.clone(), webhook); webhooks.insert(name.clone(), webhook);
} }
Setting::Reset => { Setting::Reset => {
@ -230,6 +241,10 @@ async fn patch_webhooks(
Setting::NotSet => (), Setting::NotSet => (),
}; };
if webhooks.len() > 20 {
return Err(WebhooksError::TooManyWebhooks.into());
}
analytics.publish(PatchWebhooksAnalytics, &req); analytics.publish(PatchWebhooksAnalytics, &req);
let webhooks = Webhooks { webhooks }; let webhooks = Webhooks { webhooks };