Fix term matching strategy bugs

This commit is contained in:
Loïc Lecrenier
2023-03-30 14:01:52 +02:00
parent 35c16ad047
commit d48cdc67a0
3 changed files with 7 additions and 8 deletions

View File

@ -107,9 +107,6 @@ impl<'ctx, G: RankingRuleGraphTrait> RankingRule<'ctx, QueryGraph> for GraphBase
query_graph: &QueryGraph,
) -> Result<()> {
let removal_cost = if let Some(terms_matching_strategy) = self.terms_matching_strategy {
// oh no this is wrong!
// because
// skipping the second node should require that the first one be skipped too
match terms_matching_strategy {
TermsMatchingStrategy::Last => {
let removal_order =
@ -123,7 +120,7 @@ impl<'ctx, G: RankingRuleGraphTrait> RankingRule<'ctx, QueryGraph> for GraphBase
*costs.get_mut(n) = Some((cost, forbidden_nodes.clone()));
}
forbidden_nodes.union(&ns);
cost = 1000;
cost += 100;
}
costs
}