snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-09-04 03:36:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update old comment

Browse Source
This commit is contained in:
Mubelotix
2025-08-05 10:29:39 +02:00
parent 84bcf9785f
commit afb367c7f4
1 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
crates/milli/src/search/facet/filter.rs
View File

@ -416,14 +416,9 @@ impl<'a> Filter<'a> {
return Ok(docids); return Ok(docids);
} }
Condition::StartsWith { keyword: _, word } => { Condition::StartsWith { keyword: _, word } => {
// There are two algorithms: // The idea here is that "STARTS WITH baba" is the same as "baba <= value < babb".
// // We just incremented the last letter to find the upper bound.
// - The first one is recursive over levels. // The upper bound may not be valid utf8, but lmdb doesn't care as it works over bytes.
// This is more efficient when the prefix is common among many values.
//
// - The second one looks directly at level 0 of the facet group database.
// This pessimistic approach is more efficient when the value is unique.
// It's used as a fallback.
let value = crate::normalize_facet(word.value()); let value = crate::normalize_facet(word.value());
let mut value2 = value.as_bytes().to_owned(); let mut value2 = value.as_bytes().to_owned();
@ -456,9 +451,6 @@ impl<'a> Filter<'a> {
} }
} }
// The idea here is that "STARTS WITH baba" is the same as "baba <= value < babb".
// We just incremented the last letter to find the upper bound.
// The upper bound may not be valid utf8, but lmdb doesn't care as it works over bytes.
let mut docids = RoaringBitmap::new(); let mut docids = RoaringBitmap::new();
let bytes_db = let bytes_db =
index.facet_id_string_docids.remap_key_type::<FacetGroupKeyCodec<BytesRef>>(); index.facet_id_string_docids.remap_key_type::<FacetGroupKeyCodec<BytesRef>>();