snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-09-06 04:36:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Initial fix

Browse Source
This commit is contained in:
Mubelotix
2025-07-22 14:31:42 +02:00
parent 2f2e42e72d
commit 9716834380
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
crates/index-scheduler/src/scheduler/process_snapshot_creation.rs
View File

@ -6,6 +6,7 @@ use meilisearch_types::heed::CompactionOption;
use meilisearch_types::milli::progress::{Progress, VariableNameStep}; use meilisearch_types::milli::progress::{Progress, VariableNameStep};
use meilisearch_types::tasks::{Status, Task}; use meilisearch_types::tasks::{Status, Task};
use meilisearch_types::{compression, VERSION_FILE_NAME}; use meilisearch_types::{compression, VERSION_FILE_NAME};
use roaring::RoaringBitmap;
use crate::processing::{AtomicUpdateFileStep, SnapshotCreationProgress}; use crate::processing::{AtomicUpdateFileStep, SnapshotCreationProgress};
use crate::{Error, IndexScheduler, Result}; use crate::{Error, IndexScheduler, Result};
@ -38,6 +39,10 @@ impl IndexScheduler {
// two read operations as the task processing is synchronous. // two read operations as the task processing is synchronous.
// 2.1 First copy the LMDB env of the index-scheduler // 2.1 First copy the LMDB env of the index-scheduler
//
// Note that just before we copy it, we set the status of the current tasks to Succeeded.
// This is because when the snapshot is loaded in the future, we don't want these tasks to rerun.
// In any case, if the snapshot can be loaded, it means that the tasks did succeed.
progress.update_progress(SnapshotCreationProgress::SnapshotTheIndexScheduler); progress.update_progress(SnapshotCreationProgress::SnapshotTheIndexScheduler);
let dst = temp_snapshot_dir.path().join("tasks"); let dst = temp_snapshot_dir.path().join("tasks");
fs::create_dir_all(&dst)?; fs::create_dir_all(&dst)?;
@ -46,7 +51,20 @@ impl IndexScheduler {
} else { } else {
CompactionOption::Enabled CompactionOption::Enabled
}; };
let mut wtxn = self.env.write_txn()?;
for task in &mut tasks {
task.status = Status::Succeeded;
self.queue.tasks.update_task(&mut wtxn, task)?;
}
wtxn.commit()?;
self.env.copy_to_path(dst.join("data.mdb"), compaction_option)?; self.env.copy_to_path(dst.join("data.mdb"), compaction_option)?;
let mut wtxn = self.scheduler.auth_env.write_txn()?;
for task in &mut tasks {
task.status = Status::Enqueued;
self.queue.tasks.update_task(&mut wtxn, task)?;
}
wtxn.commit()?;
// 2.2 Create a read transaction on the index-scheduler // 2.2 Create a read transaction on the index-scheduler
let rtxn = self.env.read_txn()?; let rtxn = self.env.read_txn()?;