snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-10-27 14:06:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Smaller review changes

Browse Source
This commit is contained in:
Louis Dureuil
2024-05-22 12:26:00 +02:00
parent 3412e7fbcf
commit 8a941c0241
4 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
milli/src/index.rs
View File

@@ -23,7 +23,7 @@ use crate::heed_codec::{
};
use crate::order_by_map::OrderByMap;
use crate::proximity::ProximityPrecision;
use crate::vector::EmbeddingConfig;
use crate::vector::{Embedding, EmbeddingConfig};
use crate::{
default_criteria, CboRoaringBitmapCodec, Criterion, DocumentId, ExternalDocumentsIds,
FacetDistribution, FieldDistribution, FieldId, FieldIdMapMissingEntry, FieldIdWordCountCodec,
@@ -1611,7 +1611,7 @@ impl Index {
&self,
rtxn: &RoTxn<'_>,
docid: DocumentId,
) -> Result<BTreeMap<String, Vec<crate::vector::Embedding>>> {
) -> Result<BTreeMap<String, Vec<Embedding>>> {
let mut res = BTreeMap::new();
for row in self.embedder_category_id.iter(rtxn)? {
let (embedder_name, embedder_id) = row?;

4
milli/src/update/index_documents/extract/extract_vector_points.rs
View File

@@ -89,7 +89,7 @@ struct EmbedderVectorExtractor {
pub fn extract_vector_points<R: io::Read + io::Seek>(
obkv_documents: grenad::Reader<R>,
indexer: GrenadParameters,
settings_diff: Arc<InnerIndexSettingsDiff>,
settings_diff: &InnerIndexSettingsDiff,
) -> Result<Vec<ExtractedVectorPoints>> {
puffin::profile_function!();
@@ -258,8 +258,6 @@ pub fn extract_vector_points<R: io::Read + io::Seek>(
}
}
/////
let mut results = Vec::new();
for EmbedderVectorExtractor {

2
milli/src/update/index_documents/extract/mod.rs
View File

@@ -241,7 +241,7 @@ fn send_original_documents_data(
let original_documents_chunk = original_documents_chunk.clone();
let lmdb_writer_sx = lmdb_writer_sx.clone();
rayon::spawn(move || {
match extract_vector_points(original_documents_chunk.clone(), indexer, settings_diff) {
match extract_vector_points(original_documents_chunk.clone(), indexer, &settings_diff) {
Ok(extracted_vectors) => {
for ExtractedVectorPoints {
manual_vectors,