snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-07-16 19:30:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

vector settings: fix bug where removed fragments were returned as new

Browse Source
This commit is contained in:
Louis Dureuil
2025-07-02 11:36:14 +02:00
parent f6287602e9
commit 82a796aea7
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
crates/milli/src/vector/settings.rs
View File

@ -2420,8 +2420,17 @@ pub(crate) fn fragments_from_settings(
setting: &Setting<EmbeddingSettings>, setting: &Setting<EmbeddingSettings>,
) -> impl Iterator<Item = String> + '_ { ) -> impl Iterator<Item = String> + '_ {
let Some(setting) = setting.as_ref().set() else { return Either::Left(None.into_iter()) }; let Some(setting) = setting.as_ref().set() else { return Either::Left(None.into_iter()) };
let filter_map = |(name, fragment): (&String, &Option<Fragment>)| {
if fragment.is_some() {
Some(name.clone())
} else {
None
}
};
if let Some(setting) = setting.indexing_fragments.as_ref().set() { if let Some(setting) = setting.indexing_fragments.as_ref().set() {
Either::Right(setting.keys().cloned()) Either::Right(setting.iter().filter_map(filter_map))
} else { } else {
let Some(setting) = setting.indexing_embedder.as_ref().set() else { let Some(setting) = setting.indexing_embedder.as_ref().set() else {
return Either::Left(None.into_iter()); return Either::Left(None.into_iter());
@ -2429,6 +2438,6 @@ pub(crate) fn fragments_from_settings(
let Some(setting) = setting.indexing_fragments.as_ref().set() else { let Some(setting) = setting.indexing_fragments.as_ref().set() else {
return Either::Left(None.into_iter()); return Either::Left(None.into_iter());
}; };
Either::Right(setting.keys().cloned()) Either::Right(setting.iter().filter_map(filter_map))
} }
} }