snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-07-28 01:01:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bug when you update a document that was already present in the db, deleted and then inserted again in the same transform

Browse Source
This commit is contained in:
Tamo
2023-02-14 19:09:40 +01:00
parent 1b1703a609
commit 74dcfe9676
2 changed files with 98 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
milli/src/update/index_documents/transform.rs
View File

@ -223,10 +223,13 @@ impl<'a, 'i> Transform<'a, 'i> {
Entry::Occupied(entry) => *entry.get() as u32,
Entry::Vacant(entry) => {
// If the document was already in the db we mark it as a replaced document.
// It'll be deleted later. We keep its original docid to insert it in the grenad.
// It'll be deleted later.
if let Some(docid) = external_documents_ids.get(entry.key()) {
self.replaced_documents_ids.insert(docid);
original_docid = Some(docid);
// If it was already in the list of replaced documents it means it was deleted
// by the remove_document method. We should starts as if it never existed.
if self.replaced_documents_ids.insert(docid) {
original_docid = Some(docid);
}
}
let docid = self
.available_documents_ids