snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-09-25 22:36:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5897 from meilisearch/improve-prom

Browse Source 
improve the prometheus content type we return
This commit is contained in:
Clément Renault
2025-09-18 16:18:16 +00:00
committed by GitHub
parent 000cb93aad d7ad76ea1e
commit 5cd3d36d20
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/meilisearch/src/routes/metrics.rs
View File

@ -180,12 +180,6 @@ pub async fn get_metrics(
let response = String::from_utf8(buffer).expect("Failed to convert bytes to string"); let response = String::from_utf8(buffer).expect("Failed to convert bytes to string");
// We cannot specify the version with ContentType(TEXT_PLAIN_UTF_8) so we have to write everything by hand :( let content_type = ("content-type", prometheus::TEXT_FORMAT);
// see the following for what should be returned: https://prometheus.io/docs/instrumenting/content_negotiation/#content-type-response Ok(HttpResponse::Ok().insert_header(content_type).body(response))
let content_type = ("content-type", "text/plain; version=0.0.4; charset=utf-8");
Ok(HttpResponse::Ok()
// .insert_header(header::ContentType(mime::TEXT_PLAIN_UTF_8))
.insert_header(content_type)
.body(response))
} }