snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-10-22 19:46:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use constant tempfile name to reuse tempfile

Browse Source
This commit is contained in:
Kerollmops
2025-10-15 09:09:40 +02:00
parent 93c5fbbb8b
commit 5a49b93b77
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
crates/index-scheduler/src/scheduler/process_batch.rs
View File

@@ -1,4 +1,5 @@
use std::collections::{BTreeSet, HashMap, HashSet}; use std::collections::{BTreeSet, HashMap, HashSet};
use std::fs::File;
use std::io::{Seek, SeekFrom}; use std::io::{Seek, SeekFrom};
use std::panic::{catch_unwind, AssertUnwindSafe}; use std::panic::{catch_unwind, AssertUnwindSafe};
use std::sync::atomic::Ordering; use std::sync::atomic::Ordering;
@@ -13,7 +14,7 @@ use meilisearch_types::tasks::{Details, IndexSwap, Kind, KindWithContent, Status
use meilisearch_types::versioning::{VERSION_MAJOR, VERSION_MINOR, VERSION_PATCH}; use meilisearch_types::versioning::{VERSION_MAJOR, VERSION_MINOR, VERSION_PATCH};
use milli::update::Settings as MilliSettings; use milli::update::Settings as MilliSettings;
use roaring::RoaringBitmap; use roaring::RoaringBitmap;
use tempfile::PersistError; use tempfile::{PersistError, TempPath};
use time::OffsetDateTime; use time::OffsetDateTime;
use super::create_batch::Batch; use super::create_batch::Batch;
@@ -558,11 +559,12 @@ impl IndexScheduler {
.set_currently_updating_index(Some((index_uid.to_string(), index.clone()))); .set_currently_updating_index(Some((index_uid.to_string(), index.clone())));
progress.update_progress(IndexCompaction::CreateTemporaryFile); progress.update_progress(IndexCompaction::CreateTemporaryFile);
let pre_size = std::fs::metadata(index.path().join("data.mdb"))?.len(); let src_path = index.path().join("data.mdb");
let mut file = tempfile::Builder::new() let pre_size = std::fs::metadata(&src_path)?.len();
.suffix("data.")
.prefix(".mdb.cpy") let dst_path = TempPath::from_path(index.path().join("data.mdb.cpy"));
.tempfile_in(index.path())?; let file = File::create(&dst_path)?;
let mut file = tempfile::NamedTempFile::from_parts(file, dst_path);
// 3. We copy the index data to the temporary file // 3. We copy the index data to the temporary file
progress.update_progress(IndexCompaction::CopyAndCompactTheIndex); progress.update_progress(IndexCompaction::CopyAndCompactTheIndex);
@@ -574,7 +576,7 @@ impl IndexScheduler {
// 4. We replace the index data file with the temporary file // 4. We replace the index data file with the temporary file
progress.update_progress(IndexCompaction::PersistTheCompactedIndex); progress.update_progress(IndexCompaction::PersistTheCompactedIndex);
match file.persist(index.path().join("data.mdb")) { match file.persist(src_path) {
Ok(file) => file.sync_all()?, Ok(file) => file.sync_all()?,
// TODO see if we have a _resource busy_ error and probably handle this by: // TODO see if we have a _resource busy_ error and probably handle this by:
// 1. closing the index, 2. replacing and 3. reopening it // 1. closing the index, 2. replacing and 3. reopening it