snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-07-28 01:01:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

add tests for min_word_len_for_typo

Browse Source
This commit is contained in:
ad hoc
2022-03-31 13:50:18 +02:00
parent 9102de5500
commit 55af85db3c
4 changed files with 83 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
milli/src/update/settings.rs
View File

@ -497,27 +497,27 @@ impl<'a, 't, 'u, 'i> Settings<'a, 't, 'u, 'i> {
fn update_min_typo_word_len(&mut self) -> Result<()> {
match (&self.min_1_typo_word_len, &self.min_2_typos_word_len) {
(Setting::Set(one), Setting::Set(two)) => {
if one < two {
if one > two {
return Err(UserError::InvalidMinTypoWordSetting(*one, *two).into());
} else {
self.index.put_min_word_len_1_typo(&mut self.wtxn, *one)?;
self.index.put_min_word_len_2_typo(&mut self.wtxn, *two)?;
} else {
return Err(UserError::InvalidMinTypoWordSetting(*one, *two).into());
}
}
(Setting::Set(one), _) => {
let two = self.index.min_word_len_2_typo(&self.wtxn)?;
if *one < two {
self.index.put_min_word_len_1_typo(&mut self.wtxn, *one)?;
} else {
if *one > two {
return Err(UserError::InvalidMinTypoWordSetting(*one, two).into());
} else {
self.index.put_min_word_len_1_typo(&mut self.wtxn, *one)?;
}
}
(_, Setting::Set(two)) => {
let one = self.index.min_word_len_1_typo(&self.wtxn)?;
if one < *two {
self.index.put_min_word_len_2_typo(&mut self.wtxn, *two)?;
} else {
if one > *two {
return Err(UserError::InvalidMinTypoWordSetting(one, *two).into());
} else {
self.index.put_min_word_len_2_typo(&mut self.wtxn, *two)?;
}
}
_ => (),
@ -1286,4 +1286,37 @@ mod tests {
builder.execute(|_| ()).unwrap();
assert!(!index.authorize_typos(&txn).unwrap());
}
#[test]
fn update_min_word_len_for_typo() {
let index = TempIndex::new();
let config = IndexerConfig::default();
// Set the genres setting
let mut txn = index.write_txn().unwrap();
let mut builder = Settings::new(&mut txn, &index, &config);
builder.set_min_1_typo_word_len(8);
builder.set_min_2_typos_word_len(8);
builder.execute(|_| ()).unwrap();
txn.commit().unwrap();
let txn = index.read_txn().unwrap();
assert_eq!(index.min_word_len_1_typo(&txn).unwrap(), 8);
assert_eq!(index.min_word_len_2_typo(&txn).unwrap(), 8);
}
#[test]
fn update_invalid_min_word_len_for_typo() {
let index = TempIndex::new();
let config = IndexerConfig::default();
// Set the genres setting
let mut txn = index.write_txn().unwrap();
let mut builder = Settings::new(&mut txn, &index, &config);
builder.set_min_1_typo_word_len(10);
builder.set_min_2_typos_word_len(7);
assert!(builder.execute(|_| ()).is_err());
}
}