snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-10-10 13:46:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve facet post processing readability

Browse Source 
Co-authored-by: Many the fish <many@meilisearch.com>
This commit is contained in:
Clément Renault
2025-10-02 18:11:49 +02:00
committed by Kerollmops
parent 9f79ce82af
commit 48f1987a8d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/milli/src/update/new/indexer/post_processing/facet_bulk.rs
View File

@@ -40,15 +40,15 @@ pub fn generate_facet_levels(
clear_levels(db, wtxn, field_id)?; clear_levels(db, wtxn, field_id)?;
let mut base_level = 0; let mut base_level: u8 = 0;
// That's a do-while loop // That's a do-while loop
while { while {
let mut level_size = 0; let mut level_size = 0;
let level = base_level.checked_add(1).unwrap();
for reader in compute_level(index, wtxn, db, field_id, base_level)? { for reader in compute_level(index, wtxn, db, field_id, base_level)? {
let mut cursor = reader.into_cursor()?; let mut cursor = reader.into_cursor()?;
while let Some((left_bound, facet_group_value)) = cursor.move_on_next()? { while let Some((left_bound, facet_group_value)) = cursor.move_on_next()? {
level_size += 1; level_size += 1;
let level = base_level.checked_add(1).unwrap();
let key = FacetGroupKey { field_id, level, left_bound }; let key = FacetGroupKey { field_id, level, left_bound };
debug_assert!( debug_assert!(
db.get(wtxn, &key).transpose().is_none(), db.get(wtxn, &key).transpose().is_none(),
@@ -58,7 +58,7 @@ pub fn generate_facet_levels(
} }
} }
base_level += 1; base_level = level;
// If the next level will have the minimum required groups, continue. // If the next level will have the minimum required groups, continue.
(level_size / FACET_GROUP_SIZE as usize) >= FACET_MIN_LEVEL_SIZE as usize (level_size / FACET_GROUP_SIZE as usize) >= FACET_MIN_LEVEL_SIZE as usize