Add facet incremental indexing snapshot tests + fix bug

milli/src/search/facet/mod.rs

@@ -77,7 +77,7 @@ pub(crate) fn get_highest_level<'t>(
 }
 
 #[cfg(test)]
-mod test {
+pub mod test {
     use crate::update::FacetsUpdateIncremental;
     use heed::{BytesDecode, BytesEncode, Env, RwTxn};
     use roaring::RoaringBitmap;
@@ -160,6 +160,17 @@ mod test {
             let key_bytes = BoundCodec::bytes_encode(&key).unwrap();
             update.insert(rwtxn, field_id, &key_bytes, docids).unwrap();
         }
+        pub fn delete<'a>(
+            &self,
+            rwtxn: &'a mut RwTxn,
+            field_id: u16,
+            key: &'a <BoundCodec as BytesEncode<'a>>::EItem,
+            value: u32,
+        ) {
+            let update = FacetsUpdateIncremental::new(self.db.content);
+            let key_bytes = BoundCodec::bytes_encode(&key).unwrap();
+            update.delete(rwtxn, field_id, &key_bytes, value).unwrap();
+        }
     }
 
     impl<BoundCodec> Display for FacetIndex<BoundCodec>

milli/src/search/facet/snapshots/facet_distribution_iter.rs/filter_distribution_all/0.snap

@@ -225,4 +225,36 @@ source: milli/src/search/facet/facet_distribution_iter.rs
 221: 1
 222: 1
 223: 1
+224: 1
+225: 1
+226: 1
+227: 1
+228: 1
+229: 1
+230: 1
+231: 1
+232: 1
+233: 1
+234: 1
+235: 1
+236: 1
+237: 1
+238: 1
+239: 1
+240: 1
+241: 1
+242: 1
+243: 1
+244: 1
+245: 1
+246: 1
+247: 1
+248: 1
+249: 1
+250: 1
+251: 1
+252: 1
+253: 1
+254: 1
+255: 1
 

milli/src/search/facet/snapshots/facet_distribution_iter.rs/filter_distribution_all/1.snap

@@ -96,5 +96,10 @@ source: milli/src/search/facet/facet_distribution_iter.rs
 216: 1
 219: 1
 220: 1
+223: 1
 226: 1
+235: 1
+236: 1
+238: 1
+243: 1
 

milli/src/search/facet/snapshots/facet_distribution_iter.rs/filter_distribution_all_stop_early/1.snap

@@ -96,5 +96,9 @@ source: milli/src/search/facet/facet_distribution_iter.rs
 216: 1
 219: 1
 220: 1
+223: 1
 226: 1
+235: 1
+236: 1
+238: 1
 

milli/src/search/facet/snapshots/facet_distribution_iter.rs/random_looking_index_snap/random_looking_index_snap.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_distribution_iter.rs
 ---
-ea4022977d09c7854c833146276348de
+3256c76a7c1b768a013e78d5fa6e9ff9

milli/src/search/facet/snapshots/facet_range_search.rs/filter_range_decreasing/0.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_range_search.rs
 ---
-52d0b31f312572c10959418434e36581
+fcedc563a82c1c61f50174a5f3f982b6

milli/src/search/facet/snapshots/facet_range_search.rs/filter_range_decreasing/1.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_range_search.rs
 ---
-2cb9e819529823d488e141edb4307f97
+6cc26e77fc6bd9145deedf14cf422b03

milli/src/search/facet/snapshots/facet_range_search.rs/filter_range_increasing/0.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_range_search.rs
 ---
-38a4352c48905f5b121d1217734862da
+c1c7a0bb91d53d33724583b6d4a99f16

milli/src/search/facet/snapshots/facet_range_search.rs/filter_range_increasing/1.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_range_search.rs
 ---
-aefc1ec120fa884cc8396a68bd7de42f
+12213d3f1047a0c3d08e4670a7d688e7

milli/src/search/facet/snapshots/facet_range_search.rs/filter_range_pinch/0.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_range_search.rs
 ---
-9e360d7bcd29ac2c23bc241df941fd23
+3456db9a1bb94c33c1e9f656184ee711

milli/src/search/facet/snapshots/facet_range_search.rs/filter_range_pinch/1.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_range_search.rs
 ---
-f0606b9af67de9ede9d469514ea1741f
+2127cd818b457e0611e0c8e1a871602a

milli/src/search/facet/snapshots/facet_range_search.rs/random_looking_index_snap/random_looking_index_snap.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_range_search.rs
 ---
-ea4022977d09c7854c833146276348de
+3256c76a7c1b768a013e78d5fa6e9ff9

milli/src/search/facet/snapshots/facet_sort_ascending.rs/filter_sort/0.snap

@@ -25,4 +25,36 @@ source: milli/src/search/facet/facet_sort_ascending.rs
 [221, ]
 [222, ]
 [223, ]
+[224, ]
+[225, ]
+[226, ]
+[227, ]
+[228, ]
+[229, ]
+[230, ]
+[231, ]
+[232, ]
+[233, ]
+[234, ]
+[235, ]
+[236, ]
+[237, ]
+[238, ]
+[239, ]
+[240, ]
+[241, ]
+[242, ]
+[243, ]
+[244, ]
+[245, ]
+[246, ]
+[247, ]
+[248, ]
+[249, ]
+[250, ]
+[251, ]
+[252, ]
+[253, ]
+[254, ]
+[255, ]
 

milli/src/search/facet/snapshots/facet_sort_ascending.rs/filter_sort/1.snap

@@ -50,4 +50,5 @@ source: milli/src/search/facet/facet_sort_ascending.rs
 [216, ]
 [220, ]
 [226, ]
+[238, ]
 

milli/src/search/facet/snapshots/facet_sort_ascending.rs/random_looking_index_snap/random_looking_index_snap.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_sort_ascending.rs
 ---
-ea4022977d09c7854c833146276348de
+3256c76a7c1b768a013e78d5fa6e9ff9

milli/src/search/facet/snapshots/facet_sort_descending.rs/filter_sort_descending/0.snap

@@ -1,10 +1,54 @@
 ---
 source: milli/src/search/facet/facet_sort_descending.rs
 ---
+[255, ]
+[254, ]
+[253, ]
+[252, ]
+[251, ]
+[250, ]
+[249, ]
+[248, ]
 [247, ]
 [246, ]
 [245, ]
 [244, ]
+[243, ]
+[242, ]
+[241, ]
+[240, ]
+[239, ]
+[238, ]
+[237, ]
+[236, ]
+[235, ]
+[234, ]
+[233, ]
+[232, ]
+[231, ]
+[230, ]
+[229, ]
+[228, ]
+[227, ]
+[226, ]
+[225, ]
+[224, ]
+[223, ]
+[222, ]
+[221, ]
+[220, ]
+[219, ]
+[218, ]
+[217, ]
+[216, ]
+[215, ]
+[214, ]
+[213, ]
+[212, ]
+[211, ]
+[210, ]
+[209, ]
+[208, ]
 [207, ]
 [206, ]
 [205, ]

milli/src/search/facet/snapshots/facet_sort_descending.rs/filter_sort_descending/1.snap

@@ -2,8 +2,15 @@
 source: milli/src/search/facet/facet_sort_descending.rs
 ---
 [243, ]
+[238, ]
+[236, ]
 [235, ]
 [226, ]
+[223, ]
+[220, ]
+[219, ]
+[216, ]
+[210, ]
 [209, ]
 [208, ]
 [207, ]
@@ -35,12 +42,10 @@ source: milli/src/search/facet/facet_sort_descending.rs
 [241, ]
 [239, ]
 [237, ]
-[236, ]
 [233, ]
 [231, ]
 [230, ]
 [224, ]
-[223, ]
 [215, ]
 [211, ]
 [203, ]

milli/src/search/facet/snapshots/facet_sort_descending.rs/random_looking_index_snap/random_looking_index_snap.hash.snap

@@ -1,4 +1,4 @@
 ---
 source: milli/src/search/facet/facet_sort_descending.rs
 ---
-ea4022977d09c7854c833146276348de
+3256c76a7c1b768a013e78d5fa6e9ff9