increase rust version from 1.85 to 1.89

crates/milli/src/search/facet/facet_distribution_iter.rs

@@ -38,7 +38,7 @@ where
     let highest_level = get_highest_level(rtxn, db, field_id)?;
 
     if let Some(first_bound) = get_first_facet_value::<BytesRefCodec, _>(rtxn, db, field_id)? {
-        fd.iterate(candidates, highest_level, first_bound, usize::MAX)?;
+        let _ = fd.iterate(candidates, highest_level, first_bound, usize::MAX)?;
         Ok(())
     } else {
         Ok(())

crates/milli/src/search/facet/filter.rs

@@ -225,11 +225,11 @@ impl<'a> Filter<'a> {
         Ok(Some(Self { condition }))
     }
 
-    pub fn use_contains_operator(&self) -> Option<&Token> {
+    pub fn use_contains_operator(&self) -> Option<&Token<'_>> {
         self.condition.use_contains_operator()
     }
 
-    pub fn use_vector_filter(&self) -> Option<&Token> {
+    pub fn use_vector_filter(&self) -> Option<&Token<'_>> {
         self.condition.use_vector_filter()
     }
 }

crates/milli/src/search/facet/search.rs

@@ -137,7 +137,7 @@ impl<'a> SearchForFacetValues<'a> {
                     let exact_words_fst = self.search_query.index.exact_words(rtxn)?;
                     if exact_words_fst.is_some_and(|fst| fst.contains(query)) {
                         if fst.contains(query) {
-                            self.fetch_original_facets_using_normalized(
+                            let _ = self.fetch_original_facets_using_normalized(
                                 fid,
                                 query,
                                 query,

crates/milli/src/search/new/bucket_sort.rs

@@ -354,15 +354,14 @@ fn maybe_add_to_results<'ctx, Q: RankingRuleQueryTrait>(
             logger.add_to_results(&candidates);
             valid_docids.extend_from_slice(&candidates);
             valid_scores
-                .extend(std::iter::repeat(ranking_rule_scores.to_owned()).take(candidates.len()));
+                .extend(std::iter::repeat_n(ranking_rule_scores.to_owned(), candidates.len()));
         }
     } else {
         // if we have passed the offset already, add some of the documents (up to the limit)
         let candidates = candidates.iter().take(length - valid_docids.len()).collect::<Vec<u32>>();
         logger.add_to_results(&candidates);
         valid_docids.extend_from_slice(&candidates);
-        valid_scores
-            .extend(std::iter::repeat(ranking_rule_scores.to_owned()).take(candidates.len()));
+        valid_scores.extend(std::iter::repeat_n(ranking_rule_scores.to_owned(), candidates.len()));
     }
 
     *cur_offset += candidates.len() as usize;

crates/milli/src/search/new/ranking_rule_graph/cheapest_paths.rs

@@ -193,6 +193,7 @@ impl<G: RankingRuleGraphTrait> VisitorState<G> {
         visit: VisitFn<'_, G>,
         ctx: &mut VisitorContext<'_, G>,
     ) -> Result<ControlFlow<(), bool>> {
+        #[allow(clippy::manual_contains)] // there is no method contains on mapped interner
         if !ctx
             .all_costs_from_node
             .get(dest_node)
@@ -243,6 +244,8 @@ impl<G: RankingRuleGraphTrait> VisitorState<G> {
 
         // Checking that from the destination node, there is at least
         // one cost that we can visit that corresponds to our remaining budget.
+
+        #[allow(clippy::manual_contains)] // there is no contains on MappedInterner
         if !ctx
             .all_costs_from_node
             .get(dest_node)

crates/milli/src/search/new/small_bitmap.rs

@@ -401,7 +401,7 @@ impl Iterator for SmallBitmapInternalIter<'_> {
                     *cur &= *cur - 1;
                     Some(idx + *base)
                 } else if next.is_empty() {
-                    return None;
+                    None
                 } else {
                     *base += 64;
                     *cur = next[0];

crates/milli/src/search/new/sort.rs

@@ -79,7 +79,7 @@ impl<'ctx, Query> Sort<'ctx, Query> {
             return Ok(false);
         };
 
-        Ok(!displayed_fields.iter().any(|&field| field == field_name))
+        Ok(!displayed_fields.contains(&field_name))
     }
 }