snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-10-11 14:16:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefix Redis keys to avoid false negative excessive writes

Browse Source
This commit is contained in:
Clément Renault
2024-07-18 15:55:37 +02:00
parent 0e08906fcb
commit 16b4545d23
9 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
milli/src/update/index_documents/cache.rs
View File

@@ -11,6 +11,7 @@ use crate::CboRoaringBitmapCodec;
pub struct SorterCacheDelAddCboRoaringBitmap<const N: usize, MF> {
cache: LruCache<SmallVec<[u8; N]>, DelAddRoaringBitmap>,
prefix: &'static [u8; 3],
sorter: grenad::Sorter<MF>,
deladd_buffer: Vec<u8>,
cbo_buffer: Vec<u8>,
@@ -18,9 +19,15 @@ pub struct SorterCacheDelAddCboRoaringBitmap<const N: usize, MF> {
}
impl<const N: usize, MF> SorterCacheDelAddCboRoaringBitmap<N, MF> {
pub fn new(cap: NonZeroUsize, sorter: grenad::Sorter<MF>, conn: redis::Connection) -> Self {
pub fn new(
cap: NonZeroUsize,
sorter: grenad::Sorter<MF>,
prefix: &'static [u8; 3],
conn: redis::Connection,
) -> Self {
SorterCacheDelAddCboRoaringBitmap {
cache: LruCache::new(cap),
prefix,
sorter,
deladd_buffer: Vec::new(),
cbo_buffer: Vec::new(),
@@ -136,7 +143,10 @@ where
}
DelAddRoaringBitmap { del: None, add: None } => return Ok(()),
}
redis::cmd("INCR").arg(key.as_ref()).query::<usize>(&mut self.conn).unwrap();
self.cbo_buffer.clear();
self.cbo_buffer.extend_from_slice(self.prefix);
self.cbo_buffer.extend_from_slice(&key);
redis::cmd("INCR").arg(&self.cbo_buffer).query::<usize>(&mut self.conn).unwrap();
self.sorter.insert(key, value_writer.into_inner().unwrap())
}