snowykami/meilisearch
1
0
Fork 0
mirror of https://github.com/meilisearch/meilisearch.git synced 2025-07-28 01:01:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't sort in parallel in sorters of the new indexer

Browse Source
This commit is contained in:
Louis Dureuil
2024-10-17 09:30:18 +02:00
parent 0647f75e6b
commit 0749633618
15 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
milli/src/update/new/extract/faceted/extract_facets.rs
View File

@ -46,6 +46,10 @@ impl<'extractor> Extractor<'extractor> for FacetedExtractorData<'extractor> {
self.grenad_parameters.chunk_compression_level,
self.grenad_parameters.max_nb_chunks,
self.max_memory,
// *NOTE*: this must not be set to true:
// 1. we're already using max parallelism in the pool, so it wouldn't help
// 2. it creates correctness issues if it causes to yield a borrow-mut wielding task
false,
),
))))
}

5
milli/src/update/new/extract/searchable/extract_word_docids.rs
View File

@ -48,6 +48,7 @@ impl WordDocidsCachedSorters {
indexer.chunk_compression_level,
indexer.max_nb_chunks,
max_memory,
false,
),
);
let word_docids = CboCachedSorter::new(
@ -59,6 +60,7 @@ impl WordDocidsCachedSorters {
indexer.chunk_compression_level,
indexer.max_nb_chunks,
max_memory,
false,
),
);
let exact_word_docids = CboCachedSorter::new(
@ -70,6 +72,7 @@ impl WordDocidsCachedSorters {
indexer.chunk_compression_level,
indexer.max_nb_chunks,
max_memory,
false,
),
);
let word_position_docids = CboCachedSorter::new(
@ -81,6 +84,7 @@ impl WordDocidsCachedSorters {
indexer.chunk_compression_level,
indexer.max_nb_chunks,
max_memory,
false,
),
);
let fid_word_count_docids = CboCachedSorter::new(
@ -92,6 +96,7 @@ impl WordDocidsCachedSorters {
indexer.chunk_compression_level,
indexer.max_nb_chunks,
max_memory,
false,
),
);

1
milli/src/update/new/extract/searchable/mod.rs
View File

@ -50,6 +50,7 @@ impl<'extractor, EX: SearchableExtractor + Sync> Extractor<'extractor>
self.grenad_parameters.chunk_compression_level,
self.grenad_parameters.max_nb_chunks,
self.max_memory,
false,
),
))))
}