actions/setup-helm
1
0
Fork 0
mirror of https://github.com/Azure/setup-helm.git synced 2026-08-03 17:04:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: preserve subpath base URLs in getHelmDownloadURL (#292)

Browse Source 
Ensure downloadBaseURL ends with '/' before URL resolution so a subpath
mirror (e.g. https://example/kubernetes/helm) is preserved instead of having
its last path segment replaced. Fixes downloads for all subpath mirrors.
This commit is contained in:
Ogheneobukome Ejaife
2026-07-15 12:45:05 -07:00
committed by GitHub
parent 017211e1b1
commit eb399fcd4f
2 changed files with 33 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/run.ts
+5 -1
View File
@@ -139,7 +139,11 @@ export function getExecutableExtension(): string {
export function getHelmDownloadURL(baseURL: string, version: string): string {
const urlPath = `helm-${version}-${getPlatform()}-${getArch()}.${getArchiveExtension()}`
const url = new URL(urlPath, baseURL)
// Ensure the base ends with '/' so a subpath mirror (e.g.
// 'https://example/kubernetes/helm') is preserved; otherwise URL resolution
// replaces the last path segment and points at the wrong location.
const base = baseURL.endsWith('/') ? baseURL : `${baseURL}/`
const url = new URL(urlPath, base)
return url.toString()
}