⚡ improve plugin system (#1011)

tests/bad_plugins/bad_plugin.py

@@ -0,0 +1,6 @@
+import nonebot
+
+plugin = nonebot.get_plugin("bad_plugin")
+assert plugin
+
+x = 1 / 0

tests/plugins/_hidden.py

@@ -0,0 +1 @@
+assert False

tests/plugins/export.py

@@ -3,4 +3,4 @@ from nonebot import export
 
 @export()
 def test():
-    ...
+    return "export"

tests/plugins/nested/__init__.py

@@ -0,0 +1,6 @@
+from pathlib import Path
+
+import nonebot
+
+_sub_plugins = set()
+_sub_plugins |= nonebot.load_plugins(str((Path(__file__).parent / "plugins").resolve()))

tests/plugins/require.py

@@ -1,8 +1,7 @@
 from nonebot import require
-from plugins.export import test
-
-from .export import test as test_related
 
 test_require = require("export").test
 
-assert test is test_related and test is test_require, "Export Require Error"
+from plugins.export import test
+
+assert test is test_require and test() == "export", "Export Require Error"

tests/test_plugin/test_get.py

@@ -0,0 +1,39 @@
+from typing import TYPE_CHECKING, Set
+
+import pytest
+from nonebug import App
+
+if TYPE_CHECKING:
+    from nonebot.plugin import Plugin
+
+
+@pytest.mark.asyncio
+async def test_get_plugin(app: App, load_plugin: Set["Plugin"]):
+    import nonebot
+
+    # check simple plugin
+    plugin = nonebot.get_plugin("export")
+    assert plugin
+    assert plugin.module_name == "plugins.export"
+
+    # check sub plugin
+    plugin = nonebot.get_plugin("nested_subplugin")
+    assert plugin
+    assert plugin.module_name == "plugins.nested.plugins.nested_subplugin"
+
+    # check get plugin by module name
+    plugin = nonebot.get_plugin_by_module_name("plugins.nested.utils")
+    assert plugin
+    assert plugin.module_name == "plugins.nested"
+
+
+@pytest.mark.asyncio
+async def test_get_available_plugin(app: App):
+    import nonebot
+    from nonebot.plugin import PluginManager, _managers
+
+    _managers.append(PluginManager(["plugins.export", "plugin.require"]))
+
+    # check get available plugins
+    plugin_names = nonebot.get_available_plugin_names()
+    assert plugin_names == {"export", "require"}

tests/test_plugin/test_load.py

@@ -9,27 +9,40 @@ if TYPE_CHECKING:
 
 
 @pytest.mark.asyncio
-async def test_load_plugin(load_plugin: Set["Plugin"]):
+async def test_load_plugin(app: App, load_plugin: Set["Plugin"]):
     import nonebot
+    from nonebot.plugin import PluginManager
 
-    loaded_plugins = set(
+    loaded_plugins = {
         plugin for plugin in nonebot.get_loaded_plugins() if not plugin.parent_plugin
-    )
+    }
     assert loaded_plugins == load_plugin
-    plugin = nonebot.get_plugin("export")
-    assert plugin
-    assert plugin.module_name == "plugins.export"
+
+    # check simple plugin
     assert "plugins.export" in sys.modules
 
-    try:
-        nonebot.load_plugin("plugins.export")
-        assert False
-    except RuntimeError:
-        assert True
+    # check sub plugin
+    assert "plugins.nested.plugins.nested_subplugin" in sys.modules
 
+    # check load again
+    with pytest.raises(RuntimeError):
+        PluginManager(plugins=["plugins.export"]).load_all_plugins()
+    with pytest.raises(RuntimeError):
+        PluginManager(search_path=["plugins"]).load_all_plugins()
+
+    # check not found
     assert nonebot.load_plugin("some_plugin_not_exist") is None
 
 
+@pytest.mark.asyncio
+async def test_bad_plugin(app: App):
+    import nonebot
+
+    nonebot.load_plugins("bad_plugins")
+
+    assert nonebot.get_plugin("bad_plugins") is None
+
+
 @pytest.mark.asyncio
 async def test_require_loaded(app: App, monkeypatch: pytest.MonkeyPatch):
     import nonebot
@@ -47,8 +60,7 @@ async def test_require_loaded(app: App, monkeypatch: pytest.MonkeyPatch):
 @pytest.mark.asyncio
 async def test_require_not_loaded(app: App, monkeypatch: pytest.MonkeyPatch):
     import nonebot
-    from nonebot.plugin import _managers
-    from nonebot.plugin.manager import PluginManager
+    from nonebot.plugin import PluginManager, _managers
 
     m = PluginManager(["plugins.export"])
     _managers.append(m)
@@ -80,10 +92,6 @@ async def test_require_not_declared(app: App):
 @pytest.mark.asyncio
 async def test_require_not_found(app: App):
     import nonebot
-    from nonebot.plugin import _managers
 
-    try:
+    with pytest.raises(RuntimeError):
         nonebot.require("some_plugin_not_exist")
-        assert False
-    except RuntimeError:
-        assert True

tests/test_plugin/test_manager.py

@@ -0,0 +1,12 @@
+import pytest
+from nonebug import App
+
+
+@pytest.mark.asyncio
+async def test_load_plugin_name(app: App):
+    from nonebot.plugin import PluginManager
+
+    m = PluginManager(plugins=["plugins.export"])
+    module1 = m.load_plugin("export")
+    module2 = m.load_plugin("plugins.export")
+    assert module1 is module2