More error logs

updated tempfile and put some hopeful log
Merge #2084
2025-12-08 21:55:42 +00:00 · 2023-04-18 19:36:58 +02:00 · 2023-04-18 19:18:15 +02:00 · 2022-01-18 14:30:37 +00:00 · 2022-01-18 12:27:15 +01:00 · 2022-01-18 11:50:17 +01:00
33 changed files with 653 additions and 193 deletions
--- a/.github/workflows/publish-docker-latest.yml
+++ b/.github/workflows/publish-docker-latest.yml
@@ -7,7 +7,7 @@ name: Publish latest image to Docker Hub

 jobs:
  docker-latest:
-    runs-on: self-hosted
+    runs-on: docker
    steps:
      - name: Set up QEMU
        uses: docker/setup-qemu-action@v1
--- a/.github/workflows/publish-docker-tag.yml
+++ b/.github/workflows/publish-docker-tag.yml
@@ -8,7 +8,7 @@ name: Publish tagged image to Docker Hub

 jobs:
  docker-tag:
-    runs-on: self-hosted
+    runs-on: docker
    steps:
      - name: Set up QEMU
        uses: docker/setup-qemu-action@v1
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -11,6 +11,7 @@ on:

 env:
  CARGO_TERM_COLOR: always
+  RUST_BACKTRACE: 1

 jobs:
  tests:
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -362,7 +362,7 @@ version = "0.2.14"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "d9b39be18770d11421cdb1b9947a45dd3f37e93092cbf377614828a319d5fee8"
 dependencies = [
- "hermit-abi",
+ "hermit-abi 0.1.19",
 "libc",
 "winapi",
 ]
@@ -927,6 +927,36 @@ dependencies = [
 "termcolor",
 ]

+[[package]]
+name = "errno"
+version = "0.3.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "4bcfec3a70f97c962c307b2d2c56e358cf1d00b558d74262b5f929ee8cc7e73a"
+dependencies = [
+ "errno-dragonfly",
+ "libc",
+ "windows-sys 0.48.0",
+]
+
+[[package]]
+name = "errno-dragonfly"
+version = "0.1.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "aa68f1b12764fab894d2755d2518754e71b4fd80ecfb822714a1206c2aab39bf"
+dependencies = [
+ "cc",
+ "libc",
+]
+
+[[package]]
+name = "fastrand"
+version = "1.9.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "e51093e27b0797c359783294ca4f0a911c270184cb10f85783b118614a1501be"
+dependencies = [
+ "instant",
+]
+
 [[package]]
 name = "filetime"
 version = "0.2.15"
@@ -935,14 +965,14 @@ checksum = "975ccf83d8d9d0d84682850a38c8169027be83368805971cc4f238c2b245bc98"
 dependencies = [
 "cfg-if 1.0.0",
 "libc",
- "redox_syscall",
+ "redox_syscall 0.2.10",
 "winapi",
 ]

 [[package]]
 name = "filter-parser"
 version = "0.1.0"
-source = "git+https://github.com/meilisearch/milli.git?tag=v0.21.0#c83b77304a3062bdbb5b2a3503a710711caebdea"
+source = "git+https://github.com/meilisearch/milli.git?tag=v0.21.1#7f50ca9a20090fc4fe2abae0394c1e6fdd351ebd"
 dependencies = [
 "nom",
 "nom_locate",
@@ -1309,6 +1339,12 @@ dependencies = [
 "libc",
 ]

+[[package]]
+name = "hermit-abi"
+version = "0.3.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "fed44880c466736ef9a5c5b5facefb5ed0785676d0c02d612db14e54f0d84286"
+
 [[package]]
 name = "hex"
 version = "0.4.3"
@@ -1431,6 +1467,17 @@ dependencies = [
 "cfg-if 1.0.0",
 ]

+[[package]]
+name = "io-lifetimes"
+version = "1.0.10"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "9c66c74d2ae7e79a5a8f7ac924adbe38ee42a859c6539ad869eb51f0b52dc220"
+dependencies = [
+ "hermit-abi 0.3.1",
+ "libc",
+ "windows-sys 0.48.0",
+]
+
 [[package]]
 name = "ipnet"
 version = "2.3.1"
@@ -1508,9 +1555,9 @@ dependencies = [

 [[package]]
 name = "libc"
-version = "0.2.108"
+version = "0.2.141"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8521a1b57e76b1ec69af7599e75e38e7b7fad6610f037db8c79b127201b5d119"
+checksum = "3304a64d199bb964be99741b7a14d26972741915b3649639149b2479bb46f4b5"

 [[package]]
 name = "libgit2-sys"
@@ -1542,6 +1589,12 @@ version = "0.5.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "7fb9b38af92608140b86b693604b9ffcc5824240a484d1ecd4795bacb2fe88f3"

+[[package]]
+name = "linux-raw-sys"
+version = "0.3.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "3f508063cc7bb32987c71511216bd5a32be15bccb6a80b52df8b9d7f01fc3aa2"
+
 [[package]]
 name = "lmdb-rkv-sys"
 version = "0.15.0"
@@ -1639,7 +1692,7 @@ dependencies = [

 [[package]]
 name = "meilisearch-error"
-version = "0.25.0"
+version = "0.25.2"
 dependencies = [
 "actix-http",
 "actix-web",
@@ -1651,7 +1704,7 @@ dependencies = [

 [[package]]
 name = "meilisearch-http"
-version = "0.25.0"
+version = "0.25.2"
 dependencies = [
 "actix-cors",
 "actix-rt",
@@ -1723,7 +1776,7 @@ dependencies = [

 [[package]]
 name = "meilisearch-lib"
-version = "0.25.0"
+version = "0.25.2"
 dependencies = [
 "actix-rt",
 "actix-web",
@@ -1825,8 +1878,8 @@ dependencies = [

 [[package]]
 name = "milli"
-version = "0.21.0"
-source = "git+https://github.com/meilisearch/milli.git?tag=v0.21.0#c83b77304a3062bdbb5b2a3503a710711caebdea"
+version = "0.21.1"
+source = "git+https://github.com/meilisearch/milli.git?tag=v0.21.1#7f50ca9a20090fc4fe2abae0394c1e6fdd351ebd"
 dependencies = [
 "bimap",
 "bincode",
@@ -2015,7 +2068,7 @@ version = "1.13.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "05499f3756671c15885fee9034446956fff3f243d6077b91e5767df161f766b3"
 dependencies = [
- "hermit-abi",
+ "hermit-abi 0.1.19",
 "libc",
 ]

@@ -2085,7 +2138,7 @@ dependencies = [
 "cfg-if 1.0.0",
 "instant",
 "libc",
- "redox_syscall",
+ "redox_syscall 0.2.10",
 "smallvec",
 "winapi",
 ]
@@ -2435,6 +2488,15 @@ dependencies = [
 "bitflags",
 ]

+[[package]]
+name = "redox_syscall"
+version = "0.3.5"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "567664f262709473930a4bf9e51bf2ebf3348f2e748ccc50dea20646858f8f29"
+dependencies = [
+ "bitflags",
+]
+
 [[package]]
 name = "redox_users"
 version = "0.4.0"
@@ -2442,7 +2504,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "528532f3d801c87aec9def2add9ca802fe569e44a544afe633765267840abe64"
 dependencies = [
 "getrandom",
- "redox_syscall",
+ "redox_syscall 0.2.10",
 ]

 [[package]]
@@ -2468,15 +2530,6 @@ version = "0.6.25"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "f497285884f3fcff424ffc933e56d7cbca511def0c9831a7f9b5f6153e3cc89b"

-[[package]]
-name = "remove_dir_all"
-version = "0.5.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3acd125665422973a33ac9d3dd2df85edad0f4ae9b00dafb1a05e43a9f5ef8e7"
-dependencies = [
- "winapi",
-]
-
 [[package]]
 name = "reqwest"
 version = "0.11.6"
@@ -2582,6 +2635,20 @@ dependencies = [
 "semver 1.0.4",
 ]

+[[package]]
+name = "rustix"
+version = "0.37.11"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "85597d61f83914ddeba6a47b3b8ffe7365107221c2e557ed94426489fefb5f77"
+dependencies = [
+ "bitflags",
+ "errno",
+ "io-lifetimes",
+ "libc",
+ "linux-raw-sys",
+ "windows-sys 0.48.0",
+]
+
 [[package]]
 name = "rustls"
 version = "0.19.1"
@@ -2989,16 +3056,15 @@ dependencies = [

 [[package]]
 name = "tempfile"
-version = "3.2.0"
+version = "3.5.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "dac1c663cfc93810f88aed9b8941d48cabf856a1b111c29a40439018d870eb22"
+checksum = "b9fbec84f381d5795b08656e4912bec604d162bff9291d6189a78f4c8ab87998"
 dependencies = [
 "cfg-if 1.0.0",
- "libc",
- "rand",
- "redox_syscall",
- "remove_dir_all",
- "winapi",
+ "fastrand",
+ "redox_syscall 0.3.5",
+ "rustix",
+ "windows-sys 0.45.0",
 ]

 [[package]]
@@ -3547,6 +3613,138 @@ version = "0.4.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "712e227841d057c1ee1cd2fb22fa7e5a5461ae8e48fa2ca79ec42cfc1931183f"

+[[package]]
+name = "windows-sys"
+version = "0.45.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "75283be5efb2831d37ea142365f009c02ec203cd29a3ebecbc093d52315b66d0"
+dependencies = [
+ "windows-targets 0.42.2",
+]
+
+[[package]]
+name = "windows-sys"
+version = "0.48.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "677d2418bec65e3338edb076e806bc1ec15693c5d0104683f2efe857f61056a9"
+dependencies = [
+ "windows-targets 0.48.0",
+]
+
+[[package]]
+name = "windows-targets"
+version = "0.42.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "8e5180c00cd44c9b1c88adb3693291f1cd93605ded80c250a75d472756b4d071"
+dependencies = [
+ "windows_aarch64_gnullvm 0.42.2",
+ "windows_aarch64_msvc 0.42.2",
+ "windows_i686_gnu 0.42.2",
+ "windows_i686_msvc 0.42.2",
+ "windows_x86_64_gnu 0.42.2",
+ "windows_x86_64_gnullvm 0.42.2",
+ "windows_x86_64_msvc 0.42.2",
+]
+
+[[package]]
+name = "windows-targets"
+version = "0.48.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "7b1eb6f0cd7c80c79759c929114ef071b87354ce476d9d94271031c0497adfd5"
+dependencies = [
+ "windows_aarch64_gnullvm 0.48.0",
+ "windows_aarch64_msvc 0.48.0",
+ "windows_i686_gnu 0.48.0",
+ "windows_i686_msvc 0.48.0",
+ "windows_x86_64_gnu 0.48.0",
+ "windows_x86_64_gnullvm 0.48.0",
+ "windows_x86_64_msvc 0.48.0",
+]
+
+[[package]]
+name = "windows_aarch64_gnullvm"
+version = "0.42.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "597a5118570b68bc08d8d59125332c54f1ba9d9adeedeef5b99b02ba2b0698f8"
+
+[[package]]
+name = "windows_aarch64_gnullvm"
+version = "0.48.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "91ae572e1b79dba883e0d315474df7305d12f569b400fcf90581b06062f7e1bc"
+
+[[package]]
+name = "windows_aarch64_msvc"
+version = "0.42.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "e08e8864a60f06ef0d0ff4ba04124db8b0fb3be5776a5cd47641e942e58c4d43"
+
+[[package]]
+name = "windows_aarch64_msvc"
+version = "0.48.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "b2ef27e0d7bdfcfc7b868b317c1d32c641a6fe4629c171b8928c7b08d98d7cf3"
+
+[[package]]
+name = "windows_i686_gnu"
+version = "0.42.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c61d927d8da41da96a81f029489353e68739737d3beca43145c8afec9a31a84f"
+
+[[package]]
+name = "windows_i686_gnu"
+version = "0.48.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "622a1962a7db830d6fd0a69683c80a18fda201879f0f447f065a3b7467daa241"
+
+[[package]]
+name = "windows_i686_msvc"
+version = "0.42.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "44d840b6ec649f480a41c8d80f9c65108b92d89345dd94027bfe06ac444d1060"
+
+[[package]]
+name = "windows_i686_msvc"
+version = "0.48.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "4542c6e364ce21bf45d69fdd2a8e455fa38d316158cfd43b3ac1c5b1b19f8e00"
+
+[[package]]
+name = "windows_x86_64_gnu"
+version = "0.42.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "8de912b8b8feb55c064867cf047dda097f92d51efad5b491dfb98f6bbb70cb36"
+
+[[package]]
+name = "windows_x86_64_gnu"
+version = "0.48.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "ca2b8a661f7628cbd23440e50b05d705db3686f894fc9580820623656af974b1"
+
+[[package]]
+name = "windows_x86_64_gnullvm"
+version = "0.42.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "26d41b46a36d453748aedef1486d5c7a85db22e56aff34643984ea85514e94a3"
+
+[[package]]
+name = "windows_x86_64_gnullvm"
+version = "0.48.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "7896dbc1f41e08872e9d5e8f8baa8fdd2677f29468c4e156210174edc7f7b953"
+
+[[package]]
+name = "windows_x86_64_msvc"
+version = "0.42.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "9aec5da331524158c6d1a4ac0ab1541149c0b9505fde06423b02f5ef0106b9f0"
+
+[[package]]
+name = "windows_x86_64_msvc"
+version = "0.48.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1a515f5799fe4961cb532f983ce2b23082366b898e52ffbce459c86f67c8378a"
+
 [[package]]
 name = "winreg"
 version = "0.7.0"
--- a/10
+++ b/10
@@ -35,18 +35,12 @@ RUN     $HOME/.cargo/bin/cargo build --release
 # Run
 FROM    alpine:3.14

-ARG     USER=meili
-ENV     HOME /home/${USER}
 ENV     MEILI_HTTP_ADDR 0.0.0.0:7700
 ENV     MEILI_SERVER_PROVIDER docker

-# download runtime deps as root and create ${USER}
 RUN     apk update --quiet \
-        && apk add -q --no-cache libgcc tini curl \
-        && adduser -D ${USER}
-WORKDIR ${HOME}
-USER    ${USER}
-# copy file as ${USER} to ${HOME}
+        && apk add -q --no-cache libgcc tini curl
+
 COPY    --from=compiler /meilisearch/target/release/meilisearch .

 EXPOSE  7700/tcp
--- a/meilisearch-auth/src/dump.rs
+++ b/meilisearch-auth/src/dump.rs
@@ -29,6 +29,10 @@ impl AuthController {

        let keys_file_path = src.as_ref().join(KEYS_PATH);

+        if !keys_file_path.exists() {
+            return Ok(());
+        }
+
        let mut reader = BufReader::new(File::open(&keys_file_path)?).lines();
        while let Some(key) = reader.next().transpose()? {
            let key = serde_json::from_str(&key)?;
--- a/meilisearch-auth/src/key.rs
+++ b/meilisearch-auth/src/key.rs
@@ -1,7 +1,7 @@
 use crate::action::Action;
 use crate::error::{AuthControllerError, Result};
 use crate::store::{KeyId, KEY_ID_LENGTH};
-use chrono::{DateTime, NaiveDateTime, Utc};
+use chrono::{DateTime, NaiveDate, NaiveDateTime, Utc};
 use rand::Rng;
 use serde::{Deserialize, Serialize};
 use serde_json::{from_value, Value};
@@ -142,8 +142,8 @@ fn parse_expiration_date(value: &Value) -> Result<Option<DateTime<Utc>>> {
                    .map(|naive| DateTime::from_utc(naive, Utc))
            })
            .or_else(|_| {
-                NaiveDateTime::parse_from_str(string, "%Y-%m-%d")
-                    .map(|naive| DateTime::from_utc(naive, Utc))
+                NaiveDate::parse_from_str(string, "%Y-%m-%d")
+                    .map(|naive| DateTime::from_utc(naive.and_hms(0, 0, 0), Utc))
            })
            .map_err(|_| AuthControllerError::InvalidApiKeyExpiresAt(value.clone()))
            // check if the key is already expired.
--- a/meilisearch-auth/src/lib.rs
+++ b/meilisearch-auth/src/lib.rs
@@ -69,6 +69,11 @@ impl AuthController {
            if !key.indexes.iter().any(|i| i.as_str() == "*") {
                filters.indexes = Some(key.indexes);
            }
+
+            filters.allow_index_creation = key
+                .actions
+                .iter()
+                .any(|&action| action == Action::IndexesAdd || action == Action::All);
        }

        Ok(filters)
@@ -118,9 +123,18 @@ impl AuthController {
    }
 }

-#[derive(Default)]
 pub struct AuthFilter {
    pub indexes: Option<Vec<String>>,
+    pub allow_index_creation: bool,
+}
+
+impl Default for AuthFilter {
+    fn default() -> Self {
+        Self {
+            indexes: None,
+            allow_index_creation: true,
+        }
+    }
 }

 pub fn generate_key(master_key: &[u8], uid: &str) -> String {
--- a/meilisearch-error/Cargo.toml
+++ b/meilisearch-error/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "meilisearch-error"
-version = "0.25.0"
+version = "0.25.2"
 authors = ["marin <postma.marin@protonmail.com>"]
 edition = "2018"

--- a/meilisearch-http/Cargo.toml
+++ b/meilisearch-http/Cargo.toml
@@ -4,7 +4,7 @@ description = "MeiliSearch HTTP server"
 edition = "2018"
 license = "MIT"
 name = "meilisearch-http"
-version = "0.25.0"
+version = "0.25.2"

 [[bin]]
 name = "meilisearch"
@@ -103,5 +103,5 @@ default = ["analytics", "mini-dashboard"]
 tikv-jemallocator = "0.4.1"

 [package.metadata.mini-dashboard]
-assets-url = "https://github.com/meilisearch/mini-dashboard/releases/download/v0.1.5/build.zip"
-sha1 = "1d955ea91b7691bd6fc207cb39866b82210783f0"
+assets-url = "https://github.com/meilisearch/mini-dashboard/releases/download/v0.1.7/build.zip"
+sha1 = "e2feedf271917c4b7b88998eff5aaaea1d3925b9"
--- a/meilisearch-http/src/analytics/segment_analytics.rs
+++ b/meilisearch-http/src/analytics/segment_analytics.rs
@@ -77,7 +77,7 @@ impl SegmentAnalytics {
        let user = User::UserId { user_id };
        let mut batcher = AutoBatcher::new(client, Batcher::new(None), SEGMENT_API_KEY.to_string());

-        // If Meilisearch is Launched for the first time:
+        // If MeiliSearch is Launched for the first time:
        // 1. Send an event Launched associated to the user `total_launch`.
        // 2. Batch an event Launched with the real instance-id and send it in one hour.
        if first_time_run {
--- a/meilisearch-http/src/lib.rs
+++ b/meilisearch-http/src/lib.rs
@@ -143,6 +143,7 @@ macro_rules! create_app {
            .wrap(
                Cors::default()
                    .send_wildcard()
+                    .allow_any_header()
                    .allow_any_origin()
                    .allow_any_method()
                    .max_age(86_400), // 24h
--- a/meilisearch-http/src/routes/api_key.rs
+++ b/meilisearch-http/src/routes/api_key.rs
@@ -2,7 +2,7 @@ use std::str;

 use actix_web::{web, HttpRequest, HttpResponse};
 use chrono::SecondsFormat;
-use log::debug;
+
 use meilisearch_auth::{generate_key, Action, AuthController, Key};
 use serde::{Deserialize, Serialize};
 use serde_json::Value;
@@ -32,7 +32,6 @@ pub async fn create_api_key(
    let key = auth_controller.create_key(body.into_inner()).await?;
    let res = KeyView::from_key(key, auth_controller.get_master_key());

-    debug!("returns: {:?}", res);
    Ok(HttpResponse::Created().json(res))
 }

@@ -46,8 +45,7 @@ pub async fn list_api_keys(
        .map(|k| KeyView::from_key(k, auth_controller.get_master_key()))
        .collect();

-    debug!("returns: {:?}", res);
-    Ok(HttpResponse::Ok().json(res))
+    Ok(HttpResponse::Ok().json(KeyListView::from(res)))
 }

 pub async fn get_api_key(
@@ -58,7 +56,6 @@ pub async fn get_api_key(
    let key = auth_controller.get_key(&path.api_key).await?;
    let res = KeyView::from_key(key, auth_controller.get_master_key());

-    debug!("returns: {:?}", res);
    Ok(HttpResponse::Ok().json(res))
 }

@@ -73,7 +70,6 @@ pub async fn patch_api_key(
        .await?;
    let res = KeyView::from_key(key, auth_controller.get_master_key());

-    debug!("returns: {:?}", res);
    Ok(HttpResponse::Ok().json(res))
 }

@@ -125,3 +121,14 @@ impl KeyView {
        }
    }
 }
+
+#[derive(Debug, Serialize)]
+struct KeyListView {
+    results: Vec<KeyView>,
+}
+
+impl From<Vec<KeyView>> for KeyListView {
+    fn from(results: Vec<KeyView>) -> Self {
+        Self { results }
+    }
+}
--- a/meilisearch-http/src/routes/indexes/documents.rs
+++ b/meilisearch-http/src/routes/indexes/documents.rs
@@ -173,6 +173,7 @@ pub async fn add_documents(
        &req,
    );

+    let allow_index_creation = meilisearch.filters().allow_index_creation;
    let task = document_addition(
        extract_mime_type(&req)?,
        meilisearch,
@@ -180,6 +181,7 @@ pub async fn add_documents(
        params.primary_key,
        body,
        IndexDocumentsMethod::ReplaceDocuments,
+        allow_index_creation,
    )
    .await?;

@@ -203,6 +205,7 @@ pub async fn update_documents(
        &req,
    );

+    let allow_index_creation = meilisearch.filters().allow_index_creation;
    let task = document_addition(
        extract_mime_type(&req)?,
        meilisearch,
@@ -210,6 +213,7 @@ pub async fn update_documents(
        params.into_inner().primary_key,
        body,
        IndexDocumentsMethod::UpdateDocuments,
+        allow_index_creation,
    )
    .await?;

@@ -223,6 +227,7 @@ async fn document_addition(
    primary_key: Option<String>,
    body: Payload,
    method: IndexDocumentsMethod,
+    allow_index_creation: bool,
 ) -> Result<SummarizedTaskView, ResponseError> {
    let format = match mime_type
        .as_ref()
@@ -250,6 +255,7 @@ async fn document_addition(
        primary_key,
        method,
        format,
+        allow_index_creation,
    };

    let task = meilisearch.register_update(index_uid, update).await?.into();
--- a/meilisearch-http/src/routes/indexes/settings.rs
+++ b/meilisearch-http/src/routes/indexes/settings.rs
@@ -34,9 +34,12 @@ macro_rules! make_setting_route {
                    $attr: Setting::Reset,
                    ..Default::default()
                };
+
+                let allow_index_creation = meilisearch.filters().allow_index_creation;
                let update = Update::Settings {
                    settings,
                    is_deletion: true,
+                    allow_index_creation,
                };
                let task: SummarizedTaskView = meilisearch
                    .register_update(index_uid.into_inner(), update)
@@ -66,9 +69,11 @@ macro_rules! make_setting_route {
                    ..Default::default()
                };

+                let allow_index_creation = meilisearch.filters().allow_index_creation;
                let update = Update::Settings {
                    settings,
                    is_deletion: false,
+                    allow_index_creation,
                };
                let task: SummarizedTaskView = meilisearch
                    .register_update(index_uid.into_inner(), update)
@@ -272,9 +277,11 @@ pub async fn update_all(
        Some(&req),
    );

+    let allow_index_creation = meilisearch.filters().allow_index_creation;
    let update = Update::Settings {
        settings,
        is_deletion: false,
+        allow_index_creation,
    };
    let task: SummarizedTaskView = meilisearch
        .register_update(index_uid.into_inner(), update)
@@ -300,9 +307,11 @@ pub async fn delete_all(
 ) -> Result<HttpResponse, ResponseError> {
    let settings = Settings::cleared().into_unchecked();

+    let allow_index_creation = data.filters().allow_index_creation;
    let update = Update::Settings {
        settings,
        is_deletion: true,
+        allow_index_creation,
    };
    let task: SummarizedTaskView = data
        .register_update(index_uid.into_inner(), update)
--- a/meilisearch-http/src/routes/mod.rs
+++ b/meilisearch-http/src/routes/mod.rs
@@ -117,7 +117,7 @@ impl IndexUpdateResponse {
 /// Always return a 200 with:
 /// ```json
 /// {
-///     "status": "Meilisearch is running"
+///     "status": "MeiliSearch is running"
 /// }
 /// ```
 pub async fn running() -> HttpResponse {
--- a/meilisearch-http/src/task.rs
+++ b/meilisearch-http/src/task.rs
@@ -215,6 +215,27 @@ impl From<Task> for TaskView {
                (TaskStatus::Succeeded, None, Some(*timestamp))
            }
            TaskEvent::Failed { timestamp, error } => {
+                match details {
+                    Some(TaskDetails::DocumentDeletion {
+                        ref mut deleted_documents,
+                        ..
+                    }) => {
+                        deleted_documents.replace(0);
+                    }
+                    Some(TaskDetails::ClearAll {
+                        ref mut deleted_documents,
+                        ..
+                    }) => {
+                        deleted_documents.replace(0);
+                    }
+                    Some(TaskDetails::DocumentAddition {
+                        ref mut indexed_documents,
+                        ..
+                    }) => {
+                        indexed_documents.replace(0);
+                    }
+                    _ => (),
+                }
                (TaskStatus::Failed, Some(error.clone()), Some(*timestamp))
            }
        };
@@ -224,13 +245,13 @@ impl From<Task> for TaskView {
            _ => unreachable!("A task must always have a creation event."),
        };

-        let duration = finished_at.map(|ts| (ts - enqueued_at));
-
        let started_at = events.iter().find_map(|e| match e {
            TaskEvent::Processing(ts) => Some(*ts),
            _ => None,
        });

+        let duration = finished_at.zip(started_at).map(|(tf, ts)| (tf - ts));
+
        Self {
            uid: id,
            index_uid: index_uid.into_inner(),
--- a/meilisearch-http/tests/auth/api_keys.rs
+++ b/meilisearch-http/tests/auth/api_keys.rs
@@ -62,6 +62,65 @@ async fn add_valid_api_key() {
    assert_eq!(code, 201);
 }

+#[actix_rt::test]
+async fn add_valid_api_key_expired_at() {
+    let mut server = Server::new_auth().await;
+    server.use_api_key("MASTER_KEY");
+
+    let content = json!({
+        "description": "Indexing API key",
+        "indexes": ["products"],
+        "actions": [
+            "search",
+            "documents.add",
+            "documents.get",
+            "documents.delete",
+            "indexes.create",
+            "indexes.get",
+            "indexes.update",
+            "indexes.delete",
+            "tasks.get",
+            "settings.get",
+            "settings.update",
+            "stats.get",
+            "dumps.create",
+            "dumps.get"
+        ],
+        "expiresAt": "2050-11-13"
+    });
+
+    let (response, code) = server.add_api_key(content).await;
+    assert!(response["key"].is_string(), "{:?}", response);
+    assert!(response["expiresAt"].is_string());
+    assert!(response["createdAt"].is_string());
+    assert!(response["updatedAt"].is_string());
+
+    let expected_response = json!({
+        "description": "Indexing API key",
+        "indexes": ["products"],
+        "actions": [
+            "search",
+            "documents.add",
+            "documents.get",
+            "documents.delete",
+            "indexes.create",
+            "indexes.get",
+            "indexes.update",
+            "indexes.delete",
+            "tasks.get",
+            "settings.get",
+            "settings.update",
+            "stats.get",
+            "dumps.create",
+            "dumps.get"
+        ],
+        "expiresAt": "2050-11-13T00:00:00Z"
+    });
+
+    assert_json_include!(actual: response, expected: expected_response);
+    assert_eq!(code, 201);
+}
+
 #[actix_rt::test]
 async fn add_valid_api_key_no_description() {
    let mut server = Server::new_auth().await;
@@ -512,40 +571,42 @@ async fn list_api_keys() {

    let (response, code) = server.list_api_keys().await;

-    let expected_response = json!([
-    {
-        "description": "Indexing API key",
-        "indexes": ["products"],
-        "actions": [
-            "search",
-            "documents.add",
-            "documents.get",
-            "documents.delete",
-            "indexes.create",
-            "indexes.get",
-            "indexes.update",
-            "indexes.delete",
-            "tasks.get",
-            "settings.get",
-            "settings.update",
-            "stats.get",
-            "dumps.create",
-            "dumps.get"
-        ],
-        "expiresAt": "2050-11-13T00:00:00Z"
-    },
-    {
-        "description": "Default Search API Key (Use it to search from the frontend)",
-        "indexes": ["*"],
-        "actions": ["search"],
-        "expiresAt": serde_json::Value::Null,
-    },
-    {
-        "description": "Default Admin API Key (Use it for all other operations. Caution! Do not use it on a public frontend)",
-        "indexes": ["*"],
-        "actions": ["*"],
-        "expiresAt": serde_json::Value::Null,
-    }]);
+    let expected_response = json!({ "results":
+    [
+        {
+            "description": "Indexing API key",
+            "indexes": ["products"],
+            "actions": [
+                "search",
+                "documents.add",
+                "documents.get",
+                "documents.delete",
+                "indexes.create",
+                "indexes.get",
+                "indexes.update",
+                "indexes.delete",
+                "tasks.get",
+                "settings.get",
+                "settings.update",
+                "stats.get",
+                "dumps.create",
+                "dumps.get"
+            ],
+            "expiresAt": "2050-11-13T00:00:00Z"
+        },
+        {
+            "description": "Default Search API Key (Use it to search from the frontend)",
+            "indexes": ["*"],
+            "actions": ["search"],
+            "expiresAt": serde_json::Value::Null,
+        },
+        {
+            "description": "Default Admin API Key (Use it for all other operations. Caution! Do not use it on a public frontend)",
+            "indexes": ["*"],
+            "actions": ["*"],
+            "expiresAt": serde_json::Value::Null,
+        }
+    ]});

    assert_json_include!(actual: response, expected: expected_response);
    assert_eq!(code, 200);
--- a/meilisearch-http/tests/auth/authorization.rs
+++ b/meilisearch-http/tests/auth/authorization.rs
@@ -496,3 +496,135 @@ async fn list_authorized_tasks_no_index_restriction() {
    // key should have access on `test` index.
    assert!(response.iter().any(|task| task["indexUid"] == "test"));
 }
+
+#[actix_rt::test]
+async fn error_creating_index_without_action() {
+    let mut server = Server::new_auth().await;
+    server.use_api_key("MASTER_KEY");
+
+    // create key with access on all indexes.
+    let content = json!({
+        "indexes": ["*"],
+        "actions": ALL_ACTIONS.iter().cloned().filter(|a| *a != "indexes.create").collect::<Vec<_>>(),
+        "expiresAt": "2050-11-13T00:00:00Z"
+    });
+    let (response, code) = server.add_api_key(content).await;
+    assert_eq!(code, 201);
+    assert!(response["key"].is_string());
+
+    // use created key.
+    let key = response["key"].as_str().unwrap();
+    server.use_api_key(&key);
+
+    let expected_error = json!({
+        "message": "Index `test` not found.",
+        "code": "index_not_found",
+        "type": "invalid_request",
+        "link": "https://docs.meilisearch.com/errors#index_not_found"
+    });
+
+    // try to create a index via add documents route
+    let index = server.index("test");
+    let documents = json!([
+        {
+            "id": 1,
+            "content": "foo",
+        }
+    ]);
+
+    let (response, code) = index.add_documents(documents, None).await;
+    assert_eq!(code, 202, "{:?}", response);
+    let task_id = response["uid"].as_u64().unwrap();
+
+    let response = index.wait_task(task_id).await;
+    assert_eq!(response["status"], "failed");
+    assert_eq!(response["error"], expected_error.clone());
+
+    // try to create a index via add settings route
+    let settings = json!({ "distinctAttribute": "test"});
+
+    let (response, code) = index.update_settings(settings).await;
+    assert_eq!(code, 202);
+    let task_id = response["uid"].as_u64().unwrap();
+
+    let response = index.wait_task(task_id).await;
+
+    assert_eq!(response["status"], "failed");
+    assert_eq!(response["error"], expected_error.clone());
+
+    // try to create a index via add specialized settings route
+    let (response, code) = index.update_distinct_attribute(json!("test")).await;
+    assert_eq!(code, 202);
+    let task_id = response["uid"].as_u64().unwrap();
+
+    let response = index.wait_task(task_id).await;
+
+    assert_eq!(response["status"], "failed");
+    assert_eq!(response["error"], expected_error.clone());
+}
+
+#[actix_rt::test]
+async fn lazy_create_index() {
+    let mut server = Server::new_auth().await;
+    server.use_api_key("MASTER_KEY");
+
+    // create key with access on all indexes.
+    let content = json!({
+        "indexes": ["*"],
+        "actions": ["*"],
+        "expiresAt": "2050-11-13T00:00:00Z"
+    });
+
+    let (response, code) = server.add_api_key(content).await;
+    assert_eq!(code, 201);
+    assert!(response["key"].is_string());
+
+    // use created key.
+    let key = response["key"].as_str().unwrap();
+    server.use_api_key(&key);
+
+    // try to create a index via add documents route
+    let index = server.index("test");
+    let documents = json!([
+        {
+            "id": 1,
+            "content": "foo",
+        }
+    ]);
+
+    let (response, code) = index.add_documents(documents, None).await;
+    assert_eq!(code, 202, "{:?}", response);
+    let task_id = response["uid"].as_u64().unwrap();
+
+    index.wait_task(task_id).await;
+
+    let (response, code) = index.get_task(task_id).await;
+    assert_eq!(code, 200);
+    assert_eq!(response["status"], "succeeded");
+
+    // try to create a index via add settings route
+    let index = server.index("test1");
+    let settings = json!({ "distinctAttribute": "test"});
+
+    let (response, code) = index.update_settings(settings).await;
+    assert_eq!(code, 202);
+    let task_id = response["uid"].as_u64().unwrap();
+
+    index.wait_task(task_id).await;
+
+    let (response, code) = index.get_task(task_id).await;
+    assert_eq!(code, 200);
+    assert_eq!(response["status"], "succeeded");
+
+    // try to create a index via add specialized settings route
+    let index = server.index("test2");
+    let (response, code) = index.update_distinct_attribute(json!("test")).await;
+    assert_eq!(code, 202);
+    let task_id = response["uid"].as_u64().unwrap();
+
+    index.wait_task(task_id).await;
+
+    let (response, code) = index.get_task(task_id).await;
+    assert_eq!(code, 200);
+    assert_eq!(response["status"], "succeeded");
+}
--- a/meilisearch-http/tests/auth/mod.rs
+++ b/meilisearch-http/tests/auth/mod.rs
@@ -2,29 +2,12 @@ mod api_keys;
 mod authorization;
 mod payload;

-use crate::common::server::default_settings;
-use crate::common::server::TEST_TEMP_DIR;
 use crate::common::Server;
 use actix_web::http::StatusCode;
+
 use serde_json::{json, Value};
-use tempfile::TempDir;

 impl Server {
-    pub async fn new_auth() -> Self {
-        let dir = TempDir::new().unwrap();
-
-        if cfg!(windows) {
-            std::env::set_var("TMP", TEST_TEMP_DIR.path());
-        } else {
-            std::env::set_var("TMPDIR", TEST_TEMP_DIR.path());
-        }
-
-        let mut options = default_settings(dir.path());
-        options.master_key = Some("MASTER_KEY".to_string());
-
-        Self::new_with_options(options).await
-    }
-
    pub fn use_api_key(&mut self, api_key: impl AsRef<str>) {
        self.service.api_key = Some(api_key.as_ref().to_string());
    }
--- a/meilisearch-http/tests/common/index.rs
+++ b/meilisearch-http/tests/common/index.rs
@@ -35,15 +35,12 @@ pub struct Index<'a> {
 #[allow(dead_code)]
 impl Index<'_> {
    pub async fn get(&self) -> (Value, StatusCode) {
-        let url = format!("/indexes/{}", encode(self.uid.as_ref()).to_string());
+        let url = format!("/indexes/{}", encode(self.uid.as_ref()));
        self.service.get(url).await
    }

    pub async fn load_test_set(&self) -> u64 {
-        let url = format!(
-            "/indexes/{}/documents",
-            encode(self.uid.as_ref()).to_string()
-        );
+        let url = format!("/indexes/{}/documents", encode(self.uid.as_ref()));
        let (response, code) = self
            .service
            .post_str(url, include_str!("../assets/test_set.json"))
@@ -66,13 +63,13 @@ impl Index<'_> {
        let body = json!({
            "primaryKey": primary_key,
        });
-        let url = format!("/indexes/{}", encode(self.uid.as_ref()).to_string());
+        let url = format!("/indexes/{}", encode(self.uid.as_ref()));

        self.service.put(url, body).await
    }

    pub async fn delete(&self) -> (Value, StatusCode) {
-        let url = format!("/indexes/{}", encode(self.uid.as_ref()).to_string());
+        let url = format!("/indexes/{}", encode(self.uid.as_ref()));
        self.service.delete(url).await
    }

@@ -84,13 +81,10 @@ impl Index<'_> {
        let url = match primary_key {
            Some(key) => format!(
                "/indexes/{}/documents?primaryKey={}",
-                encode(self.uid.as_ref()).to_string(),
+                encode(self.uid.as_ref()),
                key
            ),
-            None => format!(
-                "/indexes/{}/documents",
-                encode(self.uid.as_ref()).to_string()
-            ),
+            None => format!("/indexes/{}/documents", encode(self.uid.as_ref())),
        };
        self.service.post(url, documents).await
    }
@@ -103,13 +97,10 @@ impl Index<'_> {
        let url = match primary_key {
            Some(key) => format!(
                "/indexes/{}/documents?primaryKey={}",
-                encode(self.uid.as_ref()).to_string(),
+                encode(self.uid.as_ref()),
                key
            ),
-            None => format!(
-                "/indexes/{}/documents",
-                encode(self.uid.as_ref()).to_string()
-            ),
+            None => format!("/indexes/{}/documents", encode(self.uid.as_ref())),
        };
        self.service.put(url, documents).await
    }
@@ -145,19 +136,12 @@ impl Index<'_> {
        id: u64,
        _options: Option<GetDocumentOptions>,
    ) -> (Value, StatusCode) {
-        let url = format!(
-            "/indexes/{}/documents/{}",
-            encode(self.uid.as_ref()).to_string(),
-            id
-        );
+        let url = format!("/indexes/{}/documents/{}", encode(self.uid.as_ref()), id);
        self.service.get(url).await
    }

    pub async fn get_all_documents(&self, options: GetAllDocumentsOptions) -> (Value, StatusCode) {
-        let mut url = format!(
-            "/indexes/{}/documents?",
-            encode(self.uid.as_ref()).to_string()
-        );
+        let mut url = format!("/indexes/{}/documents?", encode(self.uid.as_ref()));
        if let Some(limit) = options.limit {
            url.push_str(&format!("limit={}&", limit));
        }
@@ -177,26 +161,19 @@ impl Index<'_> {
    }

    pub async fn delete_document(&self, id: u64) -> (Value, StatusCode) {
-        let url = format!(
-            "/indexes/{}/documents/{}",
-            encode(self.uid.as_ref()).to_string(),
-            id
-        );
+        let url = format!("/indexes/{}/documents/{}", encode(self.uid.as_ref()), id);
        self.service.delete(url).await
    }

    pub async fn clear_all_documents(&self) -> (Value, StatusCode) {
-        let url = format!(
-            "/indexes/{}/documents",
-            encode(self.uid.as_ref()).to_string()
-        );
+        let url = format!("/indexes/{}/documents", encode(self.uid.as_ref()));
        self.service.delete(url).await
    }

    pub async fn delete_batch(&self, ids: Vec<u64>) -> (Value, StatusCode) {
        let url = format!(
            "/indexes/{}/documents/delete-batch",
-            encode(self.uid.as_ref()).to_string()
+            encode(self.uid.as_ref())
        );
        self.service
            .post(url, serde_json::to_value(&ids).unwrap())
@@ -204,31 +181,22 @@ impl Index<'_> {
    }

    pub async fn settings(&self) -> (Value, StatusCode) {
-        let url = format!(
-            "/indexes/{}/settings",
-            encode(self.uid.as_ref()).to_string()
-        );
+        let url = format!("/indexes/{}/settings", encode(self.uid.as_ref()));
        self.service.get(url).await
    }

    pub async fn update_settings(&self, settings: Value) -> (Value, StatusCode) {
-        let url = format!(
-            "/indexes/{}/settings",
-            encode(self.uid.as_ref()).to_string()
-        );
+        let url = format!("/indexes/{}/settings", encode(self.uid.as_ref()));
        self.service.post(url, settings).await
    }

    pub async fn delete_settings(&self) -> (Value, StatusCode) {
-        let url = format!(
-            "/indexes/{}/settings",
-            encode(self.uid.as_ref()).to_string()
-        );
+        let url = format!("/indexes/{}/settings", encode(self.uid.as_ref()));
        self.service.delete(url).await
    }

    pub async fn stats(&self) -> (Value, StatusCode) {
-        let url = format!("/indexes/{}/stats", encode(self.uid.as_ref()).to_string());
+        let url = format!("/indexes/{}/stats", encode(self.uid.as_ref()));
        self.service.get(url).await
    }

@@ -253,17 +221,13 @@ impl Index<'_> {
    }

    pub async fn search_post(&self, query: Value) -> (Value, StatusCode) {
-        let url = format!("/indexes/{}/search", encode(self.uid.as_ref()).to_string());
+        let url = format!("/indexes/{}/search", encode(self.uid.as_ref()));
        self.service.post(url, query).await
    }

    pub async fn search_get(&self, query: Value) -> (Value, StatusCode) {
        let params = serde_url_params::to_string(&query).unwrap();
-        let url = format!(
-            "/indexes/{}/search?{}",
-            encode(self.uid.as_ref()).to_string(),
-            params
-        );
+        let url = format!("/indexes/{}/search?{}", encode(self.uid.as_ref()), params);
        self.service.get(url).await
    }

--- a/meilisearch-http/tests/common/server.rs
+++ b/meilisearch-http/tests/common/server.rs
@@ -50,6 +50,33 @@ impl Server {
        }
    }

+    pub async fn new_auth() -> Self {
+        let dir = TempDir::new().unwrap();
+
+        if cfg!(windows) {
+            std::env::set_var("TMP", TEST_TEMP_DIR.path());
+        } else {
+            std::env::set_var("TMPDIR", TEST_TEMP_DIR.path());
+        }
+
+        let mut options = default_settings(dir.path());
+        options.master_key = Some("MASTER_KEY".to_string());
+
+        let meilisearch = setup_meilisearch(&options).unwrap();
+        let auth = AuthController::new(&options.db_path, &options.master_key).unwrap();
+        let service = Service {
+            meilisearch,
+            auth,
+            options,
+            api_key: None,
+        };
+
+        Server {
+            service,
+            _dir: Some(dir),
+        }
+    }
+
    pub async fn new_with_options(options: Opt) -> Self {
        let meilisearch = setup_meilisearch(&options).unwrap();
        let auth = AuthController::new(&options.db_path, &options.master_key).unwrap();
--- a/meilisearch-lib/Cargo.toml
+++ b/meilisearch-lib/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "meilisearch-lib"
-version = "0.25.0"
+version = "0.25.2"
 edition = "2018"
 resolver = "2"

@@ -30,7 +30,7 @@ lazy_static = "1.4.0"
 log = "0.4.14"
 meilisearch-error = { path = "../meilisearch-error" }
 meilisearch-auth = { path = "../meilisearch-auth" }
-milli = { git = "https://github.com/meilisearch/milli.git", tag = "v0.21.0" }
+milli = { git = "https://github.com/meilisearch/milli.git", tag = "v0.21.1" }
 mime = "0.3.16"
 num_cpus = "1.13.0"
 once_cell = "1.8.0"
--- a/meilisearch-lib/proptest-regressions/index_resolver/mod.txt
+++ b/meilisearch-lib/proptest-regressions/index_resolver/mod.txt
@@ -17,3 +17,4 @@ cc 3a01c78db082434b8a4f8914abf0d1059d39f4426d16df20d72e1bd7ebb94a6a # shrinks to
 cc c450806df3921d1e6fe9b6af93d999e8196d0175b69b64f1810802582421e94a # shrinks to task = Task { id: 0, index_uid: IndexUid("a"), content: CreateIndex { primary_key: Some("") }, events: [] }, index_exists = false, index_op_fails = false, any_int = 0
 cc fb6b98947cbdbdee05ed3c0bf2923aad2c311edc276253642eb43a0c0ec4888a # shrinks to task = Task { id: 0, index_uid: IndexUid("A"), content: CreateIndex { primary_key: Some("") }, events: [] }, index_exists = false, index_op_fails = true, any_int = 0
 cc 1aa59d8e22484e9915efbb5818e1e1ab684aa61b166dc82130d6221663ba00bf # shrinks to task = Task { id: 0, index_uid: IndexUid("a"), content: DocumentDeletion(Clear), events: [] }, index_exists = true, index_op_fails = false, any_int = 0
+cc 2e8644e6397b5f76e0b79f961fa125e2f45f42f26e03c453c9a174dfb427500d # shrinks to task = Task { id: 0, index_uid: IndexUid("0"), content: SettingsUpdate { settings: Settings { displayed_attributes: NotSet, searchable_attributes: NotSet, filterable_attributes: NotSet, sortable_attributes: NotSet, ranking_rules: NotSet, stop_words: NotSet, synonyms: NotSet, distinct_attribute: NotSet, _kind: PhantomData }, is_deletion: false, allow_index_creation: false }, events: [] }, index_exists = false, index_op_fails = false, any_int = 0
--- a/meilisearch-lib/src/index/dump.rs
+++ b/meilisearch-lib/src/index/dump.rs
@@ -8,7 +8,7 @@ use indexmap::IndexMap;
 use milli::documents::DocumentBatchReader;
 use serde::{Deserialize, Serialize};

-use crate::document_formats::read_ndjson;
+use crate::document_formats::{read_ndjson, DocumentFormatError};
 use crate::index::update_handler::UpdateHandler;
 use crate::index::updates::apply_settings_to_builder;

@@ -28,9 +28,7 @@ impl Index {
    pub fn dump(&self, path: impl AsRef<Path>) -> Result<()> {
        // acquire write txn make sure any ongoing write is finished before we start.
        let txn = self.env.write_txn()?;
-        let path = path
-            .as_ref()
-            .join(format!("indexes/{}", self.uuid.to_string()));
+        let path = path.as_ref().join(format!("indexes/{}", self.uuid));

        create_dir_all(&path)?;

@@ -128,23 +126,29 @@ impl Index {

        let mut tmp_doc_file = tempfile::tempfile()?;

-        read_ndjson(reader, &mut tmp_doc_file)?;
+        let empty = match read_ndjson(reader, &mut tmp_doc_file) {
+            // if there was no document in the file it's because the index was empty
+            Ok(_) => false,
+            Err(DocumentFormatError::EmptyPayload(_)) => true,
+            Err(e) => return Err(e.into()),
+        };

-        tmp_doc_file.seek(SeekFrom::Start(0))?;
+        if !empty {
+            tmp_doc_file.seek(SeekFrom::Start(0))?;

-        let documents_reader = DocumentBatchReader::from_reader(tmp_doc_file)?;
+            let documents_reader = DocumentBatchReader::from_reader(tmp_doc_file)?;

-        //If the document file is empty, we don't perform the document addition, to prevent
-        //a primary key error to be thrown.
-        if !documents_reader.is_empty() {
-            let builder = update_handler
-                .update_builder()
-                .index_documents(&mut txn, &index);
-            builder.execute(documents_reader, |_| ())?;
+            //If the document file is empty, we don't perform the document addition, to prevent
+            //a primary key error to be thrown.
+            if !documents_reader.is_empty() {
+                let builder = update_handler
+                    .update_builder()
+                    .index_documents(&mut txn, &index);
+                builder.execute(documents_reader, |_| ())?;
+            }
        }

        txn.commit()?;
-
        index.prepare_for_closing().wait();

        Ok(())
--- a/meilisearch-lib/src/index_controller/dump_actor/compat/v3.rs
+++ b/meilisearch-lib/src/index_controller/dump_actor/compat/v3.rs
@@ -74,11 +74,13 @@ impl From<Update> for TaskContent {
                primary_key,
                // document count is unknown for legacy updates
                documents_count: 0,
+                allow_index_creation: true,
            },
            Update::Settings(settings) => TaskContent::SettingsUpdate {
                settings,
                // There is no way to know now, so we assume it isn't
                is_deletion: false,
+                allow_index_creation: true,
            },
            Update::ClearDocuments => TaskContent::DocumentDeletion(DocumentDeletion::Clear),
        }
--- a/meilisearch-lib/src/index_controller/dump_actor/mod.rs
+++ b/meilisearch-lib/src/index_controller/dump_actor/mod.rs
@@ -290,7 +290,18 @@ impl DumpJob {
                .map_err(|e| DumpActorError::Internal(e.into()))?;

            let dump_path = self.dump_path.join(self.uid).with_extension("dump");
-            temp_dump_file.persist(&dump_path)?;
+            log::info!("temp_dump_file: {:?}", temp_dump_file);
+            log::info!("temp dir: {:?}", temp_dump_dir);
+            let res = temp_dump_file.persist(&dump_path);
+            if let Err(error) = res {
+                log::info!("could not persist: {:?}", error.file);
+                log::info!("underlying error {}", error.error);
+                log::info!("underlying error (dbg) {}", error.error);
+                log::info!("underlying error kind {}", error.error.kind());
+
+                return Err(error.into());
+            }
+            log::info!("dump path: {}", dump_path.display());

            Ok(dump_path)
        })
--- a/meilisearch-lib/src/index_controller/mod.rs
+++ b/meilisearch-lib/src/index_controller/mod.rs
@@ -119,6 +119,7 @@ pub enum Update {
        settings: Settings<Unchecked>,
        /// Indicates whether the update was a deletion
        is_deletion: bool,
+        allow_index_creation: bool,
    },
    DocumentAddition {
        #[derivative(Debug = "ignore")]
@@ -126,6 +127,7 @@ pub enum Update {
        primary_key: Option<String>,
        method: IndexDocumentsMethod,
        format: DocumentAdditionFormat,
+        allow_index_creation: bool,
    },
    DeleteIndex,
    CreateIndex {
@@ -165,7 +167,11 @@ impl IndexControllerBuilder {

        let db_exists = db_path.as_ref().exists();
        if db_exists {
-            versioning::check_version_file(db_path.as_ref())?;
+            // Directory could be pre-created without any database in.
+            let db_is_empty = db_path.as_ref().read_dir()?.next().is_none();
+            if !db_is_empty {
+                versioning::check_version_file(db_path.as_ref())?;
+            }
        }

        if let Some(ref path) = self.import_snapshot {
@@ -340,15 +346,18 @@ where
            Update::Settings {
                settings,
                is_deletion,
+                allow_index_creation,
            } => TaskContent::SettingsUpdate {
                settings,
                is_deletion,
+                allow_index_creation,
            },
            Update::DocumentAddition {
                mut payload,
                primary_key,
                format,
                method,
+                allow_index_creation,
            } => {
                let mut buffer = Vec::new();
                while let Some(bytes) = payload.next().await {
@@ -380,6 +389,7 @@ where
                    merge_strategy: method,
                    primary_key,
                    documents_count,
+                    allow_index_creation,
                }
            }
            Update::DeleteIndex => TaskContent::IndexDeletion,
--- a/meilisearch-lib/src/index_controller/versioning/error.rs
+++ b/meilisearch-lib/src/index_controller/versioning/error.rs
@@ -1,11 +1,11 @@
 #[derive(thiserror::Error, Debug)]
 pub enum VersionFileError {
-    #[error("Version file is missing or the previous MeiliSearch engine version was below 0.24.0. Use a dump to update Meilisearch.")]
+    #[error("Version file is missing or the previous MeiliSearch engine version was below 0.24.0. Use a dump to update MeiliSearch.")]
    MissingVersionFile,
    #[error("Version file is corrupted and thus MeiliSearch is unable to determine the version of the database.")]
    MalformedVersionFile,
    #[error(
-        "Expected MeiliSearch engine version: {major}.{minor}.{patch}, current engine version: {}. To update Meilisearch use a dump.",
+        "Expected MeiliSearch engine version: {major}.{minor}.{patch}, current engine version: {}. To update MeiliSearch use a dump.",
        env!("CARGO_PKG_VERSION").to_string()
    )]
    VersionMismatch {
--- a/meilisearch-lib/src/index_controller/versioning/mod.rs
+++ b/meilisearch-lib/src/index_controller/versioning/mod.rs
@@ -23,7 +23,7 @@ pub fn create_version_file(db_path: &Path) -> anyhow::Result<()> {
    Ok(())
 }

-// Ensures Meilisearch version is compatible with the database, returns an error versions mismatch.
+// Ensures MeiliSearch version is compatible with the database, returns an error versions mismatch.
 pub fn check_version_file(db_path: &Path) -> anyhow::Result<()> {
    let version_path = db_path.join(VERSION_FILE_NAME);

--- a/meilisearch-lib/src/index_resolver/mod.rs
+++ b/meilisearch-lib/src/index_resolver/mod.rs
@@ -188,13 +188,18 @@ where
                content_uuid,
                merge_strategy,
                primary_key,
+                allow_index_creation,
                ..
            } => {
                let primary_key = primary_key.clone();
                let content_uuid = *content_uuid;
                let method = *merge_strategy;

-                let index = self.get_or_create_index(index_uid, task.id).await?;
+                let index = if *allow_index_creation {
+                    self.get_or_create_index(index_uid, task.id).await?
+                } else {
+                    self.get_index(index_uid.into_inner()).await?
+                };
                let file_store = self.file_store.clone();
                let result = spawn_blocking(move || {
                    index.update_documents(method, content_uuid, primary_key, file_store)
@@ -227,8 +232,9 @@ where
            TaskContent::SettingsUpdate {
                settings,
                is_deletion,
+                allow_index_creation,
            } => {
-                let index = if *is_deletion {
+                let index = if *is_deletion || !*allow_index_creation {
                    self.get_index(index_uid.into_inner()).await?
                } else {
                    self.get_or_create_index(index_uid, task.id).await?
@@ -503,8 +509,8 @@ mod test {

                match &task.content {
                    // an unexisting index should trigger an index creation in the folllowing cases:
-                    TaskContent::DocumentAddition { .. }
-                    | TaskContent::SettingsUpdate { is_deletion: false, .. }
+                    TaskContent::DocumentAddition { allow_index_creation: true, .. }
+                    | TaskContent::SettingsUpdate { allow_index_creation: true, is_deletion: false, .. }
                    | TaskContent::IndexCreation { .. } if !index_exists => {
                        index_store
                            .expect_create()
@@ -566,6 +572,8 @@ mod test {
                    || (!index_exists && matches!(task.content, TaskContent::IndexDeletion
                                                                | TaskContent::DocumentDeletion(_)
                                                                | TaskContent::SettingsUpdate { is_deletion: true, ..}
+                                                                | TaskContent::SettingsUpdate { allow_index_creation: false, ..}
+                                                                | TaskContent::DocumentAddition { allow_index_creation: false, ..}
                                                                | TaskContent::IndexUpdate { .. } ))
                {
                    assert!(result.is_err(), "{:?}", result);
--- a/meilisearch-lib/src/tasks/task.rs
+++ b/meilisearch-lib/src/tasks/task.rs
@@ -55,7 +55,7 @@ pub enum TaskEvent {
    },
 }

-/// A task represents an operation that Meilisearch must do.
+/// A task represents an operation that MeiliSearch must do.
 /// It's stored on disk and executed from the lowest to highest Task id.
 /// Everytime a new task is created it has a higher Task id than the previous one.
 /// See also `Job`.
@@ -91,7 +91,7 @@ impl Task {

 /// A job is like a volatile priority `Task`.
 /// It should be processed as fast as possible and is not stored on disk.
-/// This means, when Meilisearch is closed all your unprocessed jobs will disappear.
+/// This means, when MeiliSearch is closed all your unprocessed jobs will disappear.
 #[derive(Debug, derivative::Derivative)]
 #[derivative(PartialEq)]
 pub enum Job {
@@ -134,12 +134,14 @@ pub enum TaskContent {
        merge_strategy: IndexDocumentsMethod,
        primary_key: Option<String>,
        documents_count: usize,
+        allow_index_creation: bool,
    },
    DocumentDeletion(DocumentDeletion),
    SettingsUpdate {
        settings: Settings<Unchecked>,
        /// Indicates whether the task was a deletion
        is_deletion: bool,
+        allow_index_creation: bool,
    },
    IndexDeletion,
    IndexCreation {
--- a/meilisearch-lib/src/tasks/task_store/store.rs
+++ b/meilisearch-lib/src/tasks/task_store/store.rs
@@ -78,7 +78,7 @@ impl Store {
    /// This function should be called *right after* creating the store.
    /// It put back all unfinished update in the `Created` state. This
    /// allow us to re-enqueue an update that didn't had the time to finish
-    /// when Meilisearch closed.
+    /// when MeiliSearch closed.
    pub fn reset_and_return_unfinished_tasks(&mut self) -> Result<BinaryHeap<Pending<TaskId>>> {
        let mut unfinished_tasks: BinaryHeap<Pending<TaskId>> = BinaryHeap::new();
Author	SHA1	Message	Date
Louis Dureuil	6939d3d061	More error logs	2023-04-18 19:36:58 +02:00
Louis Dureuil	5d2ca496cb	updated tempfile and put some hopeful log	2023-04-18 19:18:15 +02:00
bors[bot]	523fb5cd56	Merge #2084 2084: bump milli r=Kerollmops a=irevoire - Fix https://github.com/meilisearch/MeiliSearch/issues/2082 by updating milli dependency - Fix Clippy error - Change the MeiliSearch version in the cargo.toml to anticipate the coming release (v0.25.2) Co-authored-by: Tamo <tamo@meilisearch.com>	2022-01-18 14:30:37 +00:00
Tamo	436f61a7f4	chore: bump meilisearch	2022-01-18 12:27:15 +01:00
Tamo	3fab5869fa	chore: bump milli	2022-01-18 11:50:17 +01:00
mpostma	0515c6e844	bug(http): fix task duration	2022-01-13 16:41:07 +01:00
Irevoire	38176181ac	fix(dump): Fix the import of dump from the v24 and before	2022-01-13 16:40:58 +01:00
bors[bot]	0ad7d38eec	Merge #2061 2061: Update dashboard for v0.25.0 r=curquiza a=mdubus Co-authored-by: Morgane Dubus <30866152+mdubus@users.noreply.github.com>	2022-01-10 16:29:31 +00:00
Morgane Dubus	b17ad5c2be	Update with latest release of the dashboard	2022-01-10 17:10:09 +01:00
Morgane Dubus	030a90523d	Update dashboard for v0.25.0	2022-01-10 10:50:57 +01:00
bors[bot]	56d223a51d	Merge #2059 2059: change indexed doc count on error r=irevoire a=MarinPostma change `indexed_documents` and `deleted_documents` to return 0 instead of null when empty when the task has failed. close #2053 Co-authored-by: Marin Postma <postma.marin@protonmail.com>	2022-01-06 15:55:50 +00:00
Marin Postma	f558ff826a	feat(http): task view indexed and deleted documents return 0 instead of null	2022-01-06 14:55:02 +01:00
bors[bot]	0d2a358cc2	Merge #2056 2056: Allow any header for CORS r=curquiza a=curquiza Bug fix: trigger a CORS error when trying to send the `User-Agent` header via the browser `@bidoubiwa` thanks for the bug report! Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>	2022-01-05 16:45:51 +00:00
Clémentine Urquizar	595250c93e	Allow any header for CORS	2022-01-05 15:38:47 +01:00
bors[bot]	c636988935	Merge #2055 2055: fix(dump): Fix the loading of dump with empty indexes r=irevoire a=irevoire Co-authored-by: Tamo <tamo@meilisearch.com>	2022-01-05 14:31:53 +00:00
Tamo	eea483c470	fix(dump): Fix the loading of dump with empty indexes	2022-01-05 15:08:21 +01:00
bors[bot]	d53c61a6d0	Merge #2054 2054: Bug(auth): Wrap key list in results r=irevoire a=ManyTheFish fix #2052 Co-authored-by: ManyTheFish <many@meilisearch.com>	2022-01-04 15:44:55 +00:00
ManyTheFish	c0d4f71a34	Bug(auth): Wrap key list in results	2022-01-04 14:10:30 +01:00
bors[bot]	c0251eb680	Merge #2050 2050: Bug(CORS): Add missing allowed headers r=curquiza a=ManyTheFish fix #2040 ## test html file to test: ```html <!DOCTYPE html> <html> <meta content="text/html;charset=utf-8" http-equiv="Content-Type"> <meta content="utf-8" http-equiv="encoding"> <script> var xmlHttp = new XMLHttpRequest(); xmlHttp.open( "GET", "http://127.0.0.1:7700/indexes/toto", false ); // false for synchronous request xmlHttp.setRequestHeader("Authorization", "Bearer manythefish"); xmlHttp.send( null ); console.log(xmlHttp.responseText); </script> </html> ``` Co-authored-by: ManyTheFish <many@meilisearch.com>	2022-01-03 14:23:34 +00:00
ManyTheFish	450b81ca13	Bug(CORS): Add missing allowed headers fix #2040	2022-01-03 13:41:12 +01:00
bors[bot]	2f3faadcbf	Merge #2034 2034: Fix typo r=curquiza a=curquiza Fix `Meilisearch` typo into `MeiliSearch` Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>	2022-01-03 09:40:56 +00:00
bors[bot]	5986a2d126	Merge #2036 2036: chore(ci): Enable rust_backtrace in the ci r=curquiza a=irevoire This should help us to understand unreproducible panics that happens in the CI all the time Co-authored-by: Tamo <tamo@meilisearch.com>	2021-12-22 19:00:08 +00:00
Tamo	d75e84f625	chore(ci): Enable rust_backtrace in the ci	2021-12-22 18:20:44 +01:00
bors[bot]	c221277fd2	Merge #2035 2035: Use self hosted GitHub runner r=curquiza a=curquiza Checked with `@tpayet,` we have created a self hosted github runner to save time when pushing the docker images. Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>	2021-12-22 15:28:33 +00:00
Clémentine Urquizar	fd854035c1	Use self hosted github runner	2021-12-21 18:32:29 +01:00
bors[bot]	4d1c138842	Merge #2032 2032: Revert docker as non root PR r=curquiza a=ManyTheFish Revert #1759 hotfix for #1969 Co-authored-by: Maxime Legendre <maximelegendre@mbp-de-maxime.home>	2021-12-21 16:19:36 +00:00
Maxime Legendre	7649239b08	Revert docker as non root PR	2021-12-21 16:59:15 +01:00
bors[bot]	0e2f6ba1b6	Merge #2033 2033: Bug(FS): Consider empty pre-created directory as unexisting DB r=curquiza a=ManyTheFish When the database directory was pre-created we were considering that DB is invalid, we are now accepting to create a database in it. Co-authored-by: Maxime Legendre <maximelegendre@mbp-de-maxime.home>	2021-12-21 15:12:07 +00:00
Clémentine Urquizar	f529c46598	Fix typo in error messages and comments	2021-12-21 16:01:38 +01:00
Maxime Legendre	1ba49d2ddb	Bug(FS): Consider empty pre-created directory as unexisting DB	2021-12-21 15:30:11 +01:00
bors[bot]	1b5ca88231	Merge #2026 2026: Bug(auth): Parse YMD date r=curquiza a=ManyTheFish Use NaiveDate to parse YMD date instead of NaiveDatetime fix #2017 Co-authored-by: Maxime Legendre <maximelegendre@mbp-de-maxime.home>	2021-12-21 13:48:21 +00:00
Maxime Legendre	37329e0784	Bug(auth): Parse YMD date Use NaiveDate to parse YMD date instead of NaiveDatetime fix #2017	2021-12-20 15:30:11 +01:00
bors[bot]	eaff393c76	Merge #2025 2025: Fix security index creation r=ManyTheFish a=ManyTheFish Forbid index creation on alternates routes when the action `index.create` is not given fix #2024 Co-authored-by: Maxime Legendre <maximelegendre@MacBook-Pro-de-Maxime.local>	2021-12-20 14:04:28 +00:00
Maxime Legendre	a845cd8880	Fix(auth): Forbid index creation on alternates routes Forbid index creation on alternates routes when the action `index.create` is not given fix #2024	2021-12-20 14:48:18 +01:00