Compare commits

..

4 Commits

Author SHA1 Message Date
ManyTheFish
32d4fb744d Activate only the necessary features for Japanese 2024-03-14 18:29:01 +01:00
meili-bors[bot]
d2f77e88bd Merge #4479
4479: Skip reindexing when modifying unknown faceted fields r=dureuill a=Kerollmops

This PR improves Meilisearch's decision to reindex when a faceted field is added to the settings, but not a single document contains this field. It is effectively a waste of time to reindex documents when the engine needs to know a field.

This is related to a conversation [we have with our biggest customer (internal link)](https://discord.com/channels/1006923006964154428/1101213808627830794/1217112918857089187). They have 170 million documents, so reindexing this amount would be problematic.

---

The image is available by using the following Docker command. You can see the advancement of the image's build [on the GitHub CI page](https://github.com/meilisearch/meilisearch/actions/runs/8251688778).

```
docker pull getmeili/meilisearch:prototype-no-reindex-unknown-fields-0
```

Here is the hand-made test that shows that when modifying unknown filterable attributes, here `lol`, it doesn't reindex. However, when modifying the known `genre` field, it does reindex. You can see all that by looking at the time spent processing the update.

```json
{
  "uid": 3,
  "indexUid": "movies",
  "status": "succeeded",
  "type": "settingsUpdate",
  "canceledBy": null,
  "details": {
    "filterableAttributes": [
      "genres"
    ]
  },
  "error": null,
  "duration": "PT9.237703S",
  "enqueuedAt": "2024-03-12T15:34:26.836083Z",
  "startedAt": "2024-03-12T15:34:26.836374Z",
  "finishedAt": "2024-03-12T15:34:36.074077Z"
},
{
  "uid": 2,
  "indexUid": "movies",
  "status": "succeeded",
  "type": "settingsUpdate",
  "canceledBy": null,
  "details": {
    "filterableAttributes": [
      "lol"
    ]
  },
  "error": null,
  "duration": "PT0.000751S",
  "enqueuedAt": "2024-03-12T15:33:53.563923Z",
  "startedAt": "2024-03-12T15:33:53.565259Z",
  "finishedAt": "2024-03-12T15:33:53.56601Z"
},
{
  "uid": 0,
  "indexUid": "movies",
  "status": "succeeded",
  "type": "documentAdditionOrUpdate",
  "canceledBy": null,
  "details": {
    "receivedDocuments": 31944,
    "indexedDocuments": 31944
  },
  "error": null,
  "duration": "PT3.120723S",
  "enqueuedAt": "2024-02-17T10:35:55.042864Z",
  "startedAt": "2024-02-17T10:35:55.043505Z",
  "finishedAt": "2024-02-17T10:35:58.164228Z"
}
```

Co-authored-by: Clément Renault <clement@meilisearch.com>
2024-03-13 16:23:32 +00:00
meili-bors[bot]
1d8c13f595 Merge #4487
4487: Update version for the next release (v1.7.1) in Cargo.toml r=Kerollmops a=meili-bot

⚠️ This PR is automatically generated. Check the new version is the expected one and Cargo.lock has been updated before merging.

Co-authored-by: Kerollmops <Kerollmops@users.noreply.github.com>
2024-03-13 15:41:10 +00:00
Kerollmops
7f3c495f5c Update version for the next release (v1.7.1) in Cargo.toml 2024-03-13 14:49:21 +00:00
3 changed files with 19 additions and 19 deletions

34
Cargo.lock generated
View File

@@ -496,7 +496,7 @@ checksum = "8c3c1a368f70d6cf7302d78f8f7093da241fb8e8807c05cc9e51a125895a6d5b"
[[package]]
name = "benchmarks"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"anyhow",
"bytes",
@@ -630,7 +630,7 @@ dependencies = [
[[package]]
name = "build-info"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"anyhow",
"time",
@@ -1531,7 +1531,7 @@ dependencies = [
[[package]]
name = "dump"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"anyhow",
"big_s",
@@ -1769,7 +1769,7 @@ dependencies = [
[[package]]
name = "file-store"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"faux",
"tempfile",
@@ -1792,7 +1792,7 @@ dependencies = [
[[package]]
name = "filter-parser"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"insta",
"nom",
@@ -1812,7 +1812,7 @@ dependencies = [
[[package]]
name = "flatten-serde-json"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"criterion",
"serde_json",
@@ -1930,7 +1930,7 @@ dependencies = [
[[package]]
name = "fuzzers"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"arbitrary",
"clap",
@@ -2422,7 +2422,7 @@ checksum = "206ca75c9c03ba3d4ace2460e57b189f39f43de612c2f85836e65c929701bb2d"
[[package]]
name = "index-scheduler"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"anyhow",
"big_s",
@@ -2609,7 +2609,7 @@ dependencies = [
[[package]]
name = "json-depth-checker"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"criterion",
"serde_json",
@@ -3117,7 +3117,7 @@ checksum = "490cc448043f947bae3cbee9c203358d62dbee0db12107a74be5c30ccfd09771"
[[package]]
name = "meili-snap"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"insta",
"md5",
@@ -3126,7 +3126,7 @@ dependencies = [
[[package]]
name = "meilisearch"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"actix-cors",
"actix-http",
@@ -3219,7 +3219,7 @@ dependencies = [
[[package]]
name = "meilisearch-auth"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"base64 0.21.7",
"enum-iterator",
@@ -3238,7 +3238,7 @@ dependencies = [
[[package]]
name = "meilisearch-types"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"actix-web",
"anyhow",
@@ -3268,7 +3268,7 @@ dependencies = [
[[package]]
name = "meilitool"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"anyhow",
"clap",
@@ -3307,7 +3307,7 @@ dependencies = [
[[package]]
name = "milli"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"arroy",
"big_s",
@@ -3748,7 +3748,7 @@ checksum = "e3148f5046208a5d56bcfc03053e3ca6334e51da8dfb19b6cdc8b306fae3283e"
[[package]]
name = "permissive-json-pointer"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"big_s",
"serde_json",
@@ -5943,7 +5943,7 @@ dependencies = [
[[package]]
name = "xtask"
version = "1.7.0"
version = "1.7.1"
dependencies = [
"anyhow",
"build-info",

View File

@@ -21,7 +21,7 @@ members = [
]
[workspace.package]
version = "1.7.0"
version = "1.7.1"
authors = [
"Quentin de Quelen <quentin@dequelen.me>",
"Clément Renault <clement@meilisearch.com>",

View File

@@ -17,7 +17,7 @@ RUN set -eux; \
if [ "$apkArch" = "aarch64" ]; then \
export JEMALLOC_SYS_WITH_LG_PAGE=16; \
fi && \
cargo build --release -p meilisearch -p meilitool
cargo build --release -p meilisearch -p meilitool --no-default-features --features "analytics mini-dashboard japanese"
# Run
FROM alpine:3.16