From fb73b83abe67532e496b7ac2f56aa5594ec81bdd Mon Sep 17 00:00:00 2001
From: Mubelotix <simon@meilisearch.com>
Date: Tue, 8 Jul 2025 12:14:34 +0200
Subject: [PATCH] Fix performance

---
 .../milli/src/search/facet/filter_vector.rs   | 30 ++++++++++++++-----
 1 file changed, 22 insertions(+), 8 deletions(-)

diff --git a/crates/milli/src/search/facet/filter_vector.rs b/crates/milli/src/search/facet/filter_vector.rs
index 79e35366c..a0dc52bac 100644
--- a/crates/milli/src/search/facet/filter_vector.rs
+++ b/crates/milli/src/search/facet/filter_vector.rs
@@ -235,19 +235,33 @@ impl<'a> VectorFilter<'a> {
                     })?;
                 };
 
-                arroy_wrapper.items_in_store(rtxn, fragment_config.id, |bitmap| bitmap.clone())?
+                if let Some(universe) = universe {
+                    arroy_wrapper
+                        .items_in_store(rtxn, fragment_config.id, |bitmap| bitmap & universe)?
+                } else {
+                    arroy_wrapper
+                        .items_in_store(rtxn, fragment_config.id, |bitmap| bitmap.clone())?
+                }
             } else {
+                let mut universe = universe.cloned();
+                if self.user_provided {
+                    let user_provided_docsids =
+                        embedder_info.embedding_status.user_provided_docids();
+                    match &mut universe {
+                        Some(universe) => *universe &= user_provided_docsids,
+                        None => universe = Some(user_provided_docsids.clone()),
+                    }
+                }
+
                 let mut stats = ArroyStats::default();
                 arroy_wrapper.aggregate_stats(rtxn, &mut stats)?;
-                stats.documents
+                if let Some(universe) = &universe {
+                    stats.documents & universe
+                } else {
+                    stats.documents
+                }
             };
 
-            // FIXME: performance
-            if self.user_provided {
-                let user_provided_docsids = embedder_info.embedding_status.user_provided_docids();
-                new_docids &= user_provided_docsids;
-            }
-
             docids |= new_docids;
         }