From e610af36aadb429c4cba3599d15e22463ba21e3c Mon Sep 17 00:00:00 2001 From: Louis Dureuil Date: Tue, 10 Dec 2024 11:06:24 +0100 Subject: [PATCH] User failure for documents with docid of ==512 bytes --- crates/milli/src/documents/primary_key.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/milli/src/documents/primary_key.rs b/crates/milli/src/documents/primary_key.rs index fb8b3d027..c1dd9a9b8 100644 --- a/crates/milli/src/documents/primary_key.rs +++ b/crates/milli/src/documents/primary_key.rs @@ -280,7 +280,7 @@ fn starts_with(selector: &str, key: &str) -> bool { pub fn validate_document_id_str(document_id: &str) -> Option<&str> { if document_id.is_empty() - || document_id.len() > 512 + || document_id.len() >= 512 || !document_id.chars().all(|c| c.is_ascii_alphanumeric() || c == '-' || c == '_') { None