From d71c6f3483a2bbd26144dc980dbc36f45a21feba Mon Sep 17 00:00:00 2001 From: vuthanhtung2412 Date: Tue, 25 Mar 2025 12:04:25 +0100 Subject: [PATCH] allow multiple embedding in per document per embedder to pass --- crates/milli/src/update/new/indexer/write.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/milli/src/update/new/indexer/write.rs b/crates/milli/src/update/new/indexer/write.rs index 2df19bcd6..6f7e212b1 100644 --- a/crates/milli/src/update/new/indexer/write.rs +++ b/crates/milli/src/update/new/indexer/write.rs @@ -218,7 +218,8 @@ pub fn write_from_bbqueue( arroy_writers.get(&embedder_id).expect("requested a missing embedder"); let mut embeddings = Embeddings::new(*dimensions); let all_embeddings = asvs.read_all_embeddings_into_vec(frame, aligned_embedding); - if all_embeddings.len() != *dimensions { + // FIXME: /!\ Case where #embeddings is divisor of `dimensions` would still pass + if all_embeddings.len() % *dimensions != 0 { return Err(Error::UserError(UserError::InvalidVectorDimensions { expected: *dimensions, found: all_embeddings.len(),