From c8ed1158c4e4333ca2c2856ea848364a1b21d63c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Renault?= Date: Tue, 18 Nov 2025 17:03:27 +0100 Subject: [PATCH] Make sure we don't crash on unreferenced fields --- crates/milli/src/update/new/indexer/mod.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/milli/src/update/new/indexer/mod.rs b/crates/milli/src/update/new/indexer/mod.rs index 5c3020d42..dfc5deaed 100644 --- a/crates/milli/src/update/new/indexer/mod.rs +++ b/crates/milli/src/update/new/indexer/mod.rs @@ -509,8 +509,9 @@ where let new_searchable_attributes = settings_delta.new_searchable_attributes().as_ref(); old_searchable_attributes.zip(new_searchable_attributes).map(|(old, new)| { old.iter() - .filter(|field_name| !new.contains(field_name)) - .map(|field_name| fields_ids_map.id(field_name).unwrap()) + // Ignore the field if it is not searchable anymore + // or if it was never referenced in any document + .filter_map(|name| if new.contains(name) { None } else { fields_ids_map.id(name) }) .collect() }) };