From 9c6c0af0767cc2554273f2b2cb9942cb0779db60 Mon Sep 17 00:00:00 2001 From: Louis Dureuil Date: Tue, 29 Jul 2025 13:44:40 +0200 Subject: [PATCH] Misc churn --- crates/benchmarks/benches/indexing.rs | 30 +++++++++++++++++++ crates/benchmarks/benches/utils.rs | 1 + crates/dump/src/lib.rs | 9 ++++-- crates/dump/src/reader/compat/v5_to_v6.rs | 1 + crates/dump/src/reader/v6/mod.rs | 2 +- crates/dump/src/writer.rs | 3 +- crates/fuzzers/src/bin/fuzz-indexing.rs | 1 + crates/index-scheduler/src/features.rs | 3 +- crates/index-scheduler/src/insta_snapshot.rs | 4 +++ crates/index-scheduler/src/lib.rs | 3 +- crates/index-scheduler/src/queue/mod.rs | 1 + crates/index-scheduler/src/upgrade/mod.rs | 1 + crates/index-scheduler/src/utils.rs | 3 +- crates/meilisearch/src/lib.rs | 1 + crates/meilisearch/src/routes/network.rs | 2 +- .../src/search/federated/perform.rs | 2 +- .../meilisearch/src/search/federated/proxy.rs | 2 +- .../milli/src/search/new/tests/integration.rs | 1 + crates/milli/src/test_index.rs | 3 ++ .../milli/src/update/index_documents/mod.rs | 14 +++++++++ .../milli/tests/search/facet_distribution.rs | 1 + crates/milli/tests/search/mod.rs | 1 + crates/milli/tests/search/query_criteria.rs | 1 + crates/milli/tests/search/typo_tolerance.rs | 1 + 24 files changed, 81 insertions(+), 10 deletions(-) diff --git a/crates/benchmarks/benches/indexing.rs b/crates/benchmarks/benches/indexing.rs index 4083b69dd..75805e28c 100644 --- a/crates/benchmarks/benches/indexing.rs +++ b/crates/benchmarks/benches/indexing.rs @@ -154,6 +154,7 @@ fn indexing_songs_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -221,6 +222,7 @@ fn reindexing_songs_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -266,6 +268,7 @@ fn reindexing_songs_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -335,6 +338,7 @@ fn deleting_songs_in_batches_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -412,6 +416,7 @@ fn indexing_songs_in_three_batches_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -457,6 +462,7 @@ fn indexing_songs_in_three_batches_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -498,6 +504,7 @@ fn indexing_songs_in_three_batches_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -566,6 +573,7 @@ fn indexing_songs_without_faceted_numbers(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -633,6 +641,7 @@ fn indexing_songs_without_faceted_fields(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -700,6 +709,7 @@ fn indexing_wiki(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -766,6 +776,7 @@ fn reindexing_wiki(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -811,6 +822,7 @@ fn reindexing_wiki(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -879,6 +891,7 @@ fn deleting_wiki_in_batches_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -956,6 +969,7 @@ fn indexing_wiki_in_three_batches(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1002,6 +1016,7 @@ fn indexing_wiki_in_three_batches(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1044,6 +1059,7 @@ fn indexing_wiki_in_three_batches(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1111,6 +1127,7 @@ fn indexing_movies_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1177,6 +1194,7 @@ fn reindexing_movies_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1222,6 +1240,7 @@ fn reindexing_movies_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1290,6 +1309,7 @@ fn deleting_movies_in_batches_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1404,6 +1424,7 @@ fn indexing_movies_in_three_batches(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1449,6 +1470,7 @@ fn indexing_movies_in_three_batches(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1490,6 +1512,7 @@ fn indexing_movies_in_three_batches(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1580,6 +1603,7 @@ fn indexing_nested_movies_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1671,6 +1695,7 @@ fn deleting_nested_movies_in_batches_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1754,6 +1779,7 @@ fn indexing_nested_movies_without_faceted_fields(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1821,6 +1847,7 @@ fn indexing_geo(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1887,6 +1914,7 @@ fn reindexing_geo(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -1932,6 +1960,7 @@ fn reindexing_geo(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2000,6 +2029,7 @@ fn deleting_geo_in_batches_default(c: &mut Criterion) { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); diff --git a/crates/benchmarks/benches/utils.rs b/crates/benchmarks/benches/utils.rs index 0abbd6c71..44066767a 100644 --- a/crates/benchmarks/benches/utils.rs +++ b/crates/benchmarks/benches/utils.rs @@ -123,6 +123,7 @@ pub fn base_setup(conf: &Conf) -> Index { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); diff --git a/crates/dump/src/lib.rs b/crates/dump/src/lib.rs index 4b12e0322..b374131f5 100644 --- a/crates/dump/src/lib.rs +++ b/crates/dump/src/lib.rs @@ -254,11 +254,12 @@ pub(crate) mod test { use maplit::{btreemap, btreeset}; use meilisearch_types::batches::{Batch, BatchEnqueuedAt, BatchStats}; use meilisearch_types::facet_values_sort::FacetValuesSort; - use meilisearch_types::features::{Network, Remote, RuntimeTogglableFeatures}; + use meilisearch_types::features::RuntimeTogglableFeatures; use meilisearch_types::index_uid_pattern::IndexUidPattern; use meilisearch_types::keys::{Action, Key}; use meilisearch_types::milli::update::Setting; use meilisearch_types::milli::{self, FilterableAttributesRule}; + use meilisearch_types::network::{Network, Remote}; use meilisearch_types::settings::{Checked, FacetingSettings, Settings}; use meilisearch_types::task_view::DetailsView; use meilisearch_types::tasks::{BatchStopReason, Details, Kind, Status}; @@ -387,6 +388,7 @@ pub(crate) mod test { enqueued_at: datetime!(2022-11-11 0:00 UTC), started_at: Some(datetime!(2022-11-20 0:00 UTC)), finished_at: Some(datetime!(2022-11-21 0:00 UTC)), + network: None, }, None, ), @@ -411,6 +413,7 @@ pub(crate) mod test { enqueued_at: datetime!(2022-11-11 0:00 UTC), started_at: None, finished_at: None, + network: None, }, Some(vec![ json!({ "id": 4, "race": "leonberg" }).as_object().unwrap().clone(), @@ -430,6 +433,7 @@ pub(crate) mod test { enqueued_at: datetime!(2022-11-15 0:00 UTC), started_at: None, finished_at: None, + network: None, }, None, ), @@ -542,7 +546,8 @@ pub(crate) mod test { fn create_test_network() -> Network { Network { local: Some("myself".to_string()), - remotes: maplit::btreemap! {"other".to_string() => Remote { url: "http://test".to_string(), search_api_key: Some("apiKey".to_string()) }}, + remotes: maplit::btreemap! {"other".to_string() => Remote { url: "http://test".to_string(), search_api_key: Some("apiKey".to_string()), write_api_key: Some("docApiKey".to_string()) }}, + sharding: false, } } diff --git a/crates/dump/src/reader/compat/v5_to_v6.rs b/crates/dump/src/reader/compat/v5_to_v6.rs index 634604639..cdfa6847e 100644 --- a/crates/dump/src/reader/compat/v5_to_v6.rs +++ b/crates/dump/src/reader/compat/v5_to_v6.rs @@ -163,6 +163,7 @@ impl CompatV5ToV6 { enqueued_at: task_view.enqueued_at, started_at: task_view.started_at, finished_at: task_view.finished_at, + network: None, }; (task, content_file) diff --git a/crates/dump/src/reader/v6/mod.rs b/crates/dump/src/reader/v6/mod.rs index 9bc4b33c5..d361ab0b1 100644 --- a/crates/dump/src/reader/v6/mod.rs +++ b/crates/dump/src/reader/v6/mod.rs @@ -24,7 +24,7 @@ pub type Batch = meilisearch_types::batches::Batch; pub type Key = meilisearch_types::keys::Key; pub type ChatCompletionSettings = meilisearch_types::features::ChatCompletionSettings; pub type RuntimeTogglableFeatures = meilisearch_types::features::RuntimeTogglableFeatures; -pub type Network = meilisearch_types::features::Network; +pub type Network = meilisearch_types::network::Network; pub type Webhooks = meilisearch_types::webhooks::WebhooksDumpView; // ===== Other types to clarify the code of the compat module diff --git a/crates/dump/src/writer.rs b/crates/dump/src/writer.rs index 1d41b6aa5..ad6d1651b 100644 --- a/crates/dump/src/writer.rs +++ b/crates/dump/src/writer.rs @@ -5,8 +5,9 @@ use std::path::PathBuf; use flate2::write::GzEncoder; use flate2::Compression; use meilisearch_types::batches::Batch; -use meilisearch_types::features::{ChatCompletionSettings, Network, RuntimeTogglableFeatures}; +use meilisearch_types::features::{ChatCompletionSettings, RuntimeTogglableFeatures}; use meilisearch_types::keys::Key; +use meilisearch_types::network::Network; use meilisearch_types::settings::{Checked, Settings}; use meilisearch_types::webhooks::WebhooksDumpView; use serde_json::{Map, Value}; diff --git a/crates/fuzzers/src/bin/fuzz-indexing.rs b/crates/fuzzers/src/bin/fuzz-indexing.rs index ec1f96fd5..7ca4d3092 100644 --- a/crates/fuzzers/src/bin/fuzz-indexing.rs +++ b/crates/fuzzers/src/bin/fuzz-indexing.rs @@ -129,6 +129,7 @@ fn main() { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); diff --git a/crates/index-scheduler/src/features.rs b/crates/index-scheduler/src/features.rs index dee665458..c9a4af9af 100644 --- a/crates/index-scheduler/src/features.rs +++ b/crates/index-scheduler/src/features.rs @@ -1,8 +1,9 @@ use std::sync::{Arc, RwLock}; -use meilisearch_types::features::{InstanceTogglableFeatures, Network, RuntimeTogglableFeatures}; +use meilisearch_types::features::{InstanceTogglableFeatures, RuntimeTogglableFeatures}; use meilisearch_types::heed::types::{SerdeJson, Str}; use meilisearch_types::heed::{Database, Env, RwTxn, WithoutTls}; +use meilisearch_types::network::Network; use crate::error::FeatureNotEnabledError; use crate::Result; diff --git a/crates/index-scheduler/src/insta_snapshot.rs b/crates/index-scheduler/src/insta_snapshot.rs index e7a068899..df043ad87 100644 --- a/crates/index-scheduler/src/insta_snapshot.rs +++ b/crates/index-scheduler/src/insta_snapshot.rs @@ -230,6 +230,7 @@ pub fn snapshot_task(task: &Task) -> String { details, status, kind, + network, } = task; snap.push('{'); snap.push_str(&format!("uid: {uid}, ")); @@ -247,6 +248,9 @@ pub fn snapshot_task(task: &Task) -> String { snap.push_str(&format!("details: {}, ", &snapshot_details(details))); } snap.push_str(&format!("kind: {kind:?}")); + if let Some(network) = network { + snap.push_str(&format!("network: {network:?}, ")) + } snap.push('}'); snap diff --git a/crates/index-scheduler/src/lib.rs b/crates/index-scheduler/src/lib.rs index 797ecc134..ef02d9c3b 100644 --- a/crates/index-scheduler/src/lib.rs +++ b/crates/index-scheduler/src/lib.rs @@ -52,7 +52,7 @@ use flate2::bufread::GzEncoder; use flate2::Compression; use meilisearch_types::batches::Batch; use meilisearch_types::features::{ - ChatCompletionSettings, InstanceTogglableFeatures, Network, RuntimeTogglableFeatures, + ChatCompletionSettings, InstanceTogglableFeatures, RuntimeTogglableFeatures, }; use meilisearch_types::heed::byteorder::BE; use meilisearch_types::heed::types::{DecodeIgnore, SerdeJson, Str, I128}; @@ -63,6 +63,7 @@ use meilisearch_types::milli::vector::{ Embedder, EmbedderOptions, RuntimeEmbedder, RuntimeEmbedders, RuntimeFragment, }; use meilisearch_types::milli::{self, Index}; +use meilisearch_types::network::Network; use meilisearch_types::task_view::TaskView; use meilisearch_types::tasks::{KindWithContent, Task, TaskNetwork}; use meilisearch_types::webhooks::{Webhook, WebhooksDumpView, WebhooksView}; diff --git a/crates/index-scheduler/src/queue/mod.rs b/crates/index-scheduler/src/queue/mod.rs index 92de10fe1..4f02edfb2 100644 --- a/crates/index-scheduler/src/queue/mod.rs +++ b/crates/index-scheduler/src/queue/mod.rs @@ -279,6 +279,7 @@ impl Queue { details: kind.default_details(), status: Status::Enqueued, kind: kind.clone(), + network: None, }; // For deletion and cancelation tasks, we want to make extra sure that they // don't attempt to delete/cancel tasks that are newer than themselves. diff --git a/crates/index-scheduler/src/upgrade/mod.rs b/crates/index-scheduler/src/upgrade/mod.rs index 310e48e95..1743c3940 100644 --- a/crates/index-scheduler/src/upgrade/mod.rs +++ b/crates/index-scheduler/src/upgrade/mod.rs @@ -91,6 +91,7 @@ pub fn upgrade_index_scheduler( details: Some(Details::UpgradeDatabase { from, to }), status: Status::Enqueued, kind: KindWithContent::UpgradeDatabase { from }, + network: None, }, )?; wtxn.commit()?; diff --git a/crates/index-scheduler/src/utils.rs b/crates/index-scheduler/src/utils.rs index 159e8f3d3..2617aba99 100644 --- a/crates/index-scheduler/src/utils.rs +++ b/crates/index-scheduler/src/utils.rs @@ -1,6 +1,5 @@ //! Utility functions on the DBs. Mainly getter and setters. -use crate::milli::progress::EmbedderStats; use std::collections::{BTreeSet, HashSet}; use std::ops::Bound; use std::sync::Arc; @@ -15,6 +14,7 @@ use meilisearch_types::tasks::{ use roaring::RoaringBitmap; use time::OffsetDateTime; +use crate::milli::progress::EmbedderStats; use crate::{Error, Result, Task, TaskId, BEI128}; /// This structure contains all the information required to write a batch in the database without reading the tasks. @@ -377,6 +377,7 @@ impl crate::IndexScheduler { details, status, kind, + network: _, } = task; assert_eq!(uid, task.uid); if task.status != Status::Enqueued { diff --git a/crates/meilisearch/src/lib.rs b/crates/meilisearch/src/lib.rs index ca9bb6f50..c24f81742 100644 --- a/crates/meilisearch/src/lib.rs +++ b/crates/meilisearch/src/lib.rs @@ -628,6 +628,7 @@ fn import_dump( &mut new_fields_ids_map, &|| false, // never stop processing a dump progress.clone(), + None, )?; let operation_stats = operation_stats.pop().unwrap(); diff --git a/crates/meilisearch/src/routes/network.rs b/crates/meilisearch/src/routes/network.rs index c966cb897..f4119b0ad 100644 --- a/crates/meilisearch/src/routes/network.rs +++ b/crates/meilisearch/src/routes/network.rs @@ -12,9 +12,9 @@ use meilisearch_types::error::deserr_codes::{ InvalidNetworkUrl, InvalidNetworkWriteApiKey, }; use meilisearch_types::error::ResponseError; -use meilisearch_types::features::{Network as DbNetwork, Remote as DbRemote}; use meilisearch_types::keys::actions; use meilisearch_types::milli::update::Setting; +use meilisearch_types::network::{Network as DbNetwork, Remote as DbRemote}; use serde::Serialize; use tracing::debug; use utoipa::{OpenApi, ToSchema}; diff --git a/crates/meilisearch/src/search/federated/perform.rs b/crates/meilisearch/src/search/federated/perform.rs index 3c80c22e3..6fb8bcd43 100644 --- a/crates/meilisearch/src/search/federated/perform.rs +++ b/crates/meilisearch/src/search/federated/perform.rs @@ -10,11 +10,11 @@ use actix_http::StatusCode; use index_scheduler::{IndexScheduler, RoFeatures}; use itertools::Itertools; use meilisearch_types::error::ResponseError; -use meilisearch_types::features::{Network, Remote}; use meilisearch_types::milli::order_by_map::OrderByMap; use meilisearch_types::milli::score_details::{ScoreDetails, WeightedScoreValue}; use meilisearch_types::milli::vector::Embedding; use meilisearch_types::milli::{self, DocumentId, OrderBy, TimeBudget, DEFAULT_VALUES_PER_FACET}; +use meilisearch_types::network::{Network, Remote}; use roaring::RoaringBitmap; use tokio::task::JoinHandle; diff --git a/crates/meilisearch/src/search/federated/proxy.rs b/crates/meilisearch/src/search/federated/proxy.rs index bf954693c..6da92ca9e 100644 --- a/crates/meilisearch/src/search/federated/proxy.rs +++ b/crates/meilisearch/src/search/federated/proxy.rs @@ -1,6 +1,6 @@ pub use error::ProxySearchError; use error::ReqwestErrorWithoutUrl; -use meilisearch_types::features::Remote; +use meilisearch_types::network::Remote; use rand::Rng as _; use reqwest::{Client, Response, StatusCode}; use serde::de::DeserializeOwned; diff --git a/crates/milli/src/search/new/tests/integration.rs b/crates/milli/src/search/new/tests/integration.rs index 6b8c25ab8..60e471579 100644 --- a/crates/milli/src/search/new/tests/integration.rs +++ b/crates/milli/src/search/new/tests/integration.rs @@ -76,6 +76,7 @@ pub fn setup_search_index_with_criteria(criteria: &[Criterion]) -> Index { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); diff --git a/crates/milli/src/test_index.rs b/crates/milli/src/test_index.rs index 6e34961e7..b831d55cc 100644 --- a/crates/milli/src/test_index.rs +++ b/crates/milli/src/test_index.rs @@ -84,6 +84,7 @@ impl TempIndex { &mut new_fields_ids_map, &|| false, Progress::default(), + None, )?; if let Some(error) = operation_stats.into_iter().find_map(|stat| stat.error) { @@ -167,6 +168,7 @@ impl TempIndex { &mut new_fields_ids_map, &|| false, Progress::default(), + None, )?; if let Some(error) = operation_stats.into_iter().find_map(|stat| stat.error) { @@ -242,6 +244,7 @@ fn aborting_indexation() { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); diff --git a/crates/milli/src/update/index_documents/mod.rs b/crates/milli/src/update/index_documents/mod.rs index 658ff1923..099879382 100644 --- a/crates/milli/src/update/index_documents/mod.rs +++ b/crates/milli/src/update/index_documents/mod.rs @@ -1977,6 +1977,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2029,6 +2030,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2117,6 +2119,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2306,6 +2309,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2369,6 +2373,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2423,6 +2428,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2476,6 +2482,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2531,6 +2538,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2591,6 +2599,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2644,6 +2653,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2697,6 +2707,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2908,6 +2919,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -2968,6 +2980,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); @@ -3025,6 +3038,7 @@ mod tests { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); diff --git a/crates/milli/tests/search/facet_distribution.rs b/crates/milli/tests/search/facet_distribution.rs index cc1b85369..2f347516b 100644 --- a/crates/milli/tests/search/facet_distribution.rs +++ b/crates/milli/tests/search/facet_distribution.rs @@ -59,6 +59,7 @@ fn test_facet_distribution_with_no_facet_values() { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); diff --git a/crates/milli/tests/search/mod.rs b/crates/milli/tests/search/mod.rs index 578a22009..f88f6c392 100644 --- a/crates/milli/tests/search/mod.rs +++ b/crates/milli/tests/search/mod.rs @@ -97,6 +97,7 @@ pub fn setup_search_index_with_criteria(criteria: &[Criterion]) -> Index { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); diff --git a/crates/milli/tests/search/query_criteria.rs b/crates/milli/tests/search/query_criteria.rs index 3f8134085..f92cf9e51 100644 --- a/crates/milli/tests/search/query_criteria.rs +++ b/crates/milli/tests/search/query_criteria.rs @@ -329,6 +329,7 @@ fn criteria_ascdesc() { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap(); diff --git a/crates/milli/tests/search/typo_tolerance.rs b/crates/milli/tests/search/typo_tolerance.rs index 95ff85165..d44848353 100644 --- a/crates/milli/tests/search/typo_tolerance.rs +++ b/crates/milli/tests/search/typo_tolerance.rs @@ -138,6 +138,7 @@ fn test_typo_disabled_on_word() { &mut new_fields_ids_map, &|| false, Progress::default(), + None, ) .unwrap();