From 29b74424ad6313ea673869a658e10883fca7e4b1 Mon Sep 17 00:00:00 2001
From: Mubelotix <simon@meilisearch.com>
Date: Tue, 8 Jul 2025 12:03:32 +0200
Subject: [PATCH] Clean code

---
 crates/meilisearch/tests/search/filters.rs           | 2 +-
 crates/milli/src/index.rs                            | 2 +-
 crates/milli/src/search/facet/filter.rs              | 4 +---
 crates/milli/src/search/facet/filter_vector.rs       | 1 -
 crates/milli/src/update/index_documents/transform.rs | 2 +-
 5 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/crates/meilisearch/tests/search/filters.rs b/crates/meilisearch/tests/search/filters.rs
index 2e71b5435..3cc7cbab5 100644
--- a/crates/meilisearch/tests/search/filters.rs
+++ b/crates/meilisearch/tests/search/filters.rs
@@ -1003,7 +1003,7 @@ async fn vector_filter_negation() {
 
 #[actix_rt::test]
 async fn vector_filter_or_combination() {
-let index = crate::vector::shared_index_for_fragments().await;
+    let index = crate::vector::shared_index_for_fragments().await;
 
     let (value, _code) = index
         .search_post(json!({
diff --git a/crates/milli/src/index.rs b/crates/milli/src/index.rs
index 2751498bf..b2ec992ba 100644
--- a/crates/milli/src/index.rs
+++ b/crates/milli/src/index.rs
@@ -1776,7 +1776,7 @@ impl Index {
                 embedder_info.embedder_id,
                 config.config.quantized(),
             );
-            let embeddings = reader.item_vectors(rtxn, docid)?; // MARKER
+            let embeddings = reader.item_vectors(rtxn, docid)?;
             res.insert(
                 config.name.to_owned(),
                 (embeddings, embedder_info.embedding_status.must_regenerate(docid)),
diff --git a/crates/milli/src/search/facet/filter.rs b/crates/milli/src/search/facet/filter.rs
index c0419997c..1afdf87e6 100644
--- a/crates/milli/src/search/facet/filter.rs
+++ b/crates/milli/src/search/facet/filter.rs
@@ -234,11 +234,9 @@ impl<'a> Filter<'a> {
     pub fn evaluate(&self, rtxn: &heed::RoTxn<'_>, index: &Index) -> Result<RoaringBitmap> {
         // to avoid doing this for each recursive call we're going to do it ONCE ahead of time
         let fields_ids_map = index.fields_ids_map(rtxn)?;
-        let filterable_attributes_rules = dbg!(index.filterable_attributes_rules(rtxn)?);
+        let filterable_attributes_rules = index.filterable_attributes_rules(rtxn)?;
 
         for fid in self.condition.fids(MAX_FILTER_DEPTH) {
-            println!("{fid:?}");
-
             let attribute = fid.value();
             if matching_features(attribute, &filterable_attributes_rules)
                 .is_some_and(|(_, features)| features.is_filterable())
diff --git a/crates/milli/src/search/facet/filter_vector.rs b/crates/milli/src/search/facet/filter_vector.rs
index 0a7ac313a..79e35366c 100644
--- a/crates/milli/src/search/facet/filter_vector.rs
+++ b/crates/milli/src/search/facet/filter_vector.rs
@@ -9,7 +9,6 @@ pub(super) struct VectorFilter<'a> {
     embedder_token: Option<Token<'a>>,
     fragment_token: Option<Token<'a>>,
     user_provided: bool,
-    // TODO: not_user_provided: bool,
 }
 
 #[derive(Debug)]
diff --git a/crates/milli/src/update/index_documents/transform.rs b/crates/milli/src/update/index_documents/transform.rs
index d69768d4b..e07483aff 100644
--- a/crates/milli/src/update/index_documents/transform.rs
+++ b/crates/milli/src/update/index_documents/transform.rs
@@ -966,7 +966,7 @@ impl<'a, 'i> Transform<'a, 'i> {
                 // some user provided, remove only the ids that are not user provided
                 let to_delete = arroy.items_in_store(wtxn, *fragment_id, |items| {
                     items - infos.embedding_status.user_provided_docids()
-                })?; // MARKER
+                })?;
 
                 for to_delete in to_delete {
                     arroy.del_item_in_store(wtxn, to_delete, *fragment_id, dimensions)?;