From 114d50dfbacd4ec40ff7a44326dd2ac663ed7e63 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Renault?= Date: Thu, 7 Aug 2025 14:34:57 +0200 Subject: [PATCH] Always use at least an ef = 100 when searching --- crates/milli/src/vector/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/milli/src/vector/mod.rs b/crates/milli/src/vector/mod.rs index 854ce9e74..50c947f12 100644 --- a/crates/milli/src/vector/mod.rs +++ b/crates/milli/src/vector/mod.rs @@ -471,7 +471,7 @@ impl VectorStore { for reader in self.readers(rtxn, db) { let reader = reader?; let mut searcher = reader.nns(limit); - searcher.ef_search(limit * 10); // TODO find better ef + searcher.ef_search((limit * 10).max(100)); // TODO find better ef if let Some(filter) = filter { if reader.item_ids().is_disjoint(filter) { continue; @@ -514,7 +514,7 @@ impl VectorStore { for reader in self.readers(rtxn, db) { let reader = reader?; let mut searcher = reader.nns(limit); - searcher.ef_search(limit * 10); // TODO find better ef + searcher.ef_search((limit * 10).max(100)); // TODO find better ef if let Some(filter) = filter { if reader.item_ids().is_disjoint(filter) { continue;