From f2f312b43a89e6e72af50cb9ca8d3285c218809e Mon Sep 17 00:00:00 2001 From: Andy Hsu Date: Tue, 5 Sep 2023 15:46:16 +0800 Subject: [PATCH] fix: http response body not close on status >= 400 (close #5163) --- internal/net/serve.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/net/serve.go b/internal/net/serve.go index eb1ba323..a0566780 100644 --- a/internal/net/serve.go +++ b/internal/net/serve.go @@ -224,9 +224,10 @@ func RequestHttp(ctx context.Context, httpMethod string, headerOverride http.Hea res.Header.Del("set-cookie") if res.StatusCode >= 400 { all, _ := io.ReadAll(res.Body) + _ = res.Body.Close() msg := string(all) log.Debugln(msg) - return res, errors.New(msg) + return nil, fmt.Errorf("http request [%s] failure,status: %d response:%s", URL, res.StatusCode, msg) } return res, nil }